Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore MinItems and MaxItems diff in nested block #118

Merged
merged 4 commits into from
Dec 20, 2022

Conversation

k-yomo
Copy link
Contributor

@k-yomo k-yomo commented Dec 18, 2022

Resolves #117

@k-yomo k-yomo requested a review from a team as a code owner December 18, 2022 14:15
@bflad bflad self-assigned this Dec 19, 2022
@bflad bflad added this to the v0.8.0 milestone Dec 19, 2022
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @k-yomo 👋 Thank you so much for this fix and this appears to do what we would want here! Could you do me a favor and

  • Make the same changes for tf6muxserver so the implementations are consistent in this regard
  • Update the website documentation, e.g. website/docs/plugin/mux/combining-protocol-version-5-providers.mdx, under the Requirements section to something similar to "All provider schemas (except block MinItems/MaxItems`) must match"
  • Create a changelog entry file, e.g. .changelog/118.txt with something similar to
```release-note:bug
tf5muxserver+tf6muxserver: Allow differing provider schema block `MinItems` and `MaxItems` as terraform-plugin-framework does not use those fields for configuration validation
```

Thanks again!

@k-yomo k-yomo requested a review from bflad December 20, 2022 07:58
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @k-yomo 🚀

@bflad bflad merged commit a5a2586 into hashicorp:main Dec 20, 2022
@k-yomo k-yomo deleted the ignore-min-max-items-diff branch December 21, 2022 20:03
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully handle [Max|Min]Item diffs between SDKv2 and plugin framework providers
3 participants