deps: terraform-plugin-framework `v1.0.0` upgrade #28423

jar-b · 2022-12-16T16:16:57Z

Description

Bumps terraform-plugin-framework to v1.0.0. This includes resolving breaking changes.

Breaking Changes

tfsdk.Schema has been removed in favor of the types under the resource, datasource, and provider subpackages (ie. provider/schema.Schema).
tfsdk.Block has been removed in favor of the types under the resource, datasource, and provider subpackages (ie. provider/schema.Block).
Plan modifiers are now broken out by type (ie. planmodifier.String). A default string value implementation is the only existing modifier, and isn't currently used by any resources. This has been updated to a typed string modifier implementation.
provider/schema.Schema no longer supports the MaxItems argument, causing a schema mismatch when muxed with the SDKv2 provider.
- Update terraform-provider-mux to v0.8.0, which will ignore these differences (See Ignore MinItems and MaxItems diff in nested block terraform-plugin-mux#118)

Relations

Closes #28385
Depends on hashicorp/terraform-plugin-framework-timeouts#15
Relates #28119

References

https://github.com/hashicorp/terraform-plugin-framework/releases/tag/v1.0.0

Output from Acceptance Testing

Tests to be run:

#!/bin/bash

set -x

make testacc PKG=auditmanager TESTS="TestAccAuditManagerControl_|TestAccAuditManagerFramework_|TestAccAuditManagerAccountRegistration_" ACCTEST_PARALLELISM=2
make testacc PKG=ec2 TESTS=TestAccVPCSecurityGroupIngressRule_ ACCTEST_PARALLELISM=3
make testacc PKG=globalaccelerator TESTS=TestAccGlobalAcceleratorAcceleratorDataSource_ ACCTEST_PARALLELISM=2
make testacc PKG=medialive TESTS=TestAccMediaLive_serial
make testacc PKG=meta TESTS="TestAccMetaARNDataSource_|TestAccMetaBillingServiceAccountDataSource_|TestAccMetaDefaultTagsDataSource_|TestAccMetaIPRangesDataSource_|TestAccMetaPartitionDataSource_|TestAccMetaRegionDataSource_|TestAccMetaRegionsDataSource_|TestAccMetaService_" ACCTEST_PARALLELISM=2
make testacc PKG=resourceexplorer2 TESTS=TestAccResourceExplorer2_serial
make testacc PKG=simpledb TESTS=TestAccSimpleDBDomain_ ACCTEST_PARALLELISM=3
make testacc PKG=sts TESTS=TestAccSTSCallerIdentityDataSource_

NOTE: The VPC security group ingress rule must be enabled (registration currently commented out) for testing.

NOTE: For MediaLive serial tests, everything except multiplex program tests were commented out.

$ make testacc PKG=auditmanager TESTS="TestAccAuditManagerControl_|TestAccAuditManagerFramework_|TestAccAuditManagerAccountRegistration_" ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/auditmanager/... -v -count 1 -parallel 2 -run='TestAccAuditManagerControl_|TestAccAuditManagerFramework_|TestAccAuditManagerAccountRegistration_'  -timeout 180m
=== RUN   TestAccAuditManagerAccountRegistration_serial
=== RUN   TestAccAuditManagerAccountRegistration_serial/basic
=== RUN   TestAccAuditManagerAccountRegistration_serial/disappears
    account_registration_test.go:65: Environment variable AUDITMANAGER_DEREGISTER_ACCOUNT_ON_DESTROY is not set
=== RUN   TestAccAuditManagerAccountRegistration_serial/kms_key
--- PASS: TestAccAuditManagerAccountRegistration_serial (42.72s)
    --- PASS: TestAccAuditManagerAccountRegistration_serial/basic (12.69s)
    --- SKIP: TestAccAuditManagerAccountRegistration_serial/disappears (0.00s)
    --- PASS: TestAccAuditManagerAccountRegistration_serial/kms_key (30.03s)
=== RUN   TestAccAuditManagerControl_basic
=== PAUSE TestAccAuditManagerControl_basic
=== RUN   TestAccAuditManagerControl_disappears
=== PAUSE TestAccAuditManagerControl_disappears
=== RUN   TestAccAuditManagerControl_tags
=== PAUSE TestAccAuditManagerControl_tags
=== RUN   TestAccAuditManagerControl_optional
=== PAUSE TestAccAuditManagerControl_optional
=== RUN   TestAccAuditManagerControl_optionalSources
=== PAUSE TestAccAuditManagerControl_optionalSources
=== RUN   TestAccAuditManagerFramework_basic
=== PAUSE TestAccAuditManagerFramework_basic
=== RUN   TestAccAuditManagerFramework_disappears
=== PAUSE TestAccAuditManagerFramework_disappears
=== RUN   TestAccAuditManagerFramework_tags
=== PAUSE TestAccAuditManagerFramework_tags
=== RUN   TestAccAuditManagerFramework_optional
=== PAUSE TestAccAuditManagerFramework_optional
=== CONT  TestAccAuditManagerControl_basic
=== CONT  TestAccAuditManagerFramework_basic
--- PASS: TestAccAuditManagerControl_basic (13.15s)
=== CONT  TestAccAuditManagerFramework_optional
--- PASS: TestAccAuditManagerFramework_basic (13.98s)
=== CONT  TestAccAuditManagerFramework_tags
--- PASS: TestAccAuditManagerFramework_optional (23.41s)
=== CONT  TestAccAuditManagerFramework_disappears
--- PASS: TestAccAuditManagerFramework_tags (32.18s)
=== CONT  TestAccAuditManagerControl_optional
--- PASS: TestAccAuditManagerFramework_disappears (11.90s)
=== CONT  TestAccAuditManagerControl_optionalSources
--- PASS: TestAccAuditManagerControl_optional (21.24s)
=== CONT  TestAccAuditManagerControl_tags
--- PASS: TestAccAuditManagerControl_optionalSources (21.47s)
=== CONT  TestAccAuditManagerControl_disappears
--- PASS: TestAccAuditManagerControl_disappears (9.04s)
--- PASS: TestAccAuditManagerControl_tags (30.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager       143.700s

$ make testacc PKG=ec2 TESTS=TestAccVPCSecurityGroupIngressRule_ ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCSecurityGroupIngressRule_'  -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== RUN   TestAccVPCSecurityGroupIngressRule_disappears
=== PAUSE TestAccVPCSecurityGroupIngressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== RUN   TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_ignoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_ignoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== RUN   TestAccVPCSecurityGroupIngressRule_description
=== PAUSE TestAccVPCSecurityGroupIngressRule_description
=== RUN   TestAccVPCSecurityGroupIngressRule_prefixListID
=== PAUSE TestAccVPCSecurityGroupIngressRule_prefixListID
=== RUN   TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== PAUSE TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== RUN   TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== PAUSE TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== RUN   TestAccVPCSecurityGroupIngressRule_updateSourceType
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateSourceType
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_prefixListID
--- PASS: TestAccVPCSecurityGroupIngressRule_basic (20.93s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
    acctest.go:655: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupIngressRule_updateSourceType
--- PASS: TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags (35.26s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv6
--- PASS: TestAccVPCSecurityGroupIngressRule_prefixListID (42.00s)
=== CONT  TestAccVPCSecurityGroupIngressRule_description
--- PASS: TestAccVPCSecurityGroupIngressRule_updateSourceType (31.61s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv4
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv6 (31.77s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ignoreTags
--- PASS: TestAccVPCSecurityGroupIngressRule_description (32.21s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv4 (34.45s)
=== CONT  TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
--- PASS: TestAccVPCSecurityGroupIngressRule_ignoreTags (36.55s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag (0.87s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly (31.33s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply (38.82s)
=== CONT  TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag (38.13s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag (37.38s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID (33.69s)
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly (30.17s)
=== CONT  TestAccVPCSecurityGroupIngressRule_disappears
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly (39.45s)
--- PASS: TestAccVPCSecurityGroupIngressRule_disappears (18.29s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags (43.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        206.052s

$ make testacc PKG=globalaccelerator TESTS=TestAccGlobalAcceleratorAcceleratorDataSource_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 2 -run='TestAccGlobalAcceleratorAcceleratorDataSource_'  -timeout 180m
=== RUN   TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== PAUSE TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== CONT  TestAccGlobalAcceleratorAcceleratorDataSource_basic
--- PASS: TestAccGlobalAcceleratorAcceleratorDataSource_basic (108.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  111.832

$ make testacc PKG=medialive TESTS=TestAccMediaLive_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLive_serial'  -timeout 180m
=== RUN   TestAccMediaLive_serial
=== RUN   TestAccMediaLive_serial/MultiplexProgram
=== RUN   TestAccMediaLive_serial/MultiplexProgram/update
=== RUN   TestAccMediaLive_serial/MultiplexProgram/disappears
=== RUN   TestAccMediaLive_serial/MultiplexProgram/basic
--- PASS: TestAccMediaLive_serial (213.31s)
    --- PASS: TestAccMediaLive_serial/MultiplexProgram (213.31s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/update (86.22s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/disappears (62.91s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/basic (64.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  216.356s

$ make testacc PKG=meta 'TESTS=TestAccMetaARNDataSource_|TestAccMetaBillingServiceAccountDataSource_|TestAccMetaDefaultTagsDataSource_|TestAccMetaIPRangesDataSource_|TestAccMetaPartitionDataSource_|TestAccMetaRegionDataSource_|TestAccMetaRegionsDataSource_|TestAccMetaService_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 2 -run='TestAccMetaARNDataSource_|TestAccMetaBillingServiceAccountDataSource_|TestAccMetaDefaultTagsDataSource_|TestAccMetaIPRangesDataSource_|TestAccMetaPartitionDataSource_|TestAccMetaRegionDataSource_|TestAccMetaRegionsDataSource_|TestAccMetaService_'  -timeout 180m
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaARNDataSource_s3Bucket
=== PAUSE TestAccMetaARNDataSource_s3Bucket
=== RUN   TestAccMetaBillingServiceAccountDataSource_basic
=== PAUSE TestAccMetaBillingServiceAccountDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_basic
=== PAUSE TestAccMetaDefaultTagsDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_empty
=== PAUSE TestAccMetaDefaultTagsDataSource_empty
=== RUN   TestAccMetaDefaultTagsDataSource_multiple
=== PAUSE TestAccMetaDefaultTagsDataSource_multiple
=== RUN   TestAccMetaDefaultTagsDataSource_ignore
=== PAUSE TestAccMetaDefaultTagsDataSource_ignore
=== RUN   TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN   TestAccMetaIPRangesDataSource_none
=== PAUSE TestAccMetaIPRangesDataSource_none
=== RUN   TestAccMetaIPRangesDataSource_url
=== PAUSE TestAccMetaIPRangesDataSource_url
=== RUN   TestAccMetaIPRangesDataSource_uppercase
=== PAUSE TestAccMetaIPRangesDataSource_uppercase
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== RUN   TestAccMetaRegionDataSource_endpointAndName
=== PAUSE TestAccMetaRegionDataSource_endpointAndName
=== RUN   TestAccMetaRegionDataSource_name
=== PAUSE TestAccMetaRegionDataSource_name
=== RUN   TestAccMetaRegionsDataSource_basic
=== PAUSE TestAccMetaRegionsDataSource_basic
=== RUN   TestAccMetaRegionsDataSource_filter
=== PAUSE TestAccMetaRegionsDataSource_filter
=== RUN   TestAccMetaRegionsDataSource_allRegions
=== PAUSE TestAccMetaRegionsDataSource_allRegions
=== RUN   TestAccMetaRegionsDataSource_nonExistentRegion
=== PAUSE TestAccMetaRegionsDataSource_nonExistentRegion
=== RUN   TestAccMetaService_basic
=== PAUSE TestAccMetaService_basic
=== RUN   TestAccMetaService_byReverseDNSName
=== PAUSE TestAccMetaService_byReverseDNSName
=== RUN   TestAccMetaService_byDNSName
=== PAUSE TestAccMetaService_byDNSName
=== RUN   TestAccMetaService_byParts
=== PAUSE TestAccMetaService_byParts
=== RUN   TestAccMetaService_unsupported
=== PAUSE TestAccMetaService_unsupported
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
--- PASS: TestAccMetaARNDataSource_basic (8.19s)
=== CONT  TestAccMetaIPRangesDataSource_basic
--- PASS: TestAccMetaRegionDataSource_endpoint (10.10s)
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaIPRangesDataSource_basic (8.35s)
=== CONT  TestAccMetaPartitionDataSource_basic
--- PASS: TestAccMetaRegionDataSource_basic (7.56s)
=== CONT  TestAccMetaIPRangesDataSource_uppercase
--- PASS: TestAccMetaPartitionDataSource_basic (7.72s)
=== CONT  TestAccMetaIPRangesDataSource_url
--- PASS: TestAccMetaIPRangesDataSource_uppercase (8.22s)
=== CONT  TestAccMetaIPRangesDataSource_none
--- PASS: TestAccMetaIPRangesDataSource_url (8.06s)
=== CONT  TestAccMetaDefaultTagsDataSource_empty
--- PASS: TestAccMetaIPRangesDataSource_none (8.06s)
=== CONT  TestAccMetaDefaultTagsDataSource_ignore
--- PASS: TestAccMetaDefaultTagsDataSource_empty (7.52s)
=== CONT  TestAccMetaDefaultTagsDataSource_multiple
--- PASS: TestAccMetaDefaultTagsDataSource_multiple (5.18s)
=== CONT  TestAccMetaRegionsDataSource_nonExistentRegion
--- PASS: TestAccMetaDefaultTagsDataSource_ignore (11.75s)
=== CONT  TestAccMetaService_unsupported
--- PASS: TestAccMetaService_unsupported (7.46s)
=== CONT  TestAccMetaService_byParts
--- PASS: TestAccMetaRegionsDataSource_nonExistentRegion (9.37s)
=== CONT  TestAccMetaService_byDNSName
--- PASS: TestAccMetaService_byParts (7.51s)
=== CONT  TestAccMetaService_byReverseDNSName
--- PASS: TestAccMetaService_byDNSName (7.53s)
=== CONT  TestAccMetaService_basic
--- PASS: TestAccMetaService_byReverseDNSName (7.64s)
=== CONT  TestAccMetaBillingServiceAccountDataSource_basic
--- PASS: TestAccMetaService_basic (7.56s)
=== CONT  TestAccMetaDefaultTagsDataSource_basic
--- PASS: TestAccMetaDefaultTagsDataSource_basic (5.15s)
=== CONT  TestAccMetaARNDataSource_s3Bucket
--- PASS: TestAccMetaBillingServiceAccountDataSource_basic (7.63s)
=== CONT  TestAccMetaRegionsDataSource_basic
--- PASS: TestAccMetaARNDataSource_s3Bucket (7.69s)
=== CONT  TestAccMetaRegionsDataSource_allRegions
--- PASS: TestAccMetaRegionsDataSource_basic (9.69s)
=== CONT  TestAccMetaRegionsDataSource_filter
--- PASS: TestAccMetaRegionsDataSource_allRegions (9.66s)
=== CONT  TestAccMetaRegionDataSource_name
--- PASS: TestAccMetaRegionsDataSource_filter (9.42s)
=== CONT  TestAccMetaRegionDataSource_endpointAndName
--- PASS: TestAccMetaRegionDataSource_name (9.47s)
--- PASS: TestAccMetaRegionDataSource_endpointAndName (9.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/meta       107.612s

$ make testacc PKG=resourceexplorer2 TESTS=TestAccResourceExplorer2_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourceexplorer2/... -v -count 1 -parallel 20 -run='TestAccResourceExplorer2_serial'  -timeout 180m
=== RUN   TestAccResourceExplorer2_serial
=== RUN   TestAccResourceExplorer2_serial/Index
=== RUN   TestAccResourceExplorer2_serial/Index/disappears
=== RUN   TestAccResourceExplorer2_serial/Index/tags
=== RUN   TestAccResourceExplorer2_serial/Index/type
=== RUN   TestAccResourceExplorer2_serial/Index/basic
--- PASS: TestAccResourceExplorer2_serial (104.35s)
    --- PASS: TestAccResourceExplorer2_serial/Index (104.35s)
        --- PASS: TestAccResourceExplorer2_serial/Index/disappears (25.13s)
        --- PASS: TestAccResourceExplorer2_serial/Index/tags (33.48s)
        --- PASS: TestAccResourceExplorer2_serial/Index/type (27.17s)
        --- PASS: TestAccResourceExplorer2_serial/Index/basic (18.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2  107.276s

$ make testacc PKG=simpledb TESTS=TestAccSimpleDBDomain_ ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 3 -run='TestAccSimpleDBDomain_'  -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (10.96s)
--- PASS: TestAccSimpleDBDomain_basic (14.76s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (28.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/simpledb   31.286s

$ make testacc PKG=sts TESTS=TestAccSTSCallerIdentityDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20 -run='TestAccSTSCallerIdentityDataSource_'  -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (8.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sts        11.564s

github-actions · 2022-12-16T16:17:16Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

ewbankkit · 2023-01-03T21:40:36Z

internal/tags/framework.go

@@ -1,23 +1,23 @@
 package tags

 import (
-	"github.com/hashicorp/terraform-plugin-framework/tfsdk"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema"


Note for our future selves: We will probably need data source-specific variants of these now that there are separate resource/schema and datasource/schema packages.

ewbankkit

LGTM 🚀.

% go test -v ./internal/framework/...
?   	github.com/hashicorp/terraform-provider-aws/internal/framework	[no test files]
=== RUN   TestDefaultValue
=== PAUSE TestDefaultValue
=== CONT  TestDefaultValue
=== RUN   TestDefaultValue/default_string_on_create
=== RUN   TestDefaultValue/non-default_non-Null_string
=== RUN   TestDefaultValue/non-default_non-Null_string,_current_Null
=== RUN   TestDefaultValue/non-default_Null_string,_current_Null
=== RUN   TestDefaultValue/default_string
--- PASS: TestDefaultValue (0.00s)
    --- PASS: TestDefaultValue/default_string_on_create (0.00s)
    --- PASS: TestDefaultValue/non-default_non-Null_string (0.00s)
    --- PASS: TestDefaultValue/non-default_non-Null_string,_current_Null (0.00s)
    --- PASS: TestDefaultValue/non-default_Null_string,_current_Null (0.00s)
    --- PASS: TestDefaultValue/default_string (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/stringplanmodifier	1.102s
=== RUN   TestARNTypeValueFromTerraform
=== PAUSE TestARNTypeValueFromTerraform
=== RUN   TestARNTypeValidate
=== PAUSE TestARNTypeValidate
=== RUN   TestDurationTypeValueFromTerraform
=== PAUSE TestDurationTypeValueFromTerraform
=== RUN   TestDurationTypeValidate
=== PAUSE TestDurationTypeValidate
=== CONT  TestARNTypeValueFromTerraform
=== RUN   TestARNTypeValueFromTerraform/valid_ARN
=== CONT  TestDurationTypeValueFromTerraform
=== RUN   TestDurationTypeValueFromTerraform/valid_duration
=== RUN   TestDurationTypeValueFromTerraform/invalid_duration
=== RUN   TestARNTypeValueFromTerraform/invalid_duration
=== RUN   TestARNTypeValueFromTerraform/null_value
=== RUN   TestDurationTypeValueFromTerraform/null_value
=== RUN   TestARNTypeValueFromTerraform/unknown_value
=== RUN   TestDurationTypeValueFromTerraform/unknown_value
--- PASS: TestARNTypeValueFromTerraform (0.00s)
    --- PASS: TestARNTypeValueFromTerraform/valid_ARN (0.00s)
    --- PASS: TestARNTypeValueFromTerraform/invalid_duration (0.00s)
    --- PASS: TestARNTypeValueFromTerraform/null_value (0.00s)
    --- PASS: TestARNTypeValueFromTerraform/unknown_value (0.00s)
=== CONT  TestARNTypeValidate
--- PASS: TestDurationTypeValueFromTerraform (0.00s)
    --- PASS: TestDurationTypeValueFromTerraform/valid_duration (0.00s)
    --- PASS: TestDurationTypeValueFromTerraform/invalid_duration (0.00s)
    --- PASS: TestDurationTypeValueFromTerraform/null_value (0.00s)
    --- PASS: TestDurationTypeValueFromTerraform/unknown_value (0.00s)
=== RUN   TestARNTypeValidate/not_a_string
=== CONT  TestDurationTypeValidate
=== RUN   TestDurationTypeValidate/not_a_string
=== RUN   TestARNTypeValidate/unknown_string
=== RUN   TestARNTypeValidate/null_string
=== RUN   TestARNTypeValidate/valid_string
=== RUN   TestARNTypeValidate/invalid_string
--- PASS: TestARNTypeValidate (0.00s)
    --- PASS: TestARNTypeValidate/not_a_string (0.00s)
    --- PASS: TestARNTypeValidate/unknown_string (0.00s)
    --- PASS: TestARNTypeValidate/null_string (0.00s)
    --- PASS: TestARNTypeValidate/valid_string (0.00s)
    --- PASS: TestARNTypeValidate/invalid_string (0.00s)
=== RUN   TestDurationTypeValidate/unknown_string
=== RUN   TestDurationTypeValidate/null_string
=== RUN   TestDurationTypeValidate/valid_string
=== RUN   TestDurationTypeValidate/invalid_string
--- PASS: TestDurationTypeValidate (0.00s)
    --- PASS: TestDurationTypeValidate/not_a_string (0.00s)
    --- PASS: TestDurationTypeValidate/unknown_string (0.00s)
    --- PASS: TestDurationTypeValidate/null_string (0.00s)
    --- PASS: TestDurationTypeValidate/valid_string (0.00s)
    --- PASS: TestDurationTypeValidate/invalid_string (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/types	0.908s
=== RUN   TestIPv4CIDRNetworkAddressValidator
=== PAUSE TestIPv4CIDRNetworkAddressValidator
=== RUN   TestIPv6CIDRNetworkAddressValidator
=== PAUSE TestIPv6CIDRNetworkAddressValidator
=== CONT  TestIPv4CIDRNetworkAddressValidator
=== RUN   TestIPv4CIDRNetworkAddressValidator/null_String
=== CONT  TestIPv6CIDRNetworkAddressValidator
=== RUN   TestIPv4CIDRNetworkAddressValidator/invalid_String
=== RUN   TestIPv6CIDRNetworkAddressValidator/invalid_String
=== RUN   TestIPv4CIDRNetworkAddressValidator/valid_IPv4_CIDR
=== RUN   TestIPv6CIDRNetworkAddressValidator/valid_IPv6_CIDR
=== RUN   TestIPv4CIDRNetworkAddressValidator/invalid_IPv4_CIDR
=== RUN   TestIPv4CIDRNetworkAddressValidator/valid_IPv6_CIDR
=== RUN   TestIPv6CIDRNetworkAddressValidator/invalid_IPv6_CIDR
=== RUN   TestIPv4CIDRNetworkAddressValidator/unknown_String
=== RUN   TestIPv6CIDRNetworkAddressValidator/valid_IPv4_CIDR
--- PASS: TestIPv4CIDRNetworkAddressValidator (0.00s)
    --- PASS: TestIPv4CIDRNetworkAddressValidator/null_String (0.00s)
    --- PASS: TestIPv4CIDRNetworkAddressValidator/invalid_String (0.00s)
    --- PASS: TestIPv4CIDRNetworkAddressValidator/valid_IPv4_CIDR (0.00s)
    --- PASS: TestIPv4CIDRNetworkAddressValidator/invalid_IPv4_CIDR (0.00s)
    --- PASS: TestIPv4CIDRNetworkAddressValidator/valid_IPv6_CIDR (0.00s)
    --- PASS: TestIPv4CIDRNetworkAddressValidator/unknown_String (0.00s)
=== RUN   TestIPv6CIDRNetworkAddressValidator/unknown_String
=== RUN   TestIPv6CIDRNetworkAddressValidator/null_String
--- PASS: TestIPv6CIDRNetworkAddressValidator (0.00s)
    --- PASS: TestIPv6CIDRNetworkAddressValidator/invalid_String (0.00s)
    --- PASS: TestIPv6CIDRNetworkAddressValidator/valid_IPv6_CIDR (0.00s)
    --- PASS: TestIPv6CIDRNetworkAddressValidator/invalid_IPv6_CIDR (0.00s)
    --- PASS: TestIPv6CIDRNetworkAddressValidator/valid_IPv4_CIDR (0.00s)
    --- PASS: TestIPv6CIDRNetworkAddressValidator/unknown_String (0.00s)
    --- PASS: TestIPv6CIDRNetworkAddressValidator/null_String (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/validators	0.706s

github-actions · 2023-01-05T22:54:47Z

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-02-05T02:20:03Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jar-b mentioned this pull request Dec 16, 2022

Gracefully handle [Max|Min]Item diffs between SDKv2 and plugin framework providers hashicorp/terraform-plugin-mux#117

Closed

jar-b force-pushed the td-plugin-framework-1.0.0 branch from ae049db to eea1b7f Compare December 19, 2022 15:40

github-actions bot added the service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. label Dec 19, 2022

jar-b force-pushed the td-plugin-framework-1.0.0 branch 2 times, most recently from 7bac920 to c4effd3 Compare December 19, 2022 19:26

deps: bump terraform-plugin-framework to 1.0.0

1c8c7ac

jar-b force-pushed the td-plugin-framework-1.0.0 branch from c4effd3 to a50c112 Compare January 3, 2023 19:32

jar-b added 2 commits January 3, 2023 15:15

refactor(fw): terraform-plugin-framework v1.0.0 updates

f9e8b06

refactor(fw): terraform-plugin-framework-timeouts v0.3.0 updates

4eb52d3

jar-b force-pushed the td-plugin-framework-1.0.0 branch from a50c112 to 4eb52d3 Compare January 3, 2023 20:15

github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Jan 3, 2023

jar-b added 2 commits January 3, 2023 15:43

r/aws_vpc_security_group_egress_rule: update registration

7e80158

r/aws_vpc_security_group_ingress_rule: update registration

ff5eb47

github-actions bot added the service/vpc Issues and PRs that pertain to the vpc service. label Jan 3, 2023

jar-b marked this pull request as ready for review January 3, 2023 21:08

ewbankkit reviewed Jan 3, 2023

View reviewed changes

ewbankkit approved these changes Jan 3, 2023

View reviewed changes

jar-b merged commit dfb0fd9 into main Jan 3, 2023

jar-b deleted the td-plugin-framework-1.0.0 branch January 3, 2023 21:44

github-actions bot added this to the v4.49.0 milestone Jan 3, 2023

ewbankkit mentioned this pull request Jan 12, 2023

framework/types/ARN: Implement types.StringTypable and types.StringValuable interfaces #27888

Closed

github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: terraform-plugin-framework `v1.0.0` upgrade #28423

deps: terraform-plugin-framework `v1.0.0` upgrade #28423

jar-b commented Dec 16, 2022 •

edited

Loading

github-actions bot commented Dec 16, 2022

ewbankkit Jan 3, 2023

ewbankkit left a comment

github-actions bot commented Jan 5, 2023

github-actions bot commented Feb 5, 2023

deps: terraform-plugin-framework v1.0.0 upgrade #28423

deps: terraform-plugin-framework v1.0.0 upgrade #28423

Conversation

jar-b commented Dec 16, 2022 • edited Loading

Description

Breaking Changes

Relations

References

Output from Acceptance Testing

github-actions bot commented Dec 16, 2022

Community Note

ewbankkit Jan 3, 2023

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 5, 2023

github-actions bot commented Feb 5, 2023

deps: terraform-plugin-framework `v1.0.0` upgrade #28423

deps: terraform-plugin-framework `v1.0.0` upgrade #28423

jar-b commented Dec 16, 2022 •

edited

Loading