Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: terraform-plugin-framework v0.17.0 upgrade #28119

Merged
merged 5 commits into from
Dec 5, 2022
Merged

deps: terraform-plugin-framework v0.17.0 upgrade #28119

merged 5 commits into from
Dec 5, 2022

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Dec 1, 2022 •
edited
Loading

Description

Bumps terraform-plugin-framework to v0.17.0. This includes resolving breaking changes and replacing deprecated features.

Breaking Changes

  • The Provider, Resource, and DataSource interfaces have all removed the GetSchema method (see v0.16.0 vs. 0.17.0)
    • Proposed Fix: Use a type assertion inside the wrapped[Resource|DataSource] GetSchema methods to covert inner to the appropriate ...WithGetSchema interface. Failed assertions result in an error.

Deprecated Features

  • All GetSchema methods have been deprecated in favor of Schema. The two methods have different signatures.
    • Proposed Change: Migrate existing tfsdk.Schema types to the appropriate subpackage equivalent.
GetSchema(context.Context) (tfsdk.Schema, diag.Diagnostics)
Schema(context.Context, SchemaRequest, *SchemaResponse)
  • tfsdk.Schema has been deprecated in favor of the types under the resource, datasource, and provider subpackages (ie. resource/schema.Schema).

References

Output from Acceptance Testing

Tests to be run:

make testacc PKG=ec2 TESTS=TestAccVPCSecurityGroupIngressRule_ ACCTEST_PARALLELISM=3
make testacc PKG=globalaccelerator TESTS=TestAccGlobalAcceleratorAcceleratorDataSource_ ACCTEST_PARALLELISM=2
make testacc PKG=medialive TESTS=TestAccMediaLive_serial
make testacc PKG=meta TESTS="TestAccMetaARNDataSource_|TestAccMetaBillingServiceAccountDataSource_|TestAccMetaDefaultTagsDataSource_|TestAccMetaIPRangesDataSource_|TestAccMetaPartitionDataSource_|TestAccMetaRegionDataSource_|TestAccMetaRegionsDataSource_|TestAccMetaService_" ACCTEST_PARALLELISM=2
make testacc PKG=simpledb TESTS=TestAccSimpleDBDomain_ ACCTEST_PARALLELISM=3
make testacc PKG=sts TESTS=TestAccSTSCallerIdentityDataSource_

NOTE: The VPC security group ingress rule must be enabled (registration currently commented out) for testing.

NOTE: For MediaLive serial tests, everything except multiplex program tests were commented out.

$ make testacc PKG=ec2 TESTS=TestAccVPCSecurityGroupIngressRule_ ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCSecurityGroupIngressRule_'  -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== RUN   TestAccVPCSecurityGroupIngressRule_disappears
=== PAUSE TestAccVPCSecurityGroupIngressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== RUN   TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_ignoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_ignoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== RUN   TestAccVPCSecurityGroupIngressRule_description
=== PAUSE TestAccVPCSecurityGroupIngressRule_description
=== RUN   TestAccVPCSecurityGroupIngressRule_prefixListID
=== PAUSE TestAccVPCSecurityGroupIngressRule_prefixListID
=== RUN   TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== PAUSE TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== RUN   TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== PAUSE TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== RUN   TestAccVPCSecurityGroupIngressRule_updateSourceType
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateSourceType
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_prefixListID
--- PASS: TestAccVPCSecurityGroupIngressRule_basic (21.46s)
=== CONT  TestAccVPCSecurityGroupIngressRule_description
--- PASS: TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags (35.82s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv6
--- PASS: TestAccVPCSecurityGroupIngressRule_prefixListID (41.62s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv4
--- PASS: TestAccVPCSecurityGroupIngressRule_description (30.75s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ignoreTags
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv6 (31.25s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
    acctest.go:655: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupIngressRule_updateSourceType
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv4 (31.35s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_ignoreTags (34.84s)
=== CONT  TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
--- PASS: TestAccVPCSecurityGroupIngressRule_updateSourceType (32.62s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag (0.90s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly (30.93s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply (38.48s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag (37.82s)
=== CONT  TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag (36.65s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly (37.95s)
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly (29.84s)
=== CONT  TestAccVPCSecurityGroupIngressRule_disappears
--- PASS: TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID (32.60s)
--- PASS: TestAccVPCSecurityGroupIngressRule_disappears (17.61s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags (42.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        208.837s
$ make testacc PKG=globalaccelerator TESTS=TestAccGlobalAcceleratorAcceleratorDataSource_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 2 -run='TestAccGlobalAcceleratorAcceleratorDataSource_'  -timeout 180m
=== RUN   TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== PAUSE TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== CONT  TestAccGlobalAcceleratorAcceleratorDataSource_basic
--- PASS: TestAccGlobalAcceleratorAcceleratorDataSource_basic (230.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  236.163s
$ make testacc PKG=medialive TESTS=TestAccMediaLive_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLive_serial'  -timeout 180m
=== RUN   TestAccMediaLive_serial
=== RUN   TestAccMediaLive_serial/MultiplexProgram
=== RUN   TestAccMediaLive_serial/MultiplexProgram/disappears
=== RUN   TestAccMediaLive_serial/MultiplexProgram/basic
=== RUN   TestAccMediaLive_serial/MultiplexProgram/update
--- PASS: TestAccMediaLive_serial (186.56s)
    --- PASS: TestAccMediaLive_serial/MultiplexProgram (186.56s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/disappears (55.43s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/basic (56.54s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/update (74.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  189.718s
$ make testacc PKG=meta TESTS="TestAccMetaARNDataSource_|TestAccMetaBillingServiceAccountDataSource_|TestAccMetaDefaultTagsDataSource_|TestAccMetaIPRangesDataSource_|TestAccMetaPartitionDataSource_|TestAccMetaRegionDataSource_|TestAccMetaRegionsDataSource_|TestAccMetaService_" ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 2 -run='TestAccMetaARNDataSource_|TestAccMetaBillingServiceAccountDataSource_|TestAccMetaDefaultTagsDataSource_|TestAccMetaIPRangesDataSource_|TestAccMetaPartitionDataSource_|TestAccMetaRegionDataSource_|TestAccMetaRegionsDataSource_|TestAccMetaService_'  -timeout 180m
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaARNDataSource_s3Bucket
=== PAUSE TestAccMetaARNDataSource_s3Bucket
=== RUN   TestAccMetaBillingServiceAccountDataSource_basic
=== PAUSE TestAccMetaBillingServiceAccountDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_basic
=== PAUSE TestAccMetaDefaultTagsDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_empty
=== PAUSE TestAccMetaDefaultTagsDataSource_empty
=== RUN   TestAccMetaDefaultTagsDataSource_multiple
=== PAUSE TestAccMetaDefaultTagsDataSource_multiple
=== RUN   TestAccMetaDefaultTagsDataSource_ignore
=== PAUSE TestAccMetaDefaultTagsDataSource_ignore
=== RUN   TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN   TestAccMetaIPRangesDataSource_none
=== PAUSE TestAccMetaIPRangesDataSource_none
=== RUN   TestAccMetaIPRangesDataSource_url
=== PAUSE TestAccMetaIPRangesDataSource_url
=== RUN   TestAccMetaIPRangesDataSource_uppercase
=== PAUSE TestAccMetaIPRangesDataSource_uppercase
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== RUN   TestAccMetaRegionDataSource_endpointAndName
=== PAUSE TestAccMetaRegionDataSource_endpointAndName
=== RUN   TestAccMetaRegionDataSource_name
=== PAUSE TestAccMetaRegionDataSource_name
=== RUN   TestAccMetaRegionsDataSource_basic
=== PAUSE TestAccMetaRegionsDataSource_basic
=== RUN   TestAccMetaRegionsDataSource_filter
=== PAUSE TestAccMetaRegionsDataSource_filter
=== RUN   TestAccMetaRegionsDataSource_allRegions
=== PAUSE TestAccMetaRegionsDataSource_allRegions
=== RUN   TestAccMetaRegionsDataSource_nonExistentRegion
=== PAUSE TestAccMetaRegionsDataSource_nonExistentRegion
=== RUN   TestAccMetaService_basic
=== PAUSE TestAccMetaService_basic
=== RUN   TestAccMetaService_byReverseDNSName
=== PAUSE TestAccMetaService_byReverseDNSName
=== RUN   TestAccMetaService_byDNSName
=== PAUSE TestAccMetaService_byDNSName
=== RUN   TestAccMetaService_byParts
=== PAUSE TestAccMetaService_byParts
=== RUN   TestAccMetaService_unsupported
=== PAUSE TestAccMetaService_unsupported
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
--- PASS: TestAccMetaARNDataSource_basic (8.06s)
=== CONT  TestAccMetaRegionsDataSource_nonExistentRegion
--- PASS: TestAccMetaRegionDataSource_endpoint (9.84s)
=== CONT  TestAccMetaService_unsupported
--- PASS: TestAccMetaService_unsupported (7.56s)
=== CONT  TestAccMetaService_byParts
--- PASS: TestAccMetaRegionsDataSource_nonExistentRegion (9.35s)
=== CONT  TestAccMetaService_byDNSName
--- PASS: TestAccMetaService_byDNSName (7.82s)
=== CONT  TestAccMetaService_byReverseDNSName
=== CONT  TestAccMetaService_basic
--- PASS: TestAccMetaService_byParts (7.83s)
--- PASS: TestAccMetaService_basic (7.80s)
=== CONT  TestAccMetaIPRangesDataSource_basic
--- PASS: TestAccMetaService_byReverseDNSName (7.83s)
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaRegionDataSource_basic (7.48s)
=== CONT  TestAccMetaPartitionDataSource_basic
--- PASS: TestAccMetaIPRangesDataSource_basic (8.17s)
=== CONT  TestAccMetaIPRangesDataSource_uppercase
--- PASS: TestAccMetaPartitionDataSource_basic (7.49s)
=== CONT  TestAccMetaIPRangesDataSource_url
--- PASS: TestAccMetaIPRangesDataSource_uppercase (8.15s)
=== CONT  TestAccMetaIPRangesDataSource_none
--- PASS: TestAccMetaIPRangesDataSource_url (8.08s)
=== CONT  TestAccMetaRegionsDataSource_basic
--- PASS: TestAccMetaIPRangesDataSource_none (8.12s)
=== CONT  TestAccMetaRegionsDataSource_allRegions
--- PASS: TestAccMetaRegionsDataSource_basic (9.37s)
=== CONT  TestAccMetaRegionsDataSource_filter
--- PASS: TestAccMetaRegionsDataSource_allRegions (9.44s)
=== CONT  TestAccMetaDefaultTagsDataSource_empty
--- PASS: TestAccMetaDefaultTagsDataSource_empty (7.60s)
=== CONT  TestAccMetaDefaultTagsDataSource_ignore
--- PASS: TestAccMetaRegionsDataSource_filter (9.35s)
=== CONT  TestAccMetaDefaultTagsDataSource_multiple
--- PASS: TestAccMetaDefaultTagsDataSource_multiple (5.25s)
=== CONT  TestAccMetaBillingServiceAccountDataSource_basic
--- PASS: TestAccMetaDefaultTagsDataSource_ignore (11.73s)
=== CONT  TestAccMetaDefaultTagsDataSource_basic
--- PASS: TestAccMetaBillingServiceAccountDataSource_basic (7.51s)
=== CONT  TestAccMetaARNDataSource_s3Bucket
--- PASS: TestAccMetaDefaultTagsDataSource_basic (5.22s)
=== CONT  TestAccMetaRegionDataSource_name
--- PASS: TestAccMetaARNDataSource_s3Bucket (7.56s)
=== CONT  TestAccMetaRegionDataSource_endpointAndName
--- PASS: TestAccMetaRegionDataSource_name (9.41s)
--- PASS: TestAccMetaRegionDataSource_endpointAndName (9.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/meta       107.500s
$ make testacc PKG=simpledb TESTS=TestAccSimpleDBDomain_ ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 3 -run='TestAccSimpleDBDomain_'  -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (10.74s)
--- PASS: TestAccSimpleDBDomain_basic (14.46s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (27.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/simpledb   30.879s
$ make testacc PKG=sts TESTS=TestAccSTSCallerIdentityDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20 -run='TestAccSTSCallerIdentityDataSource_'  -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (8.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sts        11.251s

@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/medialive Issues and PRs that pertain to the medialive service. service/meta service/simpledb Issues and PRs that pertain to the simpledb service. service/sts Issues and PRs that pertain to the sts service. service/vpc Issues and PRs that pertain to the vpc service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 1, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed service/simpledb Issues and PRs that pertain to the simpledb service. service/vpc Issues and PRs that pertain to the vpc service. service/medialive Issues and PRs that pertain to the medialive service. sweeper Pertains to changes to or issues with the sweeper. service/meta service/sts Issues and PRs that pertain to the sts service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. generators Relates to code generators. size/L Managed by automation to categorize the size of a PR. labels Dec 1, 2022
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/medialive Issues and PRs that pertain to the medialive service. service/meta service/simpledb Issues and PRs that pertain to the simpledb service. service/sts Issues and PRs that pertain to the sts service. labels Dec 1, 2022
@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 1, 2022
@ewbankkit ewbankkit mentioned this pull request Dec 2, 2022
Merged
@jar-b
deps: bump terraform-plugin-framework to 0.17.0
3ee720e
@jar-b
deps: bump terraform-plugin-framework-validators to 0.7.0
03d73b0
@jar-b
fix(fw): assert WithGetSchema interface extension
1e9e45f
@jar-b
refactor(fw): GetSchema -> Schema
07e733a 
fix: update custom arn attribute type

fix(tfsdk2fw): update Schema return

fix: update IDAttribute to resource schema

fix: update NormalizeIPProtocol plan modifier

fix(fw): update ip cidr validators

fix(enum): update to string validator interface

fix(fw): update int64 between validator

fix(fw): migrate blocks to updated schema
@jar-b jar-b marked this pull request as ready for review December 5, 2022 16:15
@jar-b jar-b mentioned this pull request Dec 5, 2022
Merged
@ewbankkit ewbankkit assigned ewbankkit and unassigned ewbankkit Dec 5, 2022
ewbankkit
ewbankkit approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMeta' PKG=meta ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 3  -run=TestAccMeta -timeout 180m
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaARNDataSource_s3Bucket
=== PAUSE TestAccMetaARNDataSource_s3Bucket
=== RUN   TestAccMetaBillingServiceAccountDataSource_basic
=== PAUSE TestAccMetaBillingServiceAccountDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_basic
=== PAUSE TestAccMetaDefaultTagsDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_empty
=== PAUSE TestAccMetaDefaultTagsDataSource_empty
=== RUN   TestAccMetaDefaultTagsDataSource_multiple
=== PAUSE TestAccMetaDefaultTagsDataSource_multiple
=== RUN   TestAccMetaDefaultTagsDataSource_ignore
=== PAUSE TestAccMetaDefaultTagsDataSource_ignore
=== RUN   TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN   TestAccMetaIPRangesDataSource_none
=== PAUSE TestAccMetaIPRangesDataSource_none
=== RUN   TestAccMetaIPRangesDataSource_url
=== PAUSE TestAccMetaIPRangesDataSource_url
=== RUN   TestAccMetaIPRangesDataSource_uppercase
=== PAUSE TestAccMetaIPRangesDataSource_uppercase
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== RUN   TestAccMetaRegionDataSource_endpointAndName
=== PAUSE TestAccMetaRegionDataSource_endpointAndName
=== RUN   TestAccMetaRegionDataSource_name
=== PAUSE TestAccMetaRegionDataSource_name
=== RUN   TestAccMetaRegionsDataSource_basic
=== PAUSE TestAccMetaRegionsDataSource_basic
=== RUN   TestAccMetaRegionsDataSource_filter
=== PAUSE TestAccMetaRegionsDataSource_filter
=== RUN   TestAccMetaRegionsDataSource_allRegions
=== PAUSE TestAccMetaRegionsDataSource_allRegions
=== RUN   TestAccMetaRegionsDataSource_nonExistentRegion
=== PAUSE TestAccMetaRegionsDataSource_nonExistentRegion
=== RUN   TestAccMetaService_basic
=== PAUSE TestAccMetaService_basic
=== RUN   TestAccMetaService_byReverseDNSName
=== PAUSE TestAccMetaService_byReverseDNSName
=== RUN   TestAccMetaService_byDNSName
=== PAUSE TestAccMetaService_byDNSName
=== RUN   TestAccMetaService_byParts
=== PAUSE TestAccMetaService_byParts
=== RUN   TestAccMetaService_unsupported
=== PAUSE TestAccMetaService_unsupported
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaRegionsDataSource_nonExistentRegion
--- PASS: TestAccMetaARNDataSource_basic (10.87s)
=== CONT  TestAccMetaRegionsDataSource_basic
--- PASS: TestAccMetaRegionsDataSource_nonExistentRegion (13.04s)
=== CONT  TestAccMetaRegionsDataSource_allRegions
--- PASS: TestAccMetaRegionDataSource_endpoint (13.06s)
=== CONT  TestAccMetaRegionsDataSource_filter
--- PASS: TestAccMetaRegionsDataSource_basic (11.84s)
=== CONT  TestAccMetaIPRangesDataSource_basic
--- PASS: TestAccMetaRegionsDataSource_filter (12.12s)
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaRegionsDataSource_allRegions (12.17s)
=== CONT  TestAccMetaPartitionDataSource_basic
--- PASS: TestAccMetaIPRangesDataSource_basic (11.38s)
=== CONT  TestAccMetaIPRangesDataSource_uppercase
--- PASS: TestAccMetaPartitionDataSource_basic (10.08s)
=== CONT  TestAccMetaIPRangesDataSource_url
=== CONT  TestAccMetaIPRangesDataSource_none
--- PASS: TestAccMetaRegionDataSource_basic (10.14s)
--- PASS: TestAccMetaIPRangesDataSource_uppercase (11.02s)
=== CONT  TestAccMetaDefaultTagsDataSource_empty
--- PASS: TestAccMetaIPRangesDataSource_url (11.09s)
=== CONT  TestAccMetaDefaultTagsDataSource_ignore
--- PASS: TestAccMetaIPRangesDataSource_none (11.70s)
=== CONT  TestAccMetaDefaultTagsDataSource_multiple
--- PASS: TestAccMetaDefaultTagsDataSource_multiple (8.15s)
=== CONT  TestAccMetaBillingServiceAccountDataSource_basic
--- PASS: TestAccMetaDefaultTagsDataSource_empty (10.18s)
=== CONT  TestAccMetaDefaultTagsDataSource_basic
--- PASS: TestAccMetaDefaultTagsDataSource_basic (7.91s)
=== CONT  TestAccMetaRegionDataSource_name
--- PASS: TestAccMetaDefaultTagsDataSource_ignore (17.07s)
=== CONT  TestAccMetaService_byDNSName
--- PASS: TestAccMetaBillingServiceAccountDataSource_basic (10.04s)
=== CONT  TestAccMetaService_unsupported
--- PASS: TestAccMetaService_byDNSName (9.68s)
=== CONT  TestAccMetaService_byParts
--- PASS: TestAccMetaRegionDataSource_name (11.73s)
=== CONT  TestAccMetaRegionDataSource_endpointAndName
--- PASS: TestAccMetaService_unsupported (9.75s)
=== CONT  TestAccMetaService_byReverseDNSName
--- PASS: TestAccMetaService_byParts (9.80s)
=== CONT  TestAccMetaService_basic
--- PASS: TestAccMetaService_byReverseDNSName (9.76s)
=== CONT  TestAccMetaARNDataSource_s3Bucket
--- PASS: TestAccMetaRegionDataSource_endpointAndName (11.97s)
--- PASS: TestAccMetaService_basic (9.73s)
--- PASS: TestAccMetaARNDataSource_s3Bucket (9.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	99.126s
% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20  -run=TestAccSTSCallerIdentityDataSource_ -timeout 180m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (9.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	15.267s
% make testacc TESTARGS='-run=TestAccGlobalAcceleratorAcceleratorDataSource_' PKG=globalaccelerator
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20  -run=TestAccGlobalAcceleratorAcceleratorDataSource_ -timeout 180m
=== RUN   TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== PAUSE TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== CONT  TestAccGlobalAcceleratorAcceleratorDataSource_basic
--- PASS: TestAccGlobalAcceleratorAcceleratorDataSource_basic (100.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	104.901s
% make testacc TESTARGS='-run=TestAccSimpleDBDomain_' PKG=simpledb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/simpledb/... -v -count 1 -parallel 20  -run=TestAccSimpleDBDomain_ -timeout 180m
=== RUN   TestAccSimpleDBDomain_basic
=== PAUSE TestAccSimpleDBDomain_basic
=== RUN   TestAccSimpleDBDomain_disappears
=== PAUSE TestAccSimpleDBDomain_disappears
=== RUN   TestAccSimpleDBDomain_MigrateFromPluginSDK
=== PAUSE TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_basic
=== CONT  TestAccSimpleDBDomain_MigrateFromPluginSDK
=== CONT  TestAccSimpleDBDomain_disappears
--- PASS: TestAccSimpleDBDomain_disappears (16.89s)
--- PASS: TestAccSimpleDBDomain_basic (20.90s)
--- PASS: TestAccSimpleDBDomain_MigrateFromPluginSDK (57.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	62.511s
% make testacc TESTARGS='-run=TestAccMediaLive_serial/MultiplexProgram' PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20  -run=TestAccMediaLive_serial/MultiplexProgram -timeout 180m
=== RUN   TestAccMediaLive_serial
=== RUN   TestAccMediaLive_serial/MultiplexProgram
=== RUN   TestAccMediaLive_serial/MultiplexProgram/basic
=== RUN   TestAccMediaLive_serial/MultiplexProgram/update
=== RUN   TestAccMediaLive_serial/MultiplexProgram/disappears
--- PASS: TestAccMediaLive_serial (220.63s)
    --- PASS: TestAccMediaLive_serial/MultiplexProgram (220.63s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/basic (81.11s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/update (72.55s)
        --- PASS: TestAccMediaLive_serial/MultiplexProgram/disappears (66.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	225.607s

@jar-b jar-b merged commit be9fb0a into main Dec 5, 2022
@jar-b jar-b deleted the td-framework-0.17 branch December 5, 2022 19:18
@github-actions github-actions bot added this to the v4.46.0 milestone Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced Dec 15, 2022
Closed
Merged
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/medialive Issues and PRs that pertain to the medialive service. service/simpledb Issues and PRs that pertain to the simpledb service. service/sts Issues and PRs that pertain to the sts service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jar-b @ewbankkit