Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_cloudtrail: Tag on create #10730

Closed
DrFaust92 opened this issue Nov 4, 2019 · 2 comments · Fixed by #10818
Closed

r/aws_cloudtrail: Tag on create #10730

DrFaust92 opened this issue Nov 4, 2019 · 2 comments · Fixed by #10818
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service.
Milestone
v2.37.0

Comments

@DrFaust92
Copy link
Collaborator

DrFaust92 commented Nov 4, 2019 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon CloudTrail now supports tagging queues on creation.

This will allow us to remove the not-preferred call to resourceAwsCloudTrailUpdate from resourceAwsCloudTrailCreate and replace with a call to resourceAwsCloudTrailRead.

New or Affected Resource(s)

Potential Terraform Configuration

n/a

References

API reference.

Requires:
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 4, 2019
@DrFaust92 DrFaust92 changed the title r/aws_sqs_queue: Tag on create r/aws_cloudtrail: Tag on create Nov 4, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 4, 2019
@bflad bflad added service/cloudtrail Issues and PRs that pertain to the cloudtrail service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 4, 2019
bflad added a commit that referenced this issue Nov 4, 2019
@bflad
provider: Hashibot issue/PR matching for CloudTrail should not includ…
2c97a1d 
…e trailing underscore

Reference: #10730

The CloudTrail Trail resource is named just `aws_cloudtrail`.
bflad added a commit that referenced this issue Nov 4, 2019
@bflad
Various hashibot labeling fixes/additions (#10732)
f5b1da3 
* provider: Hashibot issue/PR matching for CloudTrail should not include trailing underscore

Reference: #10730

The CloudTrail Trail resource is named just `aws_cloudtrail`.

* provider: Hashibot pull request labeling for route53resolver should include underscore

Reference: #10348

* provider: Add missing pull request labeling for qldb

Reference: #10394

* provider: Fix hashibot pull request labeling for athena

Reference: #10609

* provider: Ensure hashibot labeling for apigateway catches aws_api_gateway_vpc_link

Reference: #10561
@DrFaust92 DrFaust92 mentioned this issue Nov 9, 2019
Merged
@gdavison gdavison added this to the v2.37.0 milestone Nov 16, 2019
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service.
Projects
None yet
Milestone
v2.37.0
Development

Successfully merging a pull request may close this issue.

r/aws_cloudtrail - support Tag on create DrFaust92/terraform-provider-aws
3 participants
@bflad @gdavison @DrFaust92