d/aws_route53_resolver_rule: Don't retrieve tags for rules 'SHARED_WITH_ME'

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10211

Release note for CHANGELOG:

data-source/aws_route53_resolver_rule: Don't retrieve tags for rules shared with the AWS account that owns the data source

Output from acceptance testing:

$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRoute53ResolverRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 1 -run=TestAccDataSourceAwsRoute53ResolverRule_ -timeout 120m
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_basic
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_basic
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_basic
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (41.90s)
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (218.40s)
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (227.76s)
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (244.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	732.452s

[ewbankkit]

$ AWS_ALTERNATE_ACCESS_KEY_ID=AAAAAAAAAAAAAAAAAAAA AWS_ALTERNATE_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRoute53ResolverRule__Shared'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 1 -run=TestAccDataSourceAwsRoute53ResolverRule_Shared -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_SharedByMe
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (224.69s)
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (327.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	551.873s

Requires that the 2 accounts are in the same AWS Organization and that RAM Sharing with AWS Organizations is enabled.
I need to add PreCheck methods for this.

[ewbankkit]

Ended up using the same pattern as in aws/resource_aws_ec2_transit_gateway_vpc_attachment_test.go:

data "aws_organizations_organization" "test" {}

resource "aws_ram_principal_association" "test" {
  principal          = "${data.aws_organizations_organization.test.arn}"
  resource_share_arn = "${aws_ram_resource_share.test.arn}"
}

[dbektas]

any timeline on when is this gonna be merged?

[bflad]

This looks good, thanks for the fix and additional testing, @ewbankkit 🚀

--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (29.29s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (194.42s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (192.54s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (7.87s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (185.97s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (193.63s)

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!