Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ASG early errors issue #25987

Merged
merged 24 commits into from
Aug 5, 2022
Merged

Fix for ASG early errors issue #25987

merged 24 commits into from
Aug 5, 2022

Conversation

obourdon
Copy link
Contributor

@obourdon obourdon commented Jul 26, 2022 •
edited by justinretzolk

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25986

Output from acceptance testing:

See Issue #25986

@github-actions github-actions bot added service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 26, 2022
@obourdon
Copy link
Contributor Author

Please note that due to golang regexp restrictions (aka not supporting Perl like regexes) I am not able to properly set the matching patterns of the new tests as returned errors in case of timeout are a super-set of the errors returned early

I would have liked to exclude the pattern/prefix Waiting up to .*: Need at least 1 healthy instances in ASG
from the returned error string but I was not able to achieve this in the test code

@obourdon obourdon changed the title Fix for asg early errors issue Fix for ASG early errors issue Jul 27, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 27, 2022
This was referenced Jul 28, 2022
Closed
Closed
@ewbankkit
Add CHANGELOG entry.
eb07352
@ewbankkit
Add 'findScalingActivities' and friends.
873f495
@ewbankkit
r/aws_autoscaling_attachment: Alphabetize attributes.
4e23e3c
@ewbankkit
r/aws_autoscaling_attachment: Tidy up resource Create.
c40f47c
@ewbankkit
r/aws_autoscaling_attachment: Tidy up resource Delete.
377b28c
@ewbankkit
r/aws_autoscaling_attachment: Tidy up resource Read.
164a39d
@ewbankkit
r/aws_autoscaling_attachment: Tidy up ELB attachment tests.
fd20f16
@ewbankkit
r/aws_autoscaling_attachment: Tidy up target group attachment tests.
86638b5
@ewbankkit
r/aws_autoscaling_attachment: Tidy up resource Read.
febab4a
@ewbankkit
r/aws_autoscaling_group: Add 'waitGroupCapacitySatisfied' and friends.
a4ae91a
@ewbankkit
Remove 'waitForASGCapacity' etc.
32ac2c7
@ewbankkit
r/aws_autoscaling_group: Tweak scaling activity error acceptance tests.
be45d0f
@ewbankkit
Remove 'TestAccAutoScalingGroup_withScalingActivityErrorMissingInstan…
0d562bd 
…ceCapabilities'.
@ewbankkit
r/aws_autoscaling_schedule: Tidy up acceptance tests.
166c211 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAutoScalingSchedule_' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingSchedule_ -timeout 180m
=== RUN   TestAccAutoScalingSchedule_basic
=== PAUSE TestAccAutoScalingSchedule_basic
=== RUN   TestAccAutoScalingSchedule_disappears
=== PAUSE TestAccAutoScalingSchedule_disappears
=== RUN   TestAccAutoScalingSchedule_recurrence
=== PAUSE TestAccAutoScalingSchedule_recurrence
=== RUN   TestAccAutoScalingSchedule_zeroValues
=== PAUSE TestAccAutoScalingSchedule_zeroValues
=== RUN   TestAccAutoScalingSchedule_negativeOne
=== PAUSE TestAccAutoScalingSchedule_negativeOne
=== CONT  TestAccAutoScalingSchedule_basic
=== CONT  TestAccAutoScalingSchedule_zeroValues
--- PASS: TestAccAutoScalingSchedule_basic (182.66s)
=== CONT  TestAccAutoScalingSchedule_negativeOne
--- PASS: TestAccAutoScalingSchedule_zeroValues (182.71s)
=== CONT  TestAccAutoScalingSchedule_recurrence
--- PASS: TestAccAutoScalingSchedule_recurrence (181.77s)
=== CONT  TestAccAutoScalingSchedule_disappears
--- PASS: TestAccAutoScalingSchedule_negativeOne (193.97s)
--- PASS: TestAccAutoScalingSchedule_disappears (196.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	572.196s
@ewbankkit
r/aws_autoscaling_schedule: Tidy up resource Create.
5e383f3 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAutoScalingSchedule_' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingSchedule_ -timeout 180m
=== RUN   TestAccAutoScalingSchedule_basic
=== PAUSE TestAccAutoScalingSchedule_basic
=== RUN   TestAccAutoScalingSchedule_disappears
=== PAUSE TestAccAutoScalingSchedule_disappears
=== RUN   TestAccAutoScalingSchedule_recurrence
=== PAUSE TestAccAutoScalingSchedule_recurrence
=== RUN   TestAccAutoScalingSchedule_zeroValues
=== PAUSE TestAccAutoScalingSchedule_zeroValues
=== RUN   TestAccAutoScalingSchedule_negativeOne
=== PAUSE TestAccAutoScalingSchedule_negativeOne
=== CONT  TestAccAutoScalingSchedule_basic
=== CONT  TestAccAutoScalingSchedule_negativeOne
--- PASS: TestAccAutoScalingSchedule_negativeOne (169.20s)
=== CONT  TestAccAutoScalingSchedule_recurrence
--- PASS: TestAccAutoScalingSchedule_basic (180.91s)
=== CONT  TestAccAutoScalingSchedule_zeroValues
--- PASS: TestAccAutoScalingSchedule_recurrence (177.14s)
=== CONT  TestAccAutoScalingSchedule_disappears
--- PASS: TestAccAutoScalingSchedule_zeroValues (167.20s)
--- PASS: TestAccAutoScalingSchedule_disappears (171.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	521.968s
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/elb Issues and PRs that pertain to the elb service. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 4, 2022
ewbankkit
ewbankkit approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingAttachment_' PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingAttachment_ -timeout 180m
=== RUN   TestAccAutoScalingAttachment_elb
=== PAUSE TestAccAutoScalingAttachment_elb
=== RUN   TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== CONT  TestAccAutoScalingAttachment_elb
=== CONT  TestAccAutoScalingAttachment_albTargetGroup
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (109.10s)
--- PASS: TestAccAutoScalingAttachment_elb (114.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	122.097s
% make testacc TESTARGS='-run=TestAccAutoScalingSchedule_' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingSchedule_ -timeout 180m
=== RUN   TestAccAutoScalingSchedule_basic
=== PAUSE TestAccAutoScalingSchedule_basic
=== RUN   TestAccAutoScalingSchedule_disappears
=== PAUSE TestAccAutoScalingSchedule_disappears
=== RUN   TestAccAutoScalingSchedule_recurrence
=== PAUSE TestAccAutoScalingSchedule_recurrence
=== RUN   TestAccAutoScalingSchedule_zeroValues
=== PAUSE TestAccAutoScalingSchedule_zeroValues
=== RUN   TestAccAutoScalingSchedule_negativeOne
=== PAUSE TestAccAutoScalingSchedule_negativeOne
=== CONT  TestAccAutoScalingSchedule_basic
=== CONT  TestAccAutoScalingSchedule_negativeOne
--- PASS: TestAccAutoScalingSchedule_negativeOne (169.20s)
=== CONT  TestAccAutoScalingSchedule_recurrence
--- PASS: TestAccAutoScalingSchedule_basic (180.91s)
=== CONT  TestAccAutoScalingSchedule_zeroValues
--- PASS: TestAccAutoScalingSchedule_recurrence (177.14s)
=== CONT  TestAccAutoScalingSchedule_disappears
--- PASS: TestAccAutoScalingSchedule_zeroValues (167.20s)
--- PASS: TestAccAutoScalingSchedule_disappears (171.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	521.968s
% ACCTEST_TIMEOUT=600m make testacc TESTARGS='-run=TestAccAutoScalingGroup_' PKG=autoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingGroup_ -timeout 600m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_disappears
=== PAUSE TestAccAutoScalingGroup_disappears
=== RUN   TestAccAutoScalingGroup_defaultInstanceWarmup
=== PAUSE TestAccAutoScalingGroup_defaultInstanceWarmup
=== RUN   TestAccAutoScalingGroup_nameGenerated
=== PAUSE TestAccAutoScalingGroup_nameGenerated
=== RUN   TestAccAutoScalingGroup_namePrefix
=== PAUSE TestAccAutoScalingGroup_namePrefix
=== RUN   TestAccAutoScalingGroup_tags
=== PAUSE TestAccAutoScalingGroup_tags
=== RUN   TestAccAutoScalingGroup_deprecatedTags
=== PAUSE TestAccAutoScalingGroup_deprecatedTags
=== RUN   TestAccAutoScalingGroup_simple
=== PAUSE TestAccAutoScalingGroup_simple
=== RUN   TestAccAutoScalingGroup_terminationPolicies
=== PAUSE TestAccAutoScalingGroup_terminationPolicies
=== RUN   TestAccAutoScalingGroup_vpcUpdates
=== PAUSE TestAccAutoScalingGroup_vpcUpdates
=== RUN   TestAccAutoScalingGroup_withLoadBalancer
=== PAUSE TestAccAutoScalingGroup_withLoadBalancer
=== RUN   TestAccAutoScalingGroup_WithLoadBalancer_toTargetGroup
=== PAUSE TestAccAutoScalingGroup_WithLoadBalancer_toTargetGroup
=== RUN   TestAccAutoScalingGroup_withPlacementGroup
=== PAUSE TestAccAutoScalingGroup_withPlacementGroup
=== RUN   TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType
=== PAUSE TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType
=== RUN   TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture
=== PAUSE TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture
=== RUN   TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
=== PAUSE TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
=== RUN   TestAccAutoScalingGroup_enablingMetrics
=== PAUSE TestAccAutoScalingGroup_enablingMetrics
=== RUN   TestAccAutoScalingGroup_withMetrics
=== PAUSE TestAccAutoScalingGroup_withMetrics
=== RUN   TestAccAutoScalingGroup_suspendingProcesses
=== PAUSE TestAccAutoScalingGroup_suspendingProcesses
=== RUN   TestAccAutoScalingGroup_serviceLinkedRoleARN
=== PAUSE TestAccAutoScalingGroup_serviceLinkedRoleARN
=== RUN   TestAccAutoScalingGroup_maxInstanceLifetime
=== PAUSE TestAccAutoScalingGroup_maxInstanceLifetime
=== RUN   TestAccAutoScalingGroup_initialLifecycleHook
=== PAUSE TestAccAutoScalingGroup_initialLifecycleHook
=== RUN   TestAccAutoScalingGroup_launchTemplate
=== PAUSE TestAccAutoScalingGroup_launchTemplate
=== RUN   TestAccAutoScalingGroup_LaunchTemplate_update
=== PAUSE TestAccAutoScalingGroup_LaunchTemplate_update
=== RUN   TestAccAutoScalingGroup_largeDesiredCapacity
=== PAUSE TestAccAutoScalingGroup_largeDesiredCapacity
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_start
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_start
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_triggers
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_triggers
=== RUN   TestAccAutoScalingGroup_loadBalancers
=== PAUSE TestAccAutoScalingGroup_loadBalancers
=== RUN   TestAccAutoScalingGroup_targetGroups
=== PAUSE TestAccAutoScalingGroup_targetGroups
=== RUN   TestAccAutoScalingGroup_ALBTargetGroups_elbCapacity
=== PAUSE TestAccAutoScalingGroup_ALBTargetGroups_elbCapacity
=== RUN   TestAccAutoScalingGroup_warmPool
=== PAUSE TestAccAutoScalingGroup_warmPool
=== RUN   TestAccAutoScalingGroup_launchTempPartitionNum
=== PAUSE TestAccAutoScalingGroup_launchTempPartitionNum
=== RUN   TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn
=== PAUSE TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn
=== RUN   TestAccAutoScalingGroup_mixedInstancesPolicy
=== PAUSE TestAccAutoScalingGroup_mixedInstancesPolicy
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicy_capacityRebalance
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicy_capacityRebalance
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandAllocationStrategy
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandAllocationStrategy
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandBaseCapacity
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandBaseCapacity
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_updateToZeroOnDemandBaseCapacity
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_updateToZeroOnDemandBaseCapacity
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandPercentageAboveBaseCapacity
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandPercentageAboveBaseCapacity
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotAllocationStrategy
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotAllocationStrategy
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotInstancePools
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotInstancePools
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotMaxPrice
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotMaxPrice
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_launchTemplateName
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_launchTemplateName
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_version
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_version
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceType
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceType
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceTypeWithLaunchTemplateSpecification
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceTypeWithLaunchTemplateSpecification
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity_withELB
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity_withELB
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_memoryMiBAndVCPUCount
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_memoryMiBAndVCPUCount
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorCount
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorCount
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorManufacturers
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorManufacturers
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorNames
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorNames
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorTotalMemoryMiB
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorTotalMemoryMiB
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorTypes
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorTypes
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_bareMetal
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_bareMetal
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_baselineEBSBandwidthMbps
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_baselineEBSBandwidthMbps
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_burstablePerformance
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_burstablePerformance
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_cpuManufacturers
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_cpuManufacturers
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_excludedInstanceTypes
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_excludedInstanceTypes
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_instanceGenerations
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_instanceGenerations
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_localStorage
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_localStorage
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_localStorageTypes
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_localStorageTypes
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_memoryGiBPerVCPU
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_memoryGiBPerVCPU
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_networkInterfaceCount
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_networkInterfaceCount
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_onDemandMaxPricePercentageOverLowestPrice
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_onDemandMaxPricePercentageOverLowestPrice
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_requireHibernateSupport
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_requireHibernateSupport
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_spotMaxPricePercentageOverLowestPrice
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_spotMaxPricePercentageOverLowestPrice
=== RUN   TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_totalLocalStorageGB
=== PAUSE TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_totalLocalStorageGB
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicy_capacityRebalance
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorNames
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicy_capacityRebalance (54.52s)
=== CONT  TestAccAutoScalingGroup_suspendingProcesses
--- PASS: TestAccAutoScalingGroup_basic (56.72s)
=== CONT  TestAccAutoScalingGroup_mixedInstancesPolicy
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorNames (87.89s)
=== CONT  TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn
--- PASS: TestAccAutoScalingGroup_mixedInstancesPolicy (52.49s)
=== CONT  TestAccAutoScalingGroup_launchTempPartitionNum
--- PASS: TestAccAutoScalingGroup_launchTempPartitionNum (54.07s)
=== CONT  TestAccAutoScalingGroup_warmPool
--- PASS: TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn (168.25s)
=== CONT  TestAccAutoScalingGroup_ALBTargetGroups_elbCapacity
--- PASS: TestAccAutoScalingGroup_suspendingProcesses (216.54s)
=== CONT  TestAccAutoScalingGroup_targetGroups
--- PASS: TestAccAutoScalingGroup_targetGroups (158.27s)
=== CONT  TestAccAutoScalingGroup_loadBalancers
--- PASS: TestAccAutoScalingGroup_ALBTargetGroups_elbCapacity (261.69s)
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_triggers
--- PASS: TestAccAutoScalingGroup_warmPool (527.61s)
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_start
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (177.16s)
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_basic
--- PASS: TestAccAutoScalingGroup_loadBalancers (409.46s)
=== CONT  TestAccAutoScalingGroup_largeDesiredCapacity
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (186.24s)
=== CONT  TestAccAutoScalingGroup_LaunchTemplate_update
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (236.60s)
=== CONT  TestAccAutoScalingGroup_launchTemplate
--- PASS: TestAccAutoScalingGroup_launchTemplate (56.16s)
=== CONT  TestAccAutoScalingGroup_initialLifecycleHook
--- PASS: TestAccAutoScalingGroup_LaunchTemplate_update (169.85s)
=== CONT  TestAccAutoScalingGroup_maxInstanceLifetime
--- PASS: TestAccAutoScalingGroup_maxInstanceLifetime (68.12s)
=== CONT  TestAccAutoScalingGroup_serviceLinkedRoleARN
--- PASS: TestAccAutoScalingGroup_largeDesiredCapacity (291.53s)
=== CONT  TestAccAutoScalingGroup_vpcUpdates
--- PASS: TestAccAutoScalingGroup_serviceLinkedRoleARN (50.00s)
=== CONT  TestAccAutoScalingGroup_withMetrics
--- PASS: TestAccAutoScalingGroup_vpcUpdates (72.25s)
=== CONT  TestAccAutoScalingGroup_enablingMetrics
--- PASS: TestAccAutoScalingGroup_initialLifecycleHook (224.55s)
=== CONT  TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
--- PASS: TestAccAutoScalingGroup_withMetrics (59.90s)
=== CONT  TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture (27.28s)
=== CONT  TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType
--- PASS: TestAccAutoScalingGroup_enablingMetrics (60.34s)
=== CONT  TestAccAutoScalingGroup_withPlacementGroup
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType (32.57s)
=== CONT  TestAccAutoScalingGroup_WithLoadBalancer_toTargetGroup
--- PASS: TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture (153.93s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_localStorage
--- PASS: TestAccAutoScalingGroup_withPlacementGroup (115.11s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_totalLocalStorageGB
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_localStorage (108.66s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_spotMaxPricePercentageOverLowestPrice
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_totalLocalStorageGB (111.54s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_requireHibernateSupport
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_spotMaxPricePercentageOverLowestPrice (51.60s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_onDemandMaxPricePercentageOverLowestPrice
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_requireHibernateSupport (88.04s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_networkInterfaceCount
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_onDemandMaxPricePercentageOverLowestPrice (51.24s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_memoryGiBPerVCPU
--- PASS: TestAccAutoScalingGroup_WithLoadBalancer_toTargetGroup (384.62s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_localStorageTypes
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_networkInterfaceCount (117.19s)
=== CONT  TestAccAutoScalingGroup_tags
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_memoryGiBPerVCPU (124.87s)
=== CONT  TestAccAutoScalingGroup_withLoadBalancer
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_localStorageTypes (75.49s)
=== CONT  TestAccAutoScalingGroup_nameGenerated
--- PASS: TestAccAutoScalingGroup_nameGenerated (53.26s)
=== CONT  TestAccAutoScalingGroup_namePrefix
--- PASS: TestAccAutoScalingGroup_tags (109.42s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_version
--- PASS: TestAccAutoScalingGroup_namePrefix (44.41s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorManufacturers
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_version (72.71s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorCount
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorManufacturers (73.34s)
=== CONT  TestAccAutoScalingGroup_terminationPolicies
--- PASS: TestAccAutoScalingGroup_withLoadBalancer (250.94s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_memoryMiBAndVCPUCount
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorCount (114.75s)
=== CONT  TestAccAutoScalingGroup_simple
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_memoryMiBAndVCPUCount (102.80s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity_withELB
--- PASS: TestAccAutoScalingGroup_terminationPolicies (147.33s)
=== CONT  TestAccAutoScalingGroup_deprecatedTags
--- PASS: TestAccAutoScalingGroup_deprecatedTags (45.61s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity
--- PASS: TestAccAutoScalingGroup_simple (198.67s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceTypeWithLaunchTemplateSpecification
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceTypeWithLaunchTemplateSpecification (56.57s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceType
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity (177.30s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_burstablePerformance
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceType (63.77s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_excludedInstanceTypes
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity_withELB (271.28s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_cpuManufacturers
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_excludedInstanceTypes (66.42s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_instanceGenerations
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_burstablePerformance (101.10s)
=== CONT  TestAccAutoScalingGroup_defaultInstanceWarmup
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_cpuManufacturers (66.52s)
=== CONT  TestAccAutoScalingGroup_disappears
--- PASS: TestAccAutoScalingGroup_disappears (44.62s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotAllocationStrategy
--- PASS: TestAccAutoScalingGroup_defaultInstanceWarmup (62.30s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotInstancePools
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_instanceGenerations (73.45s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_bareMetal
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotAllocationStrategy (39.42s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotMaxPrice
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotInstancePools (72.70s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_launchTemplateName
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_bareMetal (101.17s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorTypes
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_launchTemplateName (39.19s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_baselineEBSBandwidthMbps
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotMaxPrice (95.56s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorTotalMemoryMiB
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorTypes (65.46s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_updateToZeroOnDemandBaseCapacity
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_baselineEBSBandwidthMbps (91.68s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandPercentageAboveBaseCapacity
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceRequirements_acceleratorTotalMemoryMiB (93.40s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandBaseCapacity
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_updateToZeroOnDemandBaseCapacity (73.54s)
=== CONT  TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandAllocationStrategy
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandPercentageAboveBaseCapacity (57.93s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandAllocationStrategy (48.50s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandBaseCapacity (86.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	2757.537s

@ewbankkit
Copy link
Contributor

@obourdon Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added this to the v4.26.0 milestone Aug 4, 2022
@ewbankkit
Merge branch 'main' into HEAD
56eb039
@ewbankkit
Fix golangci-lint 'nilerr'.
ab7d4c0
@ewbankkit
r/aws_autoscaling_group: Report capacity error via result State.
5d9b565 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_largeDesiredCapacity\|TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroup_largeDesiredCapacity\|TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture -timeout 180m
=== RUN   TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
=== PAUSE TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
=== RUN   TestAccAutoScalingGroup_largeDesiredCapacity
=== PAUSE TestAccAutoScalingGroup_largeDesiredCapacity
=== CONT  TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture
=== CONT  TestAccAutoScalingGroup_largeDesiredCapacity
--- PASS: TestAccAutoScalingGroup_withNoScalingActivityErrorCorrectInstanceArchitecture (177.83s)
--- PASS: TestAccAutoScalingGroup_largeDesiredCapacity (270.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	274.091s
@ewbankkit
Tweak error messages.
960d6da
@obourdon
Copy link
Contributor Author

obourdon commented Aug 5, 2022

@ewbankkit and many thanks to you for the additions and the integration

@ewbankkit ewbankkit merged commit a0d212d into hashicorp:main Aug 5, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Aug 18, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@bateller bateller bateller approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/elb Issues and PRs that pertain to the elb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.26.0
Development

Successfully merging this pull request may close these issues.

Early fatal ASG errors are only reported after complete resource retrial timeout
4 participants
@obourdon @ewbankkit @bateller @justinretzolk