Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AWS Workspaces #434

Closed
hashibot opened this issue Jun 13, 2017 · 33 comments
Closed

Support for AWS Workspaces #434

hashibot opened this issue Jun 13, 2017 · 33 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/workspaces Issues and PRs that pertain to the workspaces service.

Comments

@hashibot
Copy link

This issue was originally opened by @mootpt as hashicorp/terraform#10794. It was migrated here as part of the provider split. The original body of the issue is below.


Support for AWS Workspaces would be great, especially since there is existing support for AWS directory service directories in Terraform. Something like:

resource "aws_workspaces_workspace" {
  bundle_id              = "Some Bundle Id Here"
  directory_id           = "${aws_directory_service_directory.bar.id}"
  user_name              = "foo"
  root_volume_encryption = true,
  user_volume_encryption = false,
  volume_encryption_key  = "${aws_kms_key.foo.key_id}"
}

Ideally it would be nice to also have a aws_workspaces_bundle resource, but I'd settle for the former.

@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 13, 2017
@zachgatesak
Copy link

Checking in on this ticket any updates or has it made it onto the roadmap?

@apparentlymart
Copy link
Contributor

Based on the outcome of hashicorp/terraform#7806 it seems like this is not solvable at this time, though it may have been resolved in the mean time. Nobody on the team at HashiCorp is currently working on this, but we'd be happy to review a new PR for this (possibly based on the existing one) if the necessary API actions are now in place.

@radeksimko radeksimko added the new-resource Introduces a new resource. label Aug 11, 2017
@radeksimko radeksimko added the service/workspaces Issues and PRs that pertain to the workspaces service. label Jan 25, 2018
@foxx
Copy link

foxx commented Aug 2, 2018

Any plans to add support for this soon?

@pjohnstonv
Copy link

This would be nice.

@Miyurz
Copy link

Miyurz commented Oct 22, 2018

Any new updates here ? I'd love to see tf provisioning of AWS workspaces.

@apobbati
Copy link

Any updates?

@kmishra9
Copy link

kmishra9 commented Jan 1, 2019

Will also indicate my interest in this feature here (+1)

@eidast
Copy link

eidast commented Feb 5, 2019

+1

@ryancbutler
Copy link

AWS still hasn't provided any API functionality to register a directory for workspaces making this impossible. Been following this https://forums.aws.amazon.com/thread.jspa?threadID=237801 which AWS has stated there is no ETA.

@bharat109puri
Copy link

@apparentlymart Do we have support for this feature or any ETA ?

@porthunt
Copy link

porthunt commented Apr 9, 2019

@bharat109puri AWS has no ETA:

At this moment, we don't have an ETA on when this feature will be released. However, as soon as it gets released, it should be publicly announced in either the 'AWS News Blog' page [1] or on our 'What's New with AWS' page [2]. I would also recommend you to subscribe to our 'AWS Announcements' page [3].

https://forums.aws.amazon.com/thread.jspa?threadID=237801

Last message from January 15th.

@Tensho
Copy link
Contributor

Tensho commented Sep 24, 2019

Does it make sense to implement AWS WorkSpaces resources aside of directory registration?

@hoo29
Copy link

hoo29 commented Nov 16, 2019

It's finally been released!
https://aws.amazon.com/about-aws/whats-new/2019/11/amazon-workspaces-introduces-workspaces-directory-apis/

Hopefully this means work can progress on the terraform side.

@Tensho
Copy link
Contributor

Tensho commented Nov 26, 2019

Despite Workspaces API is far from sustainable, it's possible to register workspaces directory now and #11023 represents a basis for it. Unfortunately, the full CRUD lifecycle for a resource with all possible attributes can't be implemented with the current API version and I had to request the corresponding features from AWS Support. However, the bare resource is available and its attributes could be easily extended when AWS will complement API.

@elreydetoda
Copy link

This would be very applicable right now with the Corona Virus and everyone having to work from home... is there anyway people (like @cmaxwellau from hashicorp/terraform#10794 ) could push forward whatever is needed for this to get pushed into terraform?

@dgershman
Copy link

Has anyone filed a ticket for a workspaces bundle resource?

@Tensho
Copy link
Contributor

Tensho commented Jun 3, 2020

@radius314 https://www.terraform.io/docs/providers/aws/d/workspaces_bundle.html

Here is extended filtering for it.

@gudlyf
Copy link

gudlyf commented Jun 3, 2020

@Tensho That's data. I think he's asking for a resource (e.g., creating a bundle with TF).

@dgershman
Copy link

@radius314 https://www.terraform.io/docs/providers/aws/d/workspaces_bundle.html

Here is extended filtering for it.

Correct, as @gudlyf mentioned, looking for the resource.

@Tensho
Copy link
Contributor

Tensho commented Jun 3, 2020

Ah, sorry for the confusion 😁 As far as I know there is no API for bundle creation/import, DescribeWorkspaceBundles is the only action.

@lorengordon
Copy link
Contributor

Highly recommend opening a support ticket with AWS to ask for an API for creating Workspace bundles!

@dgershman
Copy link

dgershman commented Jun 3, 2020 via email

@missingcharacter
Copy link
Contributor

I case someone cares, I tried to create a workspace with root volume size 80GB and user volume size 2000GB and got the error below from AWS API:

aws_workspaces_workspace.this: Creating...

Error: InvalidParameterValuesException: Graphics: Invalid root and user volume size selected. Root and user volume size (GB) must be (100+|100+).

Then I tried creating a workspace with root volume size 100GB and user volume size 2000GB, and got the error below from the provider:

Error: expected workspace_properties.0.root_volume_size_gib to be one of [80], got 100

@gdavison
Copy link
Contributor

Hi @missingcharacter, thanks for the feedback. Typically we prefer reporting new issues as a separate GitHub Issue.

It looks like the problem is that the volume size combinations you're using are not available for Workspaces. The valid combinations are listed at https://docs.aws.amazon.com/workspaces/latest/adminguide/modify-workspaces.html#change_volume_sizes. I'll summarize them here:

Root: 80 GB, User: 10 GB
R: 80 GB, U: 50 GB
R: 80 GB, U: 100 GB
R: 175-2000 GB, U: 100-2000 GB

@missingcharacter
Copy link
Contributor

@gdavison that's weird because I was able to create the workspace via the console without a problem:

image

could it be an issue with the API?

@dinesh-AC3
Copy link

Hi

Can someone please help, I am trying to setup AWS workspaces and getting this error:

Error: Invalid resource type

on ../../modules/workspaces/workspaces.tf line 1, in resource "aws_workspaces_workspace" "main":
1: resource "aws_workspaces_workspace" "main" {

The provider provider.aws does not support resource type
"aws_workspaces_workspace".

provider.tf -----> version = "~> 2.43.0"

@missingcharacter
Copy link
Contributor

missingcharacter commented Jul 21, 2020

@dinesh-AC3
Copy link

@dinesh-AC3 I think you need a newer version https://github.com/nxtlytics/ivy-terraform-modules/blob/master/aws/workspace/config.tf#L3

Yeah, thanks mate, figured out just right after I posted this :), really appreciate your reply mate. Regards :)
I looked at https://github.com/terraform-providers/terraform-provider-aws/blob/v2.62.0/CHANGELOG.md and made me realize the version issue.
Really appreciate
Dinesh

@bensunny1
Copy link

I see you can create a workspace directory and a workspace ip group via terraform but can't find a resource to link both(an attachment?). Am i missing something very obvious or is that link not available via terraform yet?

@Tensho
Copy link
Contributor

Tensho commented Jul 31, 2020

@bensunny1 😅 TBH, I've never used IP groups in my setup before. I'll add association in 2-3 days.

@Tensho
Copy link
Contributor

Tensho commented Aug 7, 2020

@bensunny1 It would be nice if you put your voice to #14451. In this case there are more chances this fix will be reviewed by provider maintainers.

@bflad
Copy link
Contributor

bflad commented Nov 25, 2020

Hi folks 👋

Over the past few months, the Terraform AWS Provider has been augmented with WorkSpaces support. As of this writing (version 3.18.0), the following is supported:

Resources:

Data Sources:

Since these types of "support service" issues do not have a good definition of done as time progresses, I'm going to close this issue now since a lot of initial use cases should be covered now. If you have bug reports or feature requests for Workspaces, like this recently created New AWS Workspaces Cross Region Redirection Support, please submit new issues following the templates. Thank you!

@bflad bflad closed this as completed Nov 25, 2020
@ghost
Copy link

ghost commented Dec 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/workspaces Issues and PRs that pertain to the workspaces service.
Projects
None yet
Development

No branches or pull requests