New Resource: aws_workspaces_ip_group

[Tensho]

Relates to #434

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

**New Resource:** `aws_workspaces_ip_group`

Example

resource "aws_workspaces_ip_group" "example" {
  name = "main"
  description = "Main IP access control group"

  rules {
    source = "10.10.10.10/16"
  }

  rules {
    source = "11.11.11.11/16"
    description = "Contractors"
  }
}

Test

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsWorkspacesIpGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesIpGroup_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsWorkspacesIpGroup_basic
=== PAUSE TestAccAwsWorkspacesIpGroup_basic
=== CONT  TestAccAwsWorkspacesIpGroup_basic
--- PASS: TestAccAwsWorkspacesIpGroup_basic (50.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.266s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.026s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.053s [no tests to run]

Notes

This is my first contribution here, please don't hesitate to criticize the PR. I'm eager to make it perfect 🙂
❗️ I need the help to understand the hashing approach for TypeSet values, like rules Documentation doesn't cover how to digest the hash of the set. During HashiCorp Kyiv Meetup #8: Adding new resources to a Terraform Provider @tombuildsstuff suggested to leave all attributes verification to the intermediate import test step. I've done this way, however, I don't like implicit test and do believe explicit one should be more sustainable.

References

• AWS Workspaces DescribeIpGroups
• AWS Workspaces CreateIpGroup
• AWS Workspaces UpdateRulesOfIpGroup
• AWS Workspaces DeleteIpGroup
• AWS Workspaces AuthorizeIpRules (have no idea why it could be useful if UpdateRulesOfIpGroup exists)

[Tensho]

@tombuildsstuff Please, could you provide feedback regarding the latest changes after our yesterday talk?

[gdavison]

Thanks for the PR, @Tensho. This looks like a good start, and I have just a few changes I'd like to see.

This resource is taggable, so it should have a tags attribute.

Please add a reference to the resource documentation in the file https://github.com/terraform-providers/terraform-provider-aws/blob/master/website/aws.erb

[Tensho]

@gdavison Thank you for review 🙇 I've changed everything you noted. Please check it out again.

[Tensho]

@gdavison Please could you help me figure out what's wrong with website rendering? CI reports an issue with the links...

[gdavison]

I've been wondering the same, and I've looked at it a bunch of times. But I finally got it: the documentation file has the extension markdowm instead of markdown

[Tensho]

Nice spot 👍 Fixed!

[gdavison]

Acceptance test results:

$ make testacc TESTARGS='-run=TestAccAwsWorkspacesIpGroup_basic'

--- PASS: TestAccAwsWorkspacesIpGroup_basic (13.47s)

[ghost]

This has been released in version 2.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!