docs/provider: Add Adding Resource Tagging Support section

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A

Includes information how to work with the new internal/keyvaluetags generators.

[ewbankkit]

Any guidance as to when the tag support code changes should be made for new services?

• In the same PR as the new service client changes
• A separate PR after the new service client PR
• With the first new resource that supports resource tags

[bflad]

Hey @ewbankkit, great question. I'm not sure if the maintainers will have too strong of an opinion on this quite yet since working with the library is still very new.

For new services, it seems perfectly fine to include the tag support in the same PR as adding the dependency and service client, if you notice tagging support in the API. Maybe we can add that as a line item to the new service checklist, although it does add some slight complexity there in documenting it (since tagging support in the API may be available from the beginning or much later on, like EKS). Otherwise, I think it might be okay if we accept it separately as well.

If we run into more complicated merging situations in the library, the pull request review for new services feels too heavy with tagging support, or the process doesn't feel right as we go on, we can certainly come up with some more pragmatic guidelines. 😄

[ewbankkit]

@bflad Agree that we should work with this new mechanism for a while before forming string opinions.

[ewbankkit]

Do we want to explicitly call out what to do for resource that don't (yet) support tag-on-create, where you have to effectively call the Update functionality from the Create function?
For aws_api_gateway_v2_api I went with code like:

	if v := d.Get("tags").(map[string]interface{}); len(v) > 0 {
		arn := ...
		if err := keyvaluetags.Apigatewayv2UpdateTags(conn, arn, map[string]interface{}{}, v); err != nil {
			return fmt.Errorf("error creating tags: %s", err)
		}
	}

after having successfully created the resource and set its ID.

[bflad]

Addressed the last comment about tagging on creation vs not in a732852

@ewbankkit FYI you can simplify the UpdateTags call with nil instead of map[string]interface{}{} to increase the readability slightly.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!