New resource: aws_apigatewayv2_api #8842

ewbankkit · 2019-06-03T15:20:56Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7004.

I included the commits from @mbonig - https://github.com/mbonig/terraform-provider-aws/tree/f-gatewayv2, removed the aws_api_gateway_v2_route resource to add in a subsequent PR, added documentation, tidied up the code and got acceptance tests to pass.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_apigatewayv2_api

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Api_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Api_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Api_basic
=== PAUSE TestAccAWSAPIGateway2Api_basic
=== RUN   TestAccAWSAPIGateway2Api_AllAttributes
=== PAUSE TestAccAWSAPIGateway2Api_AllAttributes
=== RUN   TestAccAWSAPIGateway2Api_Tags
=== PAUSE TestAccAWSAPIGateway2Api_Tags
=== CONT  TestAccAWSAPIGateway2Api_basic
=== CONT  TestAccAWSAPIGateway2Api_Tags
=== CONT  TestAccAWSAPIGateway2Api_AllAttributes
--- PASS: TestAccAWSAPIGateway2Api_basic (23.00s)
--- PASS: TestAccAWSAPIGateway2Api_Tags (37.32s)
--- PASS: TestAccAWSAPIGateway2Api_AllAttributes (65.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	65.240s

ewbankkit · 2019-06-06T21:52:57Z

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Api_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Api_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Api_basic
=== PAUSE TestAccAWSAPIGateway2Api_basic
=== RUN   TestAccAWSAPIGateway2Api_update
=== PAUSE TestAccAWSAPIGateway2Api_update
=== CONT  TestAccAWSAPIGateway2Api_basic
=== CONT  TestAccAWSAPIGateway2Api_update
--- PASS: TestAccAWSAPIGateway2Api_basic (23.43s)
--- PASS: TestAccAWSAPIGateway2Api_update (66.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.506s

ewbankkit · 2019-07-01T16:23:25Z

Rebased to add support for resource tags enabled via #9153.

ewbankkit · 2019-07-12T19:46:17Z

Test sweeper:

$ SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_api_gateway_v2_api make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./... -v -sweep=us-west-2 -sweep-run=aws_api_gateway_v2_api
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
2019/07/12 15:43:02 [DEBUG] Running Sweepers for region (us-west-2):
2019/07/12 15:43:02 [INFO] Building AWS auth structure
2019/07/12 15:43:02 [INFO] Setting AWS metadata API timeout to 100ms
2019/07/12 15:43:03 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2019/07/12 15:43:03 [INFO] AWS Auth provider used: "EnvProvider"
2019/07/12 15:43:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2019/07/12 15:43:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2019/07/12 15:43:04 [INFO] Deleting API Gateway v2 API: 0xdnxeagx4
2019/07/12 15:43:06 [INFO] Deleting API Gateway v2 API: 1euwhap7li
2019/07/12 15:43:06 [INFO] Deleting API Gateway v2 API: 46tnfzqtjg
2019/07/12 15:43:07 [INFO] Deleting API Gateway v2 API: 5qrmhx3ls8
2019/07/12 15:43:08 [INFO] Deleting API Gateway v2 API: 6um3maylxc
2019/07/12 15:43:09 [INFO] Deleting API Gateway v2 API: 7lrwzvg1l5
2019/07/12 15:43:10 [INFO] Deleting API Gateway v2 API: a944fj0y4c
2019/07/12 15:43:11 [INFO] Deleting API Gateway v2 API: dz58flf4f4
2019/07/12 15:43:12 Sweeper Tests ran:
	- aws_api_gateway_v2_api
ok  	github.com/terraform-providers/terraform-provider-aws/aws	9.739s

ewbankkit · 2019-07-26T19:22:38Z

Rebased to fix merge conflict.

ewbankkit · 2019-08-11T20:24:48Z

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Api_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Api_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Api_basic
=== PAUSE TestAccAWSAPIGateway2Api_basic
=== RUN   TestAccAWSAPIGateway2Api_AllAttributes
=== PAUSE TestAccAWSAPIGateway2Api_AllAttributes
=== RUN   TestAccAWSAPIGateway2Api_Tags
=== PAUSE TestAccAWSAPIGateway2Api_Tags
=== CONT  TestAccAWSAPIGateway2Api_basic
=== CONT  TestAccAWSAPIGateway2Api_Tags
=== CONT  TestAccAWSAPIGateway2Api_AllAttributes
--- PASS: TestAccAWSAPIGateway2Api_basic (19.53s)
--- PASS: TestAccAWSAPIGateway2Api_Tags (30.86s)
--- PASS: TestAccAWSAPIGateway2Api_AllAttributes (52.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.611s

ewbankkit · 2019-10-05T22:09:44Z

Rebased and did the Terraform Plugin SDK migration for the new resources.
Use internal/keyvaluetags for tagging - #10018.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Api_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGateway2Api_ -timeout 120m
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
=== RUN   TestAccAWSAPIGateway2Api_basic
=== PAUSE TestAccAWSAPIGateway2Api_basic
=== RUN   TestAccAWSAPIGateway2Api_AllAttributes
=== PAUSE TestAccAWSAPIGateway2Api_AllAttributes
=== RUN   TestAccAWSAPIGateway2Api_Tags
=== PAUSE TestAccAWSAPIGateway2Api_Tags
=== CONT  TestAccAWSAPIGateway2Api_basic
=== CONT  TestAccAWSAPIGateway2Api_Tags
=== CONT  TestAccAWSAPIGateway2Api_AllAttributes
--- PASS: TestAccAWSAPIGateway2Api_basic (30.13s)
--- PASS: TestAccAWSAPIGateway2Api_Tags (30.68s)
--- PASS: TestAccAWSAPIGateway2Api_AllAttributes (51.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	51.230s

…atchResourceAttrRegionalARNNoAccount'.

ewbankkit · 2020-03-09T20:59:21Z

Rebased to remove merge conflicts.

ewbankkit · 2020-03-09T21:20:27Z

Cleaned up function names similar to #12299 (@kreempuff was correct).
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Api_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Api_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Api_basic
=== PAUSE TestAccAWSAPIGatewayV2Api_basic
=== RUN   TestAccAWSAPIGatewayV2Api_disappears
=== PAUSE TestAccAWSAPIGatewayV2Api_disappears
=== RUN   TestAccAWSAPIGatewayV2Api_AllAttributes
=== PAUSE TestAccAWSAPIGatewayV2Api_AllAttributes
=== RUN   TestAccAWSAPIGatewayV2Api_Tags
=== PAUSE TestAccAWSAPIGatewayV2Api_Tags
=== CONT  TestAccAWSAPIGatewayV2Api_basic
=== CONT  TestAccAWSAPIGatewayV2Api_Tags
=== CONT  TestAccAWSAPIGatewayV2Api_AllAttributes
=== CONT  TestAccAWSAPIGatewayV2Api_disappears
--- PASS: TestAccAWSAPIGatewayV2Api_disappears (18.93s)
--- PASS: TestAccAWSAPIGatewayV2Api_basic (25.30s)
--- PASS: TestAccAWSAPIGatewayV2Api_Tags (41.03s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributes (84.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	84.865s

gdavison

Thanks for this and the other API Gateway v2 resources, @ewbankkit! I've added a few changes to make before we merge this.

gdavison · 2020-03-09T20:16:20Z

aws/resource_aws_api_gateway2_api.go

+	"github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags"
+)
+
+func resourceAwsApiGateway2Api() *schema.Resource {


The HSM naming was incorrect 😄 We'd like to use the V2 naming suggested here. Also for the CRUD functions.

aws/resource_aws_api_gateway2_api.go

aws/resource_aws_api_gateway2_api_test.go

website/allowed-subcategories.txt

website/docs/r/api_gateway_rest_api.html.markdown

aws/resource_aws_api_gateway2_api_test.go

gdavison · 2020-03-10T19:04:47Z

aws/provider.go

@@ -354,6 +354,7 @@ func Provider() terraform.ResourceProvider {
 			"aws_api_gateway_usage_plan":                              resourceAwsApiGatewayUsagePlan(),
 			"aws_api_gateway_usage_plan_key":                          resourceAwsApiGatewayUsagePlanKey(),
 			"aws_api_gateway_vpc_link":                                resourceAwsApiGatewayVpcLink(),
+			"aws_api_gateway_v2_api":                                  resourceAwsApiGatewayV2Api(),


Based on our naming standards at https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#new-service, the service name should beapigatewayv2, and therefore the resource should be aws_apigatewayv2_api.

Sure. For completeness I'll rename the files to resource_aws_api_gatewayv2_api.go, resource_aws_api_gatewayv2_api_test.go and api_gatewayv2_api.html.markdown.

One more tweak, please: can you change it to aws_apigatewayv2_api, without the underscore in apigateway? We know it's not consistent with v1, but we're trying to standardize on our service naming.
Other than that, we're good to go!

Too close to the issue to see the additional _ 😄.
I have renamed the resource to aws_apigatewayv2_api.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Api_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Api_ -timeout 120m === RUN TestAccAWSAPIGatewayV2Api_basicWebSocket === PAUSE TestAccAWSAPIGatewayV2Api_basicWebSocket === RUN TestAccAWSAPIGatewayV2Api_basicHttp === PAUSE TestAccAWSAPIGatewayV2Api_basicHttp === RUN TestAccAWSAPIGatewayV2Api_disappears === PAUSE TestAccAWSAPIGatewayV2Api_disappears === RUN TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === RUN TestAccAWSAPIGatewayV2Api_AllAttributesHttp === PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesHttp === RUN TestAccAWSAPIGatewayV2Api_Tags === PAUSE TestAccAWSAPIGatewayV2Api_Tags === CONT TestAccAWSAPIGatewayV2Api_basicWebSocket === CONT TestAccAWSAPIGatewayV2Api_AllAttributesHttp === CONT TestAccAWSAPIGatewayV2Api_Tags === CONT TestAccAWSAPIGatewayV2Api_disappears === CONT TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === CONT TestAccAWSAPIGatewayV2Api_basicHttp --- PASS: TestAccAWSAPIGatewayV2Api_disappears (21.75s) --- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (26.20s) --- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (38.05s) --- PASS: TestAccAWSAPIGatewayV2Api_Tags (44.29s) --- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (74.49s) --- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (75.41s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 75.468s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Api_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Api_ -timeout 120m === RUN TestAccAWSAPIGatewayV2Api_basic === PAUSE TestAccAWSAPIGatewayV2Api_basic === RUN TestAccAWSAPIGatewayV2Api_disappears === PAUSE TestAccAWSAPIGatewayV2Api_disappears === RUN TestAccAWSAPIGatewayV2Api_AllAttributes === PAUSE TestAccAWSAPIGatewayV2Api_AllAttributes === RUN TestAccAWSAPIGatewayV2Api_Tags === PAUSE TestAccAWSAPIGatewayV2Api_Tags === CONT TestAccAWSAPIGatewayV2Api_basic === CONT TestAccAWSAPIGatewayV2Api_Tags === CONT TestAccAWSAPIGatewayV2Api_AllAttributes === CONT TestAccAWSAPIGatewayV2Api_disappears --- PASS: TestAccAWSAPIGatewayV2Api_disappears (19.00s) --- PASS: TestAccAWSAPIGatewayV2Api_basic (25.16s) --- PASS: TestAccAWSAPIGatewayV2Api_Tags (39.97s) --- PASS: TestAccAWSAPIGatewayV2Api_AllAttributes (72.42s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 72.472s

…re all errors. Acceptance test output: $ SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_api_gatewayv2_api make sweep WARNING: This will destroy infrastructure. Use only in development accounts. go test ./aws -v -sweep=us-west-2 -sweep-run=aws_api_gatewayv2_api -timeout 60m 2020/03/10 17:48:09 [DEBUG] Running Sweepers for region (us-west-2): 2020/03/10 17:48:09 [DEBUG] Running Sweeper (aws_api_gatewayv2_api) in region (us-west-2) 2020/03/10 17:48:09 [INFO] Building AWS auth structure 2020/03/10 17:48:09 [INFO] Setting AWS metadata API timeout to 100ms 2020/03/10 17:48:10 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id 2020/03/10 17:48:10 [INFO] AWS Auth provider used: "EnvProvider" 2020/03/10 17:48:10 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2020/03/10 17:48:10 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2020/03/10 17:48:12 Sweeper Tests ran successfully: - aws_api_gatewayv2_api ok github.com/terraform-providers/terraform-provider-aws/aws 2.687s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Api_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Api_ -timeout 120m === RUN TestAccAWSAPIGatewayV2Api_basicWebSocket === PAUSE TestAccAWSAPIGatewayV2Api_basicWebSocket === RUN TestAccAWSAPIGatewayV2Api_basicHttp === PAUSE TestAccAWSAPIGatewayV2Api_basicHttp === RUN TestAccAWSAPIGatewayV2Api_disappears === PAUSE TestAccAWSAPIGatewayV2Api_disappears === RUN TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === RUN TestAccAWSAPIGatewayV2Api_AllAttributesHttp === PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesHttp === RUN TestAccAWSAPIGatewayV2Api_Tags === PAUSE TestAccAWSAPIGatewayV2Api_Tags === CONT TestAccAWSAPIGatewayV2Api_basicWebSocket === CONT TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === CONT TestAccAWSAPIGatewayV2Api_Tags === CONT TestAccAWSAPIGatewayV2Api_AllAttributesHttp === CONT TestAccAWSAPIGatewayV2Api_disappears === CONT TestAccAWSAPIGatewayV2Api_basicHttp --- PASS: TestAccAWSAPIGatewayV2Api_disappears (19.24s) --- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (24.78s) --- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (25.00s) --- PASS: TestAccAWSAPIGatewayV2Api_Tags (42.31s) --- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (70.75s) --- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (70.95s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 71.014s

ewbankkit · 2020-03-11T00:33:41Z

@gdavison I made all the suggested changes.
For HTTP API support, I enable protocol_type = "HTTP" (and added some additional acceptance tests) but did not add any of the new attributes that are applicable only to HTTP APIs. They can be added as part of implementing #11148.
I will make equivalent changes to the subsequent new API Gateway v2 resources.

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Api_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Api_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Api_basicWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Api_basicWebSocket
=== RUN   TestAccAWSAPIGatewayV2Api_basicHttp
=== PAUSE TestAccAWSAPIGatewayV2Api_basicHttp
=== RUN   TestAccAWSAPIGatewayV2Api_disappears
=== PAUSE TestAccAWSAPIGatewayV2Api_disappears
=== RUN   TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket
=== RUN   TestAccAWSAPIGatewayV2Api_AllAttributesHttp
=== PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesHttp
=== RUN   TestAccAWSAPIGatewayV2Api_Tags
=== PAUSE TestAccAWSAPIGatewayV2Api_Tags
=== CONT  TestAccAWSAPIGatewayV2Api_basicWebSocket
=== CONT  TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket
=== CONT  TestAccAWSAPIGatewayV2Api_Tags
=== CONT  TestAccAWSAPIGatewayV2Api_AllAttributesHttp
=== CONT  TestAccAWSAPIGatewayV2Api_disappears
=== CONT  TestAccAWSAPIGatewayV2Api_basicHttp
--- PASS: TestAccAWSAPIGatewayV2Api_disappears (19.24s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (24.78s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (25.00s)
--- PASS: TestAccAWSAPIGatewayV2Api_Tags (42.31s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (70.75s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (70.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	71.014s

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Api_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Api_ -timeout 120m === RUN TestAccAWSAPIGatewayV2Api_basicWebSocket === PAUSE TestAccAWSAPIGatewayV2Api_basicWebSocket === RUN TestAccAWSAPIGatewayV2Api_basicHttp === PAUSE TestAccAWSAPIGatewayV2Api_basicHttp === RUN TestAccAWSAPIGatewayV2Api_disappears === PAUSE TestAccAWSAPIGatewayV2Api_disappears === RUN TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === RUN TestAccAWSAPIGatewayV2Api_AllAttributesHttp === PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesHttp === RUN TestAccAWSAPIGatewayV2Api_Tags === PAUSE TestAccAWSAPIGatewayV2Api_Tags === CONT TestAccAWSAPIGatewayV2Api_basicWebSocket === CONT TestAccAWSAPIGatewayV2Api_AllAttributesHttp === CONT TestAccAWSAPIGatewayV2Api_Tags === CONT TestAccAWSAPIGatewayV2Api_disappears === CONT TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket === CONT TestAccAWSAPIGatewayV2Api_basicHttp --- PASS: TestAccAWSAPIGatewayV2Api_disappears (21.75s) --- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (26.20s) --- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (38.05s) --- PASS: TestAccAWSAPIGatewayV2Api_Tags (44.29s) --- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (74.49s) --- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (75.41s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 75.468s

gdavison

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2Api_disappears (7.48s)
--- PASS: TestAccAWSAPIGatewayV2Api_Tags (15.21s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (20.47s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (21.63s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (25.13s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (26.07s)

ghost · 2020-03-12T21:33:31Z

This has been released in version 2.53.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-04-12T17:10:38Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

This was referenced Jun 3, 2019

API Gateway- Websocket #7004

Closed

New resource: aws_apigatewayv2_route #8881

Merged

This was referenced Jun 7, 2019

New resource: aws_apigatewayv2_model #8912

Merged

New resource: aws_apigatewayv2_integration #8949

Merged

aeschright requested a review from a team June 28, 2019 18:14

ewbankkit force-pushed the issue-7004 branch from 8249f49 to c011fd2 Compare July 1, 2019 16:21

ghost added the service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. label Jul 1, 2019

ewbankkit mentioned this pull request Jul 3, 2019

New resource: aws_apigatewayv2_authorizer #9228

Merged

ewbankkit force-pushed the issue-7004 branch from c011fd2 to 6473d62 Compare July 3, 2019 18:08

This was referenced Jul 3, 2019

New resource: aws_apigatewayv2_stage #9232

Merged

New resource: aws_apigatewayv2_deployment #9245

Merged

ewbankkit force-pushed the issue-7004 branch from 300f640 to 10ce741 Compare July 5, 2019 14:49

This was referenced Jul 16, 2019

New resource: aws_apigatewayv2_integration_response #9365

Merged

New resource: aws_apigatewayv2_route_response #9373

Merged

New resource: aws_apigatewayv2_domain_name #9391

Merged

New resource: aws_apigatewayv2_api_mapping #9461

Merged

ewbankkit force-pushed the issue-7004 branch from 9762dc9 to ddf79fe Compare July 26, 2019 19:22

aeschright added the new-resource Introduces a new resource. label Aug 19, 2019

ewbankkit force-pushed the issue-7004 branch from f28c33d to abf7963 Compare October 5, 2019 22:05

Kit Ewbank and others added 6 commits March 9, 2020 16:43

Replace 'testAccMatchResourceAttrAnonymousRegionalARN' with 'testAccM…

c1adaa3

…atchResourceAttrRegionalARNNoAccount'.

Add 'subcategory'.

e3bf1e1

r/aws_api_gateway2_api: Tag-on-create.

e00849f

Fix go.mod/go.sum conflicts.

d8c461d

Fix website documentation errors.

69ee27e

Add TestAccAWSAPIGateway2Api_disappears acceptance test.

d4054d4

ewbankkit force-pushed the issue-7004 branch from 4621afb to d4054d4 Compare March 9, 2020 20:59

Clean up function names - hashicorp#12299.

fd5581c

Correct test check function name.

52f6b9a

gdavison requested changes Mar 10, 2020

View reviewed changes

ewbankkit added 3 commits March 10, 2020 17:40

ewbankkit changed the title ~~New resource: aws_api_gateway_v2_api~~ New resource: aws_api_gatewayv2_api Mar 11, 2020

Correct the dropdown section title.

38f5b02

ewbankkit changed the title ~~New resource: aws_api_gatewayv2_api~~ New resource: aws_apigatewayv2_api Mar 12, 2020

ewbankkit force-pushed the issue-7004 branch from 39d29ee to 46a3572 Compare March 12, 2020 12:08

gdavison approved these changes Mar 12, 2020

View reviewed changes

gdavison merged commit 78bd608 into hashicorp:master Mar 12, 2020

gdavison added a commit that referenced this pull request Mar 12, 2020

Update CHANGELOG for #8842

173189e

bflad added this to the v2.53.0 milestone Mar 12, 2020

ewbankkit deleted the issue-7004 branch March 12, 2020 21:36

ewbankkit mentioned this pull request Mar 18, 2020

r/aws_apigatewayv2_api: Add CORS configuration and quick start attributes #12452

Merged

ghost locked and limited conversation to collaborators Apr 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_apigatewayv2_api #8842

New resource: aws_apigatewayv2_api #8842

ewbankkit commented Jun 3, 2019 •

edited

Loading

ewbankkit commented Jun 6, 2019

ewbankkit commented Jul 1, 2019 •

edited

Loading

ewbankkit commented Jul 12, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Aug 11, 2019

ewbankkit commented Oct 5, 2019

ewbankkit commented Mar 9, 2020

ewbankkit commented Mar 9, 2020

gdavison left a comment

gdavison Mar 9, 2020

gdavison Mar 10, 2020

ewbankkit Mar 10, 2020

ewbankkit Mar 11, 2020

gdavison Mar 11, 2020 •

edited

Loading

ewbankkit Mar 12, 2020

ewbankkit commented Mar 11, 2020 •

edited

Loading

gdavison left a comment

ghost commented Mar 12, 2020

ghost commented Apr 12, 2020

New resource: aws_apigatewayv2_api #8842

New resource: aws_apigatewayv2_api #8842

Conversation

ewbankkit commented Jun 3, 2019 • edited Loading

Community Note

ewbankkit commented Jun 6, 2019

ewbankkit commented Jul 1, 2019 • edited Loading

ewbankkit commented Jul 12, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Aug 11, 2019

ewbankkit commented Oct 5, 2019

ewbankkit commented Mar 9, 2020

ewbankkit commented Mar 9, 2020

gdavison left a comment

Choose a reason for hiding this comment

gdavison Mar 9, 2020

Choose a reason for hiding this comment

gdavison Mar 10, 2020

Choose a reason for hiding this comment

ewbankkit Mar 10, 2020

Choose a reason for hiding this comment

ewbankkit Mar 11, 2020

Choose a reason for hiding this comment

gdavison Mar 11, 2020 • edited Loading

Choose a reason for hiding this comment

ewbankkit Mar 12, 2020

Choose a reason for hiding this comment

ewbankkit commented Mar 11, 2020 • edited Loading

gdavison left a comment

Choose a reason for hiding this comment

ghost commented Mar 12, 2020

ghost commented Apr 12, 2020

ewbankkit commented Jun 3, 2019 •

edited

Loading

ewbankkit commented Jul 1, 2019 •

edited

Loading

gdavison Mar 11, 2020 •

edited

Loading

ewbankkit commented Mar 11, 2020 •

edited

Loading