Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_apigatewayv2_api: Add CORS configuration and quick start attributes #12452

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 18, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11148.

Add CORS configuration and quick start attributes.

Follows on from #8842.

Release note for CHANGELOG:

resource/aws_apigatewayv2_api: Add `cors_configuration`, `credentials_arn`, `route_key` and `target` attributes

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Api_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Api_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Api_basicWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Api_basicWebSocket
=== RUN   TestAccAWSAPIGatewayV2Api_basicHttp
=== PAUSE TestAccAWSAPIGatewayV2Api_basicHttp
=== RUN   TestAccAWSAPIGatewayV2Api_disappears
=== PAUSE TestAccAWSAPIGatewayV2Api_disappears
=== RUN   TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket
=== RUN   TestAccAWSAPIGatewayV2Api_AllAttributesHttp
=== PAUSE TestAccAWSAPIGatewayV2Api_AllAttributesHttp
=== RUN   TestAccAWSAPIGatewayV2Api_Tags
=== PAUSE TestAccAWSAPIGatewayV2Api_Tags
=== RUN   TestAccAWSAPIGatewayV2Api_CorsConfiguration
=== PAUSE TestAccAWSAPIGatewayV2Api_CorsConfiguration
=== RUN   TestAccAWSAPIGatewayV2Api_QuickCreate
=== PAUSE TestAccAWSAPIGatewayV2Api_QuickCreate
=== CONT  TestAccAWSAPIGatewayV2Api_basicWebSocket
=== CONT  TestAccAWSAPIGatewayV2Api_Tags
=== CONT  TestAccAWSAPIGatewayV2Api_QuickCreate
=== CONT  TestAccAWSAPIGatewayV2Api_CorsConfiguration
=== CONT  TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket
=== CONT  TestAccAWSAPIGatewayV2Api_AllAttributesHttp
=== CONT  TestAccAWSAPIGatewayV2Api_disappears
=== CONT  TestAccAWSAPIGatewayV2Api_basicHttp
--- PASS: TestAccAWSAPIGatewayV2Api_disappears (19.42s)
--- PASS: TestAccAWSAPIGatewayV2Api_QuickCreate (29.86s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (37.34s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (37.90s)
--- PASS: TestAccAWSAPIGatewayV2Api_Tags (41.38s)
--- PASS: TestAccAWSAPIGatewayV2Api_CorsConfiguration (57.11s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (71.49s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (82.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	83.027s

@ewbankkit ewbankkit requested a review from a team March 18, 2020 22:42
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 18, 2020
@ewbankkit ewbankkit force-pushed the issue-11148.aws_apigatewayv2_api-additions branch from 014172f to 2c724d9 Compare March 19, 2020 16:41
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 19, 2020
@ewbankkit ewbankkit changed the title [WIP] r/aws_apigatewayv2_api: Add CORS configuration and quick start attributes r/aws_apigatewayv2_api: Add CORS configuration and quick start attributes Mar 19, 2020
@ewbankkit
Copy link
Contributor Author

Removed WIP.
Ready for review.

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2Api_disappears (8.48s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (10.35s)
--- PASS: TestAccAWSAPIGatewayV2Api_QuickCreate (11.56s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (12.10s)
--- PASS: TestAccAWSAPIGatewayV2Api_CorsConfiguration (22.77s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (27.43s)
--- PASS: TestAccAWSAPIGatewayV2Api_Tags (29.07s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (40.17s)

@gdavison gdavison added this to the v2.59.0 milestone Apr 17, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2020
@gdavison gdavison merged commit df71a4f into hashicorp:master Apr 17, 2020
gdavison added a commit that referenced this pull request Apr 17, 2020
@ewbankkit ewbankkit deleted the issue-11148.aws_apigatewayv2_api-additions branch April 18, 2020 11:44
@ghost
Copy link

ghost commented Apr 24, 2020

This has been released in version 2.59.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants