New resource: aws_apigatewayv2_vpc_link

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11148.

Adds a new resource, aws_apigatewayv2_vpc_link.

Release note for CHANGELOG:

resource/aws_apigatewayv2_vpc_link: New resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayV2VpcLink_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2VpcLink_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2VpcLink_basic
=== PAUSE TestAccAWSAPIGatewayV2VpcLink_basic
=== RUN   TestAccAWSAPIGatewayV2VpcLink_disappears
=== PAUSE TestAccAWSAPIGatewayV2VpcLink_disappears
=== RUN   TestAccAWSAPIGatewayV2VpcLink_Tags
=== PAUSE TestAccAWSAPIGatewayV2VpcLink_Tags
=== CONT  TestAccAWSAPIGatewayV2VpcLink_basic
=== CONT  TestAccAWSAPIGatewayV2VpcLink_Tags
=== CONT  TestAccAWSAPIGatewayV2VpcLink_disappears
--- PASS: TestAccAWSAPIGatewayV2VpcLink_disappears (170.21s)
--- PASS: TestAccAWSAPIGatewayV2VpcLink_basic (223.88s)
--- PASS: TestAccAWSAPIGatewayV2VpcLink_Tags (227.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	227.051s

$ TEST=./aws SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_apigatewayv2_vpc_link make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2 -sweep-run=aws_apigatewayv2_vpc_link -timeout 60m
2020/03/30 08:03:19 [DEBUG] Running Sweepers for region (us-west-2):
2020/03/30 08:03:19 [DEBUG] Running Sweeper (aws_apigatewayv2_vpc_link) in region (us-west-2)
2020/03/30 08:03:19 [INFO] Building AWS auth structure
2020/03/30 08:03:19 [INFO] Setting AWS metadata API timeout to 100ms
2020/03/30 08:03:21 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2020/03/30 08:03:21 [INFO] AWS Auth provider used: "EnvProvider"
2020/03/30 08:03:21 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/03/30 08:03:21 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/03/30 08:03:22 [INFO] Deleting API Gateway v2 VPC Link: wv9xr6
2020/03/30 08:03:22 [DEBUG] Waiting for API Gateway v2 VPC Link (wv9xr6) deletion
2020/03/30 08:03:22 [DEBUG] Waiting for state to become: [DELETED]
2020/03/30 08:03:23 [TRACE] Waiting 200ms before next try
2020/03/30 08:03:23 [TRACE] Waiting 400ms before next try
2020/03/30 08:03:24 [TRACE] Waiting 800ms before next try
2020/03/30 08:03:26 Sweeper Tests ran successfully:
	- aws_apigatewayv2_vpc_link
ok  	github.com/terraform-providers/terraform-provider-aws/aws	6.624s

[ewbankkit]

Rebased to remove merge conflicts.
Moved waiter logic into per-service package.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayV2VpcLink_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2VpcLink_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2VpcLink_basic
=== PAUSE TestAccAWSAPIGatewayV2VpcLink_basic
=== RUN   TestAccAWSAPIGatewayV2VpcLink_disappears
=== PAUSE TestAccAWSAPIGatewayV2VpcLink_disappears
=== RUN   TestAccAWSAPIGatewayV2VpcLink_Tags
=== PAUSE TestAccAWSAPIGatewayV2VpcLink_Tags
=== CONT  TestAccAWSAPIGatewayV2VpcLink_basic
=== CONT  TestAccAWSAPIGatewayV2VpcLink_Tags
=== CONT  TestAccAWSAPIGatewayV2VpcLink_disappears
--- PASS: TestAccAWSAPIGatewayV2VpcLink_disappears (184.30s)
--- PASS: TestAccAWSAPIGatewayV2VpcLink_basic (199.42s)
--- PASS: TestAccAWSAPIGatewayV2VpcLink_Tags (237.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	237.506s

Closes #12880.

[gdavison]

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2VpcLink_disappears (125.77s)
--- PASS: TestAccAWSAPIGatewayV2VpcLink_Tags (154.68s)
--- PASS: TestAccAWSAPIGatewayV2VpcLink_basic (208.83s)

[AleksandarTokarev]

When is this going to be released as part of the terraform providers?
Also, i see that the domain name is there but not the ApiMapping resource. Any plans for that?
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigatewayv2-apimapping.html
@ewbankkit

[bflad]

Hi @AleksandarTokarev 👋 This was added to the next release, which is the v2.59.0 milestone. We typically release weekly if you take a peek at the CHANGELOG. This pull request and any issues within the associated release milestone will receive a comment when the release is done.

[ghost]

This has been released in version 2.59.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!