Add data source aws_organizations_accounts

[ebi-yade]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16153

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[github-actions]

Welcome @ebi-yade 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ebi-yade]

Because this is the first time filing a Pull Request to this repo, I may have something wrong or miss any essential steps, although I read the guideline and will take care.

I would like any maintainers to review this when I turn this "ready for review" after adding and modifying some code. I am sorry my less experiences contributing OSS may be a burden. 🙁💭

[elijah-roberts]

@ebi-yade is this still a work in progress? Or what do you need to complete? I am looking to use this functionality and can pick this up if you are no longer moving forward with this.

[ebi-yade]

Hello, @elijah-roberts !

I am sorry I've wholly forgotten this pull request cause I'd temporarily resolved the problem by some manual operations. And I'm now a little bit busy, so I'd like you to pick this up if possible.

[ebi-yade]

Hi again,

I've just remembered now that this is marked as WIP because some non-programming tasks such as writing changelog or running acceptance tests are not done, so I believe I can finish them if you could wait for the weekend!

[ebi-yade]

Hello,

Thanks to @mikeroll, this PR is now finalized!
I cannot show the log of the acceptance test, but @mikeroll has already: ebi-yade#1 (comment)

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[colinrymer]

Doh - sorry for the meaningless approval - wasn't paying attention to the tab I had focused and approved the wrong PR... 😳

[ChaosCypher]

👍

[github-actions]

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.