Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds aws_organizations_accounts datasource #20370

Closed
wants to merge 2 commits into from
Closed

Adds aws_organizations_accounts datasource #20370

wants to merge 2 commits into from

Conversation

agseijas
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14153

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSOrganizations_serial'
...
=== RUN   testAccDataSourceAwsOrganizationsAccounts_basic
--- PASS: testAccDataSourceAwsOrganizationsAccounts_basic (33.92s)
...
PASS

This PR is similar to this one but is a bit more complete and also has tags. We can convert it to single noun _account too, WDYT?

Also the acctest depends on the presence of an organization that has at least 1 account in the profile that runs it, but we can do as with other sibling tests and skip it.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/organizations Issues and PRs that pertain to the organizations service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 29, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @agseijas 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@agseijas agseijas changed the title [WIP ]Adds aws_organizations_accounts datasource Adds aws_organizations_accounts datasource Jul 30, 2021
@agseijas agseijas closed this Jul 30, 2021
@agseijas agseijas deleted the adds_aws_organizations_accounts branch July 30, 2021 14:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 4, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/organizations Issues and PRs that pertain to the organizations service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve AWS Organization Account Tags
2 participants