Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go.mod to 1.20 #32108

Merged
merged 4 commits into from
Jun 22, 2023
Merged

bump go.mod to 1.20 #32108

merged 4 commits into from
Jun 22, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jun 20, 2023

Description

Updates go.mod to Go 1.20. Also replaces package-scoped calls to rand.Seed() with randomized values, as Go 1.20 now seeds the global number generator in math/rand with a randomized value by default. From the 1.20 release notes:

The math/rand package now automatically seeds the global random number generator (used by top-level functions like Float64 and Int) with a random value, and the top-level Seed function has been deprecated. Programs that need a reproducible sequence of random numbers should prefer to allocate their own random source, using rand.New(rand.NewSource(seed)).

Relations

Relates #32082 (see failed checks).
Closes #30876.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jun 20, 2023
@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. skaff Issues and pull requested related to the skaff tool and removed linter Pertains to changes to or issues with the various linters. skaff Issues and pull requested related to the skaff tool labels Jun 20, 2023
@ewbankkit
Copy link
Contributor

We may need to call out the potentially now unsupported platforms (see https://tip.golang.org/doc/go1.20#ports) in the release notes. Or maybe not. I can't remember how where our internal discussions landed on this.

@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. skaff Issues and pull requested related to the skaff tool service/elb Issues and PRs that pertain to the elb service. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Jun 20, 2023
@ewbankkit
Copy link
Contributor

In theory we can replace uses of github.com/hashicorp/go-multierror with errors.Join: https://tip.golang.org/doc/go1.20#errors. Maybe open an Issue for this?

In Go 1.20, the math/rand package now automatically seeds the global
random number generator with a random value. This makes package level
calls to rand.Seed() with a non-deterministic value unnecessary.
Additonal details can be found in the Go 1.20 release notes, under the
math/rand section:

- https://tip.golang.org/doc/go1.20
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 21, 2023
@hashicorp hashicorp deleted a comment from github-actions bot Jun 21, 2023
@ewbankkit
Copy link
Contributor

Do we want to call out the DNS changes -- https://tip.golang.org/doc/go1.20#minor_library_changes -- as they are explicitly mentioned in #30876.
See e.g. UPGRADE NOTES in https://github.com/hashicorp/terraform/blob/v1.5/CHANGELOG.md#150-june-12-2023.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 34a7edd into main Jun 22, 2023
@jar-b jar-b deleted the td-gomod-120 branch June 22, 2023 17:27
@github-actions github-actions bot added this to the v5.5.0 milestone Jun 22, 2023
github-actions bot pushed a commit that referenced this pull request Jun 22, 2023
@github-actions
Copy link

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/elb Issues and PRs that pertain to the elb service. service/route53 Issues and PRs that pertain to the route53 service. size/S Managed by automation to categorize the size of a PR. skaff Issues and pull requested related to the skaff tool tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Update to Golang 1.20
2 participants