Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go.mod to 1.20 #32108

Merged
merged 4 commits into from
Jun 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changelog/32108.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
```release-note:note
provider: Updates to Go 1.20, the last release that will run on macOS 10.13 High Sierra or 10.14 Mojave. A future release will update to Go 1.21, and these platforms will no longer be supported.
```

```release-note:note
provider: Updates to Go 1.20, the last release that will run on any release of Windows 7, 8, Server 2008 and Server 2012. A future release will update to Go 1.21, and these platforms will no longer be supported.
```

```release-note:note
provider: Updates to Go 1.20. The provider will now notice the `trust-ad` option in `/etc/resolv.conf` and, if set, will set the "authentic data" option in outgoing DNS requests in order to better match the behavior of the GNU libc resolver.
```
2 changes: 1 addition & 1 deletion .ci/providerlint/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/hashicorp/terraform-provider-aws/ci/providerlint

go 1.19
go 1.20

require (
github.com/aws/aws-sdk-go v1.44.286
Expand Down
2 changes: 1 addition & 1 deletion .ci/tools/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/hashicorp/terraform-provider-aws/tools

go 1.19
go 1.20

require (
github.com/bflad/tfproviderdocs v0.11.0
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,8 @@ jobs:
with:
version: "${{ steps.golangci-lint-version.outputs.version }}"
args: --config .ci/.golangci2.yml
env:
# Trigger garbage collection more frequently to reduce the likelihood
# of OOM errors.
# ref: https://golangci-lint.run/usage/performance/#memory-usage
GOGC: "50"
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/hashicorp/terraform-provider-aws

go 1.19
go 1.20

require (
github.com/ProtonMail/go-crypto v0.0.0-20230217124315-7d5c6f04bbb8
Expand Down
3 changes: 0 additions & 3 deletions internal/service/elb/load_balancer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import ( // nosemgrep:ci.semgrep.aws.multiple-service-imports
"reflect"
"regexp"
"testing"
"time"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/elb"
Expand Down Expand Up @@ -149,8 +148,6 @@ func TestValidLoadBalancerHealthCheckTarget(t *testing.T) {
}

randomRunes := func(n int) string {
rand.Seed(time.Now().UTC().UnixNano())

// A complete set of modern Katakana characters.
runes := []rune("アイウエオ" +
"カキクケコガギグゲゴサシスセソザジズゼゾ" +
Expand Down
2 changes: 0 additions & 2 deletions internal/service/route53/record.go
Original file line number Diff line number Diff line change
Expand Up @@ -758,8 +758,6 @@ func ChangeResourceRecordSets(ctx context.Context, conn *route53.Route53, input
}

func WaitForRecordSetToSync(ctx context.Context, conn *route53.Route53, requestId string) error {
rand.Seed(time.Now().UTC().UnixNano())

wait := retry.StateChangeConf{
Pending: []string{route53.ChangeStatusPending},
Target: []string{route53.ChangeStatusInsync},
Expand Down
2 changes: 0 additions & 2 deletions internal/service/route53/wait.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ const (
)

func waitChangeInfoStatusInsync(ctx context.Context, conn *route53.Route53, changeID string) (*route53.ChangeInfo, error) { //nolint:unparam
rand.Seed(time.Now().UTC().UnixNano())

// Route53 is vulnerable to throttling so longer delays, poll intervals helps significantly to avoid

stateConf := &retry.StateChangeConf{
Expand Down
2 changes: 0 additions & 2 deletions internal/service/route53/zone.go
Original file line number Diff line number Diff line change
Expand Up @@ -680,8 +680,6 @@ func hostedZoneVPCHash(v interface{}) int {
}

func waitForChangeSynchronization(ctx context.Context, conn *route53.Route53, changeID string) error {
rand.Seed(time.Now().UTC().UnixNano())

conf := retry.StateChangeConf{
Pending: []string{route53.ChangeStatusPending},
Target: []string{route53.ChangeStatusInsync},
Expand Down
2 changes: 1 addition & 1 deletion skaff/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/hashicorp/terraform-provider-aws/skaff

go 1.19
go 1.20

require (
github.com/hashicorp/terraform-provider-aws v1.60.1-0.20220322001452-8f7a597d0c24
Expand Down
2 changes: 1 addition & 1 deletion tools/tfsdk2fw/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/hashicorp/terraform-provider-aws/tools/tfsdk2fw

go 1.19
go 1.20

require (
github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1
Expand Down