f-aws_ecs_service: support for EBS

[nikhil-goenka]

Description

Relations

Closes #35279

References

Output from Acceptance Testing

% make testacc TESTS=TestAccECSTaskDefinition_configuredAtLaunch PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_configuredAtLaunch'  -timeout 360m
=== RUN   TestAccECSTaskDefinition_configuredAtLaunch
=== PAUSE TestAccECSTaskDefinition_configuredAtLaunch
=== CONT  TestAccECSTaskDefinition_configuredAtLaunch
--- PASS: TestAccECSTaskDefinition_configuredAtLaunch (54.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	126.627s
% make testacc TESTS=TestAccECSTaskDefinition_ PKG=ecs                    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_'  -timeout 360m
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_configuredAtLaunch
=== PAUSE TestAccECSTaskDefinition_configuredAtLaunch
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
=== PAUSE TestAccECSTaskDefinition_fsxWinFileSystem
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== RUN   TestAccECSTaskDefinition_invalidContainerDefinition
=== PAUSE TestAccECSTaskDefinition_invalidContainerDefinition
=== RUN   TestAccECSTaskDefinition_trackLatest
=== PAUSE TestAccECSTaskDefinition_trackLatest
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSTaskDefinition_taskRoleARN
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== CONT  TestAccECSTaskDefinition_proxy
=== CONT  TestAccECSTaskDefinition_tags
=== CONT  TestAccECSTaskDefinition_trackLatest
=== CONT  TestAccECSTaskDefinition_disappears
=== CONT  TestAccECSTaskDefinition_invalidContainerDefinition
=== CONT  TestAccECSTaskDefinition_executionRole
=== CONT  TestAccECSTaskDefinition_runtimePlatform
=== CONT  TestAccECSTaskDefinition_Fargate_basic
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
=== CONT  TestAccECSTaskDefinition_service
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
=== CONT  TestAccECSTaskDefinition_fsxWinFileSystem
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (40.18s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (266.12s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (322.31s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
--- PASS: TestAccECSTaskDefinition_trackLatest (322.34s)
=== CONT  TestAccECSTaskDefinition_constraint
--- PASS: TestAccECSTaskDefinition_taskRoleARN (322.60s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_proxy (322.62s)
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (322.85s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_runtimePlatform (322.91s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (322.96s)
=== CONT  TestAccECSTaskDefinition_networkMode
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (323.09s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_executionRole (323.28s)
=== CONT  TestAccECSTaskDefinition_configuredAtLaunch
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (325.74s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (325.88s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (330.20s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (304.26s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (424.24s)
--- PASS: TestAccECSTaskDefinition_disappears (475.37s)
--- PASS: TestAccECSTaskDefinition_basic (516.57s)
--- PASS: TestAccECSTaskDefinition_service (555.15s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (296.36s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (274.79s)
--- PASS: TestAccECSTaskDefinition_configuredAtLaunch (274.69s)
--- PASS: TestAccECSTaskDefinition_arrays (275.37s)
--- PASS: TestAccECSTaskDefinition_constraint (275.73s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (272.33s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (272.16s)
--- PASS: TestAccECSTaskDefinition_networkMode (275.15s)
--- PASS: TestAccECSTaskDefinition_ipcMode (275.30s)
--- PASS: TestAccECSTaskDefinition_pidMode (275.38s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal (278.14s)
--- PASS: TestAccECSTaskDefinition_tags (603.07s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (292.14s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (3773.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	3790.964s
--- PASS: TestAccECSService_Tags_basic (771.31s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (238.53s)
--- PASS: TestAccECSService_DeploymentControllerType_external (243.35s)
--- PASS: TestAccECSService_DeploymentValues_basic (247.90s)
--- PASS: TestAccECSService_clusterName (245.17s)
--- PASS: TestAccECSService_PlacementStrategy_basic (839.21s)
--- PASS: TestAccECSService_PlacementConstraints_basic (428.55s)
--- PASS: TestAccECSService_alarmsAdd (356.84s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (544.55s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (190.27s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (563.30s)
--- PASS: TestAccECSService_alarmsUpdate (352.59s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (166.33s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (314.26s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (182.11s)
--- PASS: TestAccECSService_ServiceConnect_remove (381.43s)
--- PASS: TestAccECSService_disappears (265.32s)
--- PASS: TestAccECSService_alb (429.33s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (331.87s)
--- PASS: TestAccECSService_basicImport (277.42s)
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (393.58s)
--- PASS: TestAccECSService_ServiceConnect_full (423.89s)
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (305.40s)
--- PASS: TestAccECSService_ServiceConnect_basic (435.95s)
--- PASS: TestAccECSService_Tags_propagate (713.88s)
--- PASS: TestAccECSService_iamRole (311.74s)
--- PASS: TestAccECSService_Tags_managed (332.92s)
--- PASS: TestAccECSService_ServiceRegistries_container (411.25s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (327.54s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (329.12s)
--- PASS: TestAccECSService_PlacementStrategy_missing (28.58s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (364.99s)
--- PASS: TestAccECSService_familyAndRevision (563.38s)
--- PASS: TestAccECSService_multipleTargetGroups (568.18s)
--- PASS: TestAccECSService_basic (570.75s)
--- PASS: TestAccECSService_executeCommand (572.83s)
--- PASS: TestAccECSService_forceNewDeployment (573.30s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (573.51s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (620.25s)
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[omaraltayyan]

Please give this a bit more attention!! It has been released for a couple of months now! It's such an important feature for ECS, you'd be basically able to use EC2 launch type for tasks without having to worry about the storage of the server!!

[mforutan]

What is the next step for this PR? @justinretzolk or @ewbankkit, is there anything we can do to speed up the process for this PR?

[YakDriver]

LGTM 🎉

% make ts T='TestAccECSTaskDefinition_|TestAccECSTaskDefinitionDataSource_' K=ecs P=5
==> Checking that code complies with gofmt requirements...
Running acceptance tests with -short flag
TF_ACC=1 go1.22.2 test ./internal/service/ecs/... -v -short -count 1 -parallel 5 -run='TestAccECSTaskDefinition_|TestAccECSTaskDefinitionDataSource_'  -timeout 360m
=== RUN   TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== PAUSE TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_configuredAtLaunch
=== PAUSE TestAccECSTaskDefinition_configuredAtLaunch
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
    task_definition_test.go:583: skipping long-running test in short mode
--- SKIP: TestAccECSTaskDefinition_fsxWinFileSystem (0.00s)
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== RUN   TestAccECSTaskDefinition_invalidContainerDefinition
=== PAUSE TestAccECSTaskDefinition_invalidContainerDefinition
=== RUN   TestAccECSTaskDefinition_trackLatest
=== PAUSE TestAccECSTaskDefinition_trackLatest
=== CONT  TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== CONT  TestAccECSTaskDefinition_taskRoleARN
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== CONT  TestAccECSTaskDefinition_trackLatest
=== CONT  TestAccECSTaskDefinition_invalidContainerDefinition
--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (2.04s)
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
--- PASS: TestAccECSTaskDefinitionDataSource_ecsTaskDefinition (17.32s)
=== CONT  TestAccECSTaskDefinition_proxy
--- PASS: TestAccECSTaskDefinition_trackLatest (20.87s)
=== CONT  TestAccECSTaskDefinition_tags
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (20.88s)
=== CONT  TestAccECSTaskDefinition_disappears
--- PASS: TestAccECSTaskDefinition_taskRoleARN (21.26s)
=== CONT  TestAccECSTaskDefinition_executionRole
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (19.24s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
--- PASS: TestAccECSTaskDefinition_executionRole (20.81s)
=== CONT  TestAccECSTaskDefinition_service
--- PASS: TestAccECSTaskDefinition_proxy (31.88s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
--- PASS: TestAccECSTaskDefinition_disappears (29.10s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (30.56s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (14.28s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskDefinition_tags (53.60s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (28.76s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (33.04s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (28.24s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_arrays (18.22s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal (27.55s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (27.77s)
=== CONT  TestAccECSTaskDefinition_networkMode
--- PASS: TestAccECSTaskDefinition_Fargate_basic (23.84s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_ipcMode (19.79s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
--- PASS: TestAccECSTaskDefinition_pidMode (19.73s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSTaskDefinition_networkMode (19.59s)
=== CONT  TestAccECSTaskDefinition_runtimePlatform
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (18.44s)
=== CONT  TestAccECSTaskDefinition_configuredAtLaunch
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (18.29s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (18.29s)
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccECSTaskDefinition_runtimePlatform (18.06s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSTaskDefinition_configuredAtLaunch (18.51s)
=== CONT  TestAccECSTaskDefinition_basic
--- PASS: TestAccECSTaskDefinition_service (112.67s)
=== CONT  TestAccECSTaskDefinition_constraint
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (18.42s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (18.47s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (29.62s)
--- PASS: TestAccECSTaskDefinition_constraint (19.80s)
--- PASS: TestAccECSTaskDefinition_basic (28.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	183.024s
% make t T=TestAccECSService K=ecs                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService'  -timeout 360m
=== RUN   TestAccECSServiceDataSource_basic
=== PAUSE TestAccECSServiceDataSource_basic
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== RUN   TestAccECSService_PlacementStrategy_unnormalized
=== PAUSE TestAccECSService_PlacementStrategy_unnormalized
=== RUN   TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN   TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== RUN   TestAccECSService_CapacityProviderStrategy_update
=== PAUSE TestAccECSService_CapacityProviderStrategy_update
=== RUN   TestAccECSService_VolumeConfiguration_basic
=== PAUSE TestAccECSService_VolumeConfiguration_basic
=== RUN   TestAccECSService_VolumeConfiguration_update
=== PAUSE TestAccECSService_VolumeConfiguration_update
=== RUN   TestAccECSService_familyAndRevision
=== PAUSE TestAccECSService_familyAndRevision
=== RUN   TestAccECSService_healthCheckGracePeriodSeconds
=== PAUSE TestAccECSService_healthCheckGracePeriodSeconds
=== RUN   TestAccECSService_iamRole
=== PAUSE TestAccECSService_iamRole
=== RUN   TestAccECSService_DeploymentControllerType_codeDeploy
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeploy
=== RUN   TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== RUN   TestAccECSService_DeploymentControllerType_external
=== PAUSE TestAccECSService_DeploymentControllerType_external
=== RUN   TestAccECSService_alarmsAdd
=== PAUSE TestAccECSService_alarmsAdd
=== RUN   TestAccECSService_alarmsUpdate
=== PAUSE TestAccECSService_alarmsUpdate
=== RUN   TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN   TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== PAUSE TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== RUN   TestAccECSService_deploymentCircuitBreaker
=== PAUSE TestAccECSService_deploymentCircuitBreaker
=== RUN   TestAccECSService_loadBalancerChanges
=== PAUSE TestAccECSService_loadBalancerChanges
=== RUN   TestAccECSService_clusterName
=== PAUSE TestAccECSService_clusterName
=== RUN   TestAccECSService_alb
=== PAUSE TestAccECSService_alb
=== RUN   TestAccECSService_multipleTargetGroups
=== PAUSE TestAccECSService_multipleTargetGroups
=== RUN   TestAccECSService_forceNewDeployment
=== PAUSE TestAccECSService_forceNewDeployment
=== RUN   TestAccECSService_forceNewDeploymentTriggers
=== PAUSE TestAccECSService_forceNewDeploymentTriggers
=== RUN   TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN   TestAccECSService_PlacementStrategy_missing
=== PAUSE TestAccECSService_PlacementStrategy_missing
=== RUN   TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN   TestAccECSService_PlacementConstraints_emptyExpression
=== PAUSE TestAccECSService_PlacementConstraints_emptyExpression
=== RUN   TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN   TestAccECSService_LaunchTypeFargate_platformVersion
=== PAUSE TestAccECSService_LaunchTypeFargate_platformVersion
=== RUN   TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== RUN   TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== RUN   TestAccECSService_LaunchTypeEC2_network
=== PAUSE TestAccECSService_LaunchTypeEC2_network
=== RUN   TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN   TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== RUN   TestAccECSService_replicaSchedulingStrategy
=== PAUSE TestAccECSService_replicaSchedulingStrategy
=== RUN   TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN   TestAccECSService_ServiceRegistries_container
=== PAUSE TestAccECSService_ServiceRegistries_container
=== RUN   TestAccECSService_ServiceRegistries_changes
=== PAUSE TestAccECSService_ServiceRegistries_changes
=== RUN   TestAccECSService_ServiceRegistries_removal
=== PAUSE TestAccECSService_ServiceRegistries_removal
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN   TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== PAUSE TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== RUN   TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN   TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== RUN   TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN   TestAccECSService_Tags_managed
=== PAUSE TestAccECSService_Tags_managed
=== RUN   TestAccECSService_Tags_propagate
=== PAUSE TestAccECSService_Tags_propagate
=== RUN   TestAccECSService_executeCommand
=== PAUSE TestAccECSService_executeCommand
=== CONT  TestAccECSServiceDataSource_basic
=== CONT  TestAccECSService_forceNewDeploymentTriggers
=== CONT  TestAccECSService_ServiceRegistries_basic
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
=== CONT  TestAccECSService_ServiceConnect_basic
=== CONT  TestAccECSService_Tags_managed
=== CONT  TestAccECSService_executeCommand
=== CONT  TestAccECSService_ServiceConnect_remove
=== CONT  TestAccECSService_DeploymentControllerType_codeDeploy
=== CONT  TestAccECSService_deploymentCircuitBreaker
=== CONT  TestAccECSService_healthCheckGracePeriodSeconds
=== CONT  TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== CONT  TestAccECSService_ServiceRegistries_removal
=== CONT  TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== CONT  TestAccECSService_replicaSchedulingStrategy
=== CONT  TestAccECSService_ServiceRegistries_changes
=== CONT  TestAccECSService_ServiceRegistries_container
=== CONT  TestAccECSService_familyAndRevision
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
=== CONT  TestAccECSService_Tags_basic
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (47.39s)
=== CONT  TestAccECSService_ServiceConnect_tls_with_empty_timeout
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (47.48s)
=== CONT  TestAccECSService_iamRole
--- PASS: TestAccECSServiceDataSource_basic (80.98s)
=== CONT  TestAccECSService_ServiceConnect_full
--- PASS: TestAccECSService_replicaSchedulingStrategy (90.67s)
=== CONT  TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_familyAndRevision (91.21s)
=== CONT  TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_Tags_managed (91.47s)
=== CONT  TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== CONT  TestAccECSService_VolumeConfiguration_update
--- PASS: TestAccECSService_deploymentCircuitBreaker (91.63s)
--- PASS: TestAccECSService_executeCommand (94.12s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_iamRole (53.18s)
=== CONT  TestAccECSService_VolumeConfiguration_basic
--- PASS: TestAccECSService_Tags_basic (109.84s)
=== CONT  TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_forceNewDeploymentTriggers (135.53s)
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSService_ServiceRegistries_basic (160.22s)
=== CONT  TestAccECSService_Tags_propagate
--- PASS: TestAccECSService_ServiceRegistries_container (160.26s)
=== CONT  TestAccECSService_alarmsUpdate
--- PASS: TestAccECSService_ServiceRegistries_removal (164.24s)
=== CONT  TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSService_VolumeConfiguration_basic (64.83s)
=== CONT  TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_ServiceConnect_basic (165.69s)
=== CONT  TestAccECSService_PlacementConstraints_emptyExpression
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (76.33s)
=== CONT  TestAccECSService_disappears
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (170.51s)
=== CONT  TestAccECSService_LaunchTypeFargate_platformVersion
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (182.23s)
=== CONT  TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_ServiceConnect_remove (209.49s)
=== CONT  TestAccECSService_alarmsAdd
--- PASS: TestAccECSService_VolumeConfiguration_update (123.64s)
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (171.19s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
--- PASS: TestAccECSService_DeploymentControllerType_external (37.08s)
=== CONT  TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (133.46s)
=== CONT  TestAccECSService_alb
--- PASS: TestAccECSService_LaunchTypeEC2_network (115.55s)
=== CONT  TestAccECSService_forceNewDeployment
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (136.14s)
=== CONT  TestAccECSService_multipleTargetGroups
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (67.71s)
=== CONT  TestAccECSService_basic
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (69.21s)
=== CONT  TestAccECSService_loadBalancerChanges
--- PASS: TestAccECSService_DeploymentValues_basic (69.58s)
=== CONT  TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (1.87s)
=== CONT  TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_alarmsUpdate (80.89s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_Tags_propagate (92.88s)
=== CONT  TestAccECSService_clusterName
--- PASS: TestAccECSService_ServiceConnect_full (172.29s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (285.73s)
--- PASS: TestAccECSService_alarmsAdd (81.10s)
--- PASS: TestAccECSService_ServiceRegistries_changes (307.65s)
--- PASS: TestAccECSService_basic (79.31s)
--- PASS: TestAccECSService_PlacementConstraints_basic (78.28s)
--- PASS: TestAccECSService_clusterName (75.43s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (331.57s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (240.99s)
--- PASS: TestAccECSService_forceNewDeployment (110.52s)
--- PASS: TestAccECSService_basicImport (201.03s)
--- PASS: TestAccECSService_PlacementStrategy_basic (112.41s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (178.98s)
--- PASS: TestAccECSService_disappears (186.37s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (146.01s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (155.62s)
--- PASS: TestAccECSService_alb (271.85s)
--- PASS: TestAccECSService_loadBalancerChanges (268.53s)
--- PASS: TestAccECSService_multipleTargetGroups (274.39s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (476.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	697.593s

[mforutan]

Thank you! @nikhil-goenka @YakDriver

[github-actions]

This functionality has been released in v5.51.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.