f-aws_ecs_service: support for EBS

.changelog/37019.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_ecs_service: Add `volume_configuration` argument
+```
+
+```release-note:enhancement
+resource/aws_ecs_task_definition: Add `configure_at_launch` parameter in `volume` argument
+```

GNUmakefile

@@ -503,6 +503,7 @@ semgrep-code-quality: semgrep-validate ## [CI] Semgrep Checks / Code Quality Sca
 semgrep-constants: semgrep-validate ## Fix constants with Semgrep --autofix
 	@echo "make: Fix constants with Semgrep --autofix"
 	@semgrep $(SEMGREP_ARGS) --autofix \
+		$(if $(filter-out $(origin PKG), undefined),--include $(PKG_NAME),) \
 		--config .ci/.semgrep-constants.yml \
 		--config .ci/.semgrep-test-constants.yml
 

internal/service/ecs/service.go

@@ -518,6 +518,69 @@ func ResourceService() *schema.Resource {
 				Optional: true,
 				Default:  false,
 			},
+			"volume_configuration": {
+				Type:     schema.TypeList,
+				Optional: true,
+				MaxItems: 1,
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						names.AttrName: {
+							Type:     schema.TypeString,
+							Required: true,
+						},
+						"managed_ebs_volume": {
+							Type:     schema.TypeList,
+							Required: true,
+							MaxItems: 1,
+							Elem: &schema.Resource{
+								Schema: map[string]*schema.Schema{
+									names.AttrRoleARN: {
+										Type:         schema.TypeString,
+										Required:     true,
+										ValidateFunc: verify.ValidARN,
+									},
+									names.AttrEncrypted: {
+										Type:     schema.TypeBool,
+										Optional: true,
+										Default:  true,
+									},
+									"file_system_type": {
+										Type:         schema.TypeString,
+										Optional:     true,
+										Default:      ecs.TaskFilesystemTypeXfs,
+										ValidateFunc: validation.StringInSlice(ecs.TaskFilesystemType_Values(), false),
+									},
+									names.AttrIOPS: {
+										Type:     schema.TypeInt,
+										Optional: true,
+									},
+									names.AttrKMSKeyID: {
+										Type:     schema.TypeString,
+										Optional: true,
+									},
+									"size_in_gb": {
+										Type:     schema.TypeInt,
+										Optional: true,
+									},
+									names.AttrSnapshotID: {
+										Type:     schema.TypeString,
+										Optional: true,
+									},
+									"throughput": {
+										Type:         schema.TypeString,
+										Optional:     true,
+										ValidateFunc: validation.IntBetween(0, 1000),
+									},
+									names.AttrVolumeType: {
+										Type:     schema.TypeString,
+										Optional: true,
+									},
+								},
+							},
+						},
+					},
+				},
+			},
 		},
 
 		CustomizeDiff: customdiff.Sequence(
@@ -625,6 +688,10 @@ func resourceServiceCreate(ctx context.Context, d *schema.ResourceData, meta int
 		input.ServiceConnectConfiguration = expandServiceConnectConfiguration(v.([]interface{}))
 	}
 
+	if v, ok := d.GetOk("volume_configuration"); ok && len(v.([]interface{})) > 0 {
+		input.VolumeConfigurations = expandVolumeConfigurations(v.([]interface{}))
+	}
+
 	serviceRegistries := d.Get("service_registries").([]interface{})
 	if len(serviceRegistries) > 0 {
 		srs := make([]*ecs.ServiceRegistry, 0, len(serviceRegistries))
@@ -956,6 +1023,10 @@ func resourceServiceUpdate(ctx context.Context, d *schema.ResourceData, meta int
 			input.ServiceConnectConfiguration = expandServiceConnectConfiguration(d.Get("service_connect_configuration").([]interface{}))
 		}
 
+		if d.HasChange("volume_configuration") {
+			input.VolumeConfigurations = expandVolumeConfigurations(d.Get("volume_configuration").([]interface{}))
+		}
+
 		if d.HasChange("service_registries") {
 			input.ServiceRegistries = expandServiceRegistries(d.Get("service_registries").([]interface{}))
 		}
@@ -1466,6 +1537,67 @@ func expandSecretOptions(sop []interface{}) []*ecs.Secret {
 	return out
 }
 
+func expandVolumeConfigurations(vc []interface{}) []*ecs.ServiceVolumeConfiguration {
+	if len(vc) == 0 {
+		return nil
+	}
+
+	vcs := make([]*ecs.ServiceVolumeConfiguration, 0)
+
+	for _, raw := range vc {
+		p := raw.(map[string]interface{})
+
+		config := &ecs.ServiceVolumeConfiguration{
+			Name: aws.String(p[names.AttrName].(string)),
+		}
+
+		if v, ok := p["managed_ebs_volume"].([]interface{}); ok && len(v) > 0 {
+			config.ManagedEBSVolume = expandManagedEBSVolume(v)
+		}
+		vcs = append(vcs, config)
+	}
+
+	return vcs
+}
+
+func expandManagedEBSVolume(ebs []interface{}) *ecs.ServiceManagedEBSVolumeConfiguration {
+	if len(ebs) == 0 {
+		return &ecs.ServiceManagedEBSVolumeConfiguration{}
+	}
+	raw := ebs[0].(map[string]interface{})
+
+	config := &ecs.ServiceManagedEBSVolumeConfiguration{}
+	if v, ok := raw[names.AttrRoleARN].(string); ok && v != "" {
+		config.RoleArn = aws.String(v)
+	}
+	if v, ok := raw[names.AttrEncrypted].(bool); ok {
+		config.Encrypted = aws.Bool(v)
+	}
+	if v, ok := raw["file_system_type"].(string); ok && v != "" {
+		config.FilesystemType = aws.String(v)
+	}
+	if v, ok := raw[names.AttrIOPS].(int); ok && v != 0 {
+		config.Iops = aws.Int64(int64(v))
+	}
+	if v, ok := raw[names.AttrKMSKeyID].(string); ok && v != "" {
+		config.KmsKeyId = aws.String(v)
+	}
+	if v, ok := raw["size_in_gb"].(int); ok && v != 0 {
+		config.SizeInGiB = aws.Int64(int64(v))
+	}
+	if v, ok := raw[names.AttrSnapshotID].(string); ok && v != "" {
+		config.SnapshotId = aws.String(v)
+	}
+	if v, ok := raw["throughput"].(int); ok && v != 0 {
+		config.Throughput = aws.Int64(int64(v))
+	}
+	if v, ok := raw[names.AttrVolumeType].(string); ok && v != "" {
+		config.VolumeType = aws.String(v)
+	}
+
+	return config
+}
+
 func expandServices(srv []interface{}) []*ecs.ServiceConnectService {
 	if len(srv) == 0 {
 		return nil