-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privileged Identity Management (PIM) #68
Comments
What would also be super helpful here would be support for "Azure Resources" PIM. |
Thanks for requesting this feature! It looks like PIM management is only available via the MS Graph API which we are currently not in a position to use as we're waiting on SDK support. I've marked this request as upstream-dependent and we'll revisit as soon as we are able. |
maybe add the assignment type (eligible/active) |
This would be tremendously useful to have in Terraform. The API docs are here: https://docs.microsoft.com/en-us/graph/api/resources/privilegedidentitymanagement-resources?view=graph-rest-beta (beta) |
Agreed; this would be a very welcome addition! |
Would be super handy for our production setup. Currently, this missing functionality means quite some manual work |
This feature is currently waiting on implementation of MS Graph. We are actively working on it and this issue will receive priority as soon as we are able. See hashicorp/terraform-provider-azurerm#323 for more details. Thanks! |
+1 A few use cases I would like to see met:
Presently I am resorting to using the AzureAD Preview PowerShell cmdlets. These work well but it is not as elegant as tf. |
We create all our RBAC groups using terraform when a resource group is provisioned, but they need manually onboarding to PIM so this would be very useful. Any update? |
@manicminer , it appears that MS Graph was implemented in azuread version 1.5.0 (LINK HERE). Does this mean that this issue can receive priority now or maybe it's already in progress? |
In order to maintain compatibility, new features will only be merged in v2.0 (or later), which we're working on right now. Privileged Identity Management is a reasonably large feature that will likely not make it into 2.0, but will hopefully come soon thereafter as it's the highest voted feature on our backlog. |
I'm already subscribed to this issue but whenever it's ready I'm happy to volunteer testing time. |
This comment has been minimized.
This comment has been minimized.
I am interested in this feature as-well - Happy to implement the resources and datasources myself if help is needed. @manicminer - Let me know by ping, this is required by my workplace aswell. |
This comment has been minimized.
This comment has been minimized.
Thanks for the interest, but please stick to +1 on the original message. Help is always very welcome, however this particular feature is nontrivial - for context, there are 3 distinct iterations of this service, incompatible with each other and none of which have yet made it out of beta. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dear All, as Microsoft changed it's PIM API in October (https://docs.microsoft.com/en-us/graph/api/resources/privilegedidentitymanagement-root?view=graph-rest-beta), it might be a good thing to ask once again how the Status for the Azure PIM Terraform Provider is at the Moment? Anything planed or is there nothing on the horizon? Just wondering, as i think this would be a great thing for AAD PIM and Azure Resources PIM to be able to enroll it with Terraform. |
This would be really helpful, as we are planning to onboard management group structure into PIM, and we keep the RBAC assignments on the MG scope in TF state. |
Seems like there is already work in progress - #547 |
Hi all. Would love to know if any updates on this issue.. Would love to see this implemented in tf as soon as possible. |
Hello, checking up on this one as we need it via tf rather than regular clickops. Any updates, please? |
Hi, what's the status of this much desired and valuable feature ? |
Just want to say that this Entra ID role PIM support for Terraform Azure AD provider is really needed and waited feature in our organization. I wish we could have some ETA? There are over 400 up votes for this issue so I'm assuming our organization is not the only one waiting for this. 🤞 🙏 |
…ensions Add Support For Schema Extensions
PIM for Groups in my opinion, in general, is a challenging feature to automate, even without Terraform. From trying to get this to work, using PowerShell, or a chain of API calls from Postman, I've ended up with this workflow, which I'm sharing here as others may glean at least some automation on this front. At the core of the automation, the following happens:
The challenge for Terraform right now, is that none of the PIM for Groups API methods are in the |
Looks like manicminer/hamilton#277 got merged, any word on when this work is planned @oWretch? |
The PR for this is waiting review. @manicminer is away this week, so I'm hoping it will be released at the end of next week. |
Can someone please confirm , How to use "Then use the unifiedRoleManagementPolicy Graph API endpoint to PATCH the second group, with appropriate settings" ? I am in the same boat, I need to enable PIM for groups, After creating the AAD Group would like to run powershell with unified policy to have minimal updates any policy changes and enable the PIM for groups As provided in the documentation, I did updated to have scoped and scope type, But still doesn't work, running into provider missing errror Below is my code $policies = Get-MgPolicyRoleManagementPolicyAssignment Placeholder for the right policy ID$policyId = $null foreach ($policy in $policies) { } if ($null -eq $policyId) { } else {
|
At this point you are probably better to wait until this PR gets merged and released. I doubt it will be long now... |
Its interesting they're moving it to AzureAD, where the other PIM stuff lives in AzureRM. |
@tim-chaffin I'm hoping the AzureAD part is meant to handle Azure AD/Entra ID roles, while AzureRM will handle Azure resource roles. I'm still running into issues with the AzureRM counterpart but that's a whole other resource provider. |
@MohnJadden you are correct. #1327 is there to handle PIM assignments of one group to another Entra ID group. There is already support (with an outstanding issue) for Entra ID roles in the Azure AD provider. And there are probably fixes required for the Azure role assignments, as you have mentioned. |
Do we have an ETA on this at all? I can't tell you how much I am eagerly awaiting this! |
I just @ed the one remaining reviewer in the other thread. I'm not with HCP but hopefully this gets done and working before the acquisition completes and everyone cashes out. |
Hello, Any update on this ?, It would really help to have this deployed soon. Thanks! |
@manicminer I saw that we've merged the much anticipated PR. This is excellent news! I know I for am very grateful for this. However, can anyone shed some light on how these modules work? I checked the docs, and I didn't see anything yet. If someone could help us see how we'd create a PIM group through these modules, and configure the attributes, that would be amazing. |
It's not been released yet. You need to wait for 2.49.0 to drop https://github.com/hashicorp/terraform-provider-azuread/releases |
Yep that'll be released tomorrow. In the meantime, the docs are in the repo and have good examples to start from (if you wanted to build from source in the meantime). |
Looks like this is targeting AD group only? Can it be used to target SP/User level?
|
Spread the news! |
So here's the thing. Based on the documentation and the fact that I can do this via Portal without any of the |
Community Note
Description
Ability to Create PIM Policies and Configure PIM access via Terraform
New or Affected Resource(s)
New data source would be required
Potential Terraform Configuration
References
https://docs.microsoft.com/en-us/azure/active-directory/privileged-identity-management/pim-configure
The text was updated successfully, but these errors were encountered: