Delete managed OS disk when destroying VM

[cehoffman]

Given an azurerm_virtual_machine using a managed OS disk is created then destroyed. The same configuration can not be reused because the managed OS disk resource still exists. When a VM is destroyed and has a managed OS disk, the OS disk should be destroyed too to prevent leaking of resources.

Data disks have the problem too, but it can be mitigated using the azurerm_managed_disk resource separately and linking to that created instance in the storage_data_disk block. The OS block can not do this due to azurerm_managed_disk not supporting creation FromImage.

[DWSR]

I can confirm this behaviour +1

[StephenWeatherford]

@cehoffman, @DWSR Have you tried https://www.terraform.io/docs/providers/azurerm/r/virtual_machine.html#delete_os_disk_on_termination?

[cehoffman]

Huh, I'll have to give that a try. Thought I had read over all the flags, but apparently that one didn't stick in my head. Will report back once I get to try it.

[StephenWeatherford]

Is there a way we can improve the documentation so that you would have found this more easily? Thx.

[cehoffman]

Only suggestion I have is to include it in one of the examples. Overall the examples are so good you don't usually need to look much at the detailed options to get going.

[cehoffman]

This works as advertised.

[StephenWeatherford]

To summarize - the behavior noted is by design. If users want to have the OS or data disks deleted with the VM, they can use the delete_{os,data}_disk{,s}_on_termination flags.

Looking into whether the docs can make this easier to find.

[tombuildsstuff]

Associated PR: #139

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!