[MS] Fixes #127 Improve docs for delete_os_disk_on_termination #139
Conversation
|
Thanks for this PR - this LGTM. Thinking about it, I don't think this warrants a separate example - however it'd be good to also integrate this into the Unmanaged Disks example too. Looking at the examples - given Managed Disks are the recommended approach going forward, is it worth moving this to be the first example on the page? In addition - given the Managed Disks example contains multiple disks, we could probably do the same for the Unmanaged disks and combine the two examples - what do you think? |
|
Great suggestions, Tom! Implemented. |
| managed_disk_type = "Standard_LRS" | ||
| } | ||
|
|
||
| // Optional data disks |
There was a problem hiding this comment.
checking our other examples we use # for comments in HCL rather than // - I'm going to push a commit to update this :)
|
Awesome - thanks for this @StephenWeatherford :) |
[MS] Fixes #127 Improve docs for delete_os_disk_on_termination
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
What do you think? The other possibility is to add a new example example "Usage (Managed Disks, Deleted When VM Deleted)", or maybe just add a note.