Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation problem: VMSS & MSI #1539

Closed
Supermathie opened this issue Jul 11, 2018 · 2 comments · Fixed by #1549
Closed

Documentation problem: VMSS & MSI #1539

Supermathie opened this issue Jul 11, 2018 · 2 comments · Fixed by #1549
Labels
bug documentation service/vmss Virtual Machine Scale Sets

Comments

@Supermathie
Copy link
Contributor

The documentation on https://www.terraform.io/docs/providers/azurerm/r/virtual_machine_scale_set.html has incorrect sample code for the identity block:

resource "azurerm_virtual_machine_scale_set" "test" {
  name                = "vm-scaleset"
  resource_group_name = "${azurerm_resource_group.test.name}"
  location            = "${azurerm_resource_group.test.location}"output "principal_id" {
    value = "${lookup(azurerm_virtual_machine.test.identity[0], "principal_id")}"
  }

There's two problems:

  • should be azurerm_virtual_machine_scale_set not azurerm_virtual_machine
  • output block should be outside of the resource block
@tombuildsstuff
Copy link
Contributor

hey @Supermathie

Thanks for opening this issue - I've opened #1549 which includes a fix for this :)

Thanks!

torresdal added a commit to torresdal/terraform-provider-azurerm that referenced this issue Aug 25, 2018
* api-management:
  Updating to include hashicorp#1565
  resource/servicebus_subscription_rule: Fix the correlation_filter optional values (hashicorp#1565)
  Updating to include hashicorp#1563
  resouce/app_insights: Allow different application_type deployments (hashicorp#1563)
  VMSS: changed sku property from a set to list
  Update CHANGELOG.md to include hashicorp#1552
  Renamed azurerm_azuread_application.html.markdown to azuread_application.html.markdown
  New Data Source: `azurerm_azuread_application`
  VMSS: Updating the code samples to be valid. Fixes hashicorp#1539 (hashicorp#1549)
  Creation Data -> Creation Date (hashicorp#1548)
  Updating to include hashicorp#1546
  Workaround upstream issue in creating azureEndpoints in traffic manager (hashicorp#1546)
  Cleanup after v1.9.0 release
  v1.9.0
  Updating to include hashicorp#1269
  New Resource: `azurerm_azuread_application` (hashicorp#1269)
  Remove tags validate in preConfig of TestAccAzureRMKeyVault_update (hashicorp#1534)
  Updating to include hashicorp#1535
  `azurerm_key_vault_key` - handling the parent Key Vault being deleted (hashicorp#1535)
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug documentation service/vmss Virtual Machine Scale Sets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants