Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: azurerm_azuread_application #1552

Merged
merged 2 commits into from
Jul 12, 2018
Merged

New Data Source: azurerm_azuread_application #1552

merged 2 commits into from
Jul 12, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMAzureADApplication_
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byObjectId
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectId (19.70s)
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete (22.12s)
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byName
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byName (33.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	75.073s

@tombuildsstuff
New Data Source: azurerm_azuread_application
e64a7b3 
Tests pass:
```
$ acctests azurerm TestAccDataSourceAzureRMAzureADApplication_
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byObjectId
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectId (19.70s)
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byObjectIdComplete (22.12s)
=== RUN   TestAccDataSourceAzureRMAzureADApplication_byName
--- PASS: TestAccDataSourceAzureRMAzureADApplication_byName (33.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	75.073s
```
@tombuildsstuff tombuildsstuff added this to the 1.10.0 milestone Jul 12, 2018
@tombuildsstuff tombuildsstuff requested a review from a team July 12, 2018 14:44
katbyte
katbyte approved these changes Jul 12, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside the CI failure 👍

@katbyte katbyte merged commit f9f35bd into master Jul 12, 2018
@katbyte katbyte deleted the data-source-azuread-app branch July 12, 2018 18:52
katbyte added a commit that referenced this pull request Jul 12, 2018
@katbyte
Update CHANGELOG.md to include #1552
fe4e024
@tombuildsstuff tombuildsstuff mentioned this pull request Jul 19, 2018
Closed
torresdal added a commit to torresdal/terraform-provider-azurerm that referenced this pull request Aug 25, 2018
@torresdal
Merge branch 'api-management' into api-management-api
2004c75 
* api-management:
  Updating to include hashicorp#1565
  resource/servicebus_subscription_rule: Fix the correlation_filter optional values (hashicorp#1565)
  Updating to include hashicorp#1563
  resouce/app_insights: Allow different application_type deployments (hashicorp#1563)
  VMSS: changed sku property from a set to list
  Update CHANGELOG.md to include hashicorp#1552
  Renamed azurerm_azuread_application.html.markdown to azuread_application.html.markdown
  New Data Source: `azurerm_azuread_application`
  VMSS: Updating the code samples to be valid. Fixes hashicorp#1539 (hashicorp#1549)
  Creation Data -> Creation Date (hashicorp#1548)
  Updating to include hashicorp#1546
  Workaround upstream issue in creating azureEndpoints in traffic manager (hashicorp#1546)
  Cleanup after v1.9.0 release
  v1.9.0
  Updating to include hashicorp#1269
  New Resource: `azurerm_azuread_application` (hashicorp#1269)
  Remove tags validate in preConfig of TestAccAzureRMKeyVault_update (hashicorp#1534)
  Updating to include hashicorp#1535
  `azurerm_key_vault_key` - handling the parent Key Vault being deleted (hashicorp#1535)
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
new-data-source service/authentication
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte