Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identity: making the identity behaviour consistent (L -> Container) #15325

Merged
merged 14 commits into from
Feb 9, 2022
Merged

identity: making the identity behaviour consistent (L -> Container) #15325

merged 14 commits into from
Feb 9, 2022

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Feb 8, 2022 •
edited
Loading

Following on from #15303, this PR works through making the identity blocks consistent as a part of #15187.

Fixes #14874

@tombuildsstuff
r/firewall_policy: refactoring to use the common identity schema
6a63aa2
@tombuildsstuff
eventgrid: refactoring so that the identity blocks are consistent
828b9ae
@tombuildsstuff
r/data_share_account: refactoring to use the common identity schema
e05c2a7 
Turns out that `identity` is forcenew here too, so I've updated the docs to match
@tombuildsstuff
r/data_lake_store: refactoring the Expand method to use the None type
a454439
@tombuildsstuff
r/cosmosdb_account: refactoring to use common identity schema
4de670a
@tombuildsstuff
r/kubernetes_cluster: conditionally switching over to the new identit…
9a56e66 
…y schema
@tombuildsstuff
d/kubernetes_cluster: refactoring to use the new identity schema when…
26b887e 
… the beta is enabled
@tombuildsstuff
r/container_registry_task: switching to use the common identity types
985347e 
This is easiest to move to using the raw schema types for now - when Structs are added to Helpers this can be switched back, however.
@tombuildsstuff
r/container_registry: switching to use the common identity schema
133767f
@tombuildsstuff
r/container_group: refactoring to use the common identity schema
da56c28
@tombuildsstuff tombuildsstuff added this to the v2.96.0 milestone Feb 8, 2022
@tombuildsstuff tombuildsstuff requested a review from a team February 8, 2022 18:19
@tombuildsstuff tombuildsstuff force-pushed the f/consistent-identity-blocks-3 branch from 28b2849 to 0631ea1 Compare February 9, 2022 10:36
jackofallops
jackofallops approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - a few super-minor whitespace comments in the imports, otherwise LGTM 👍

internal/services/containers/kubernetes_cluster_auth_resource_test.go Outdated Show resolved Hide resolved
internal/services/containers/kubernetes_cluster_network_resource_test.go Outdated Show resolved Hide resolved
internal/services/cosmos/cosmosdb_account_resource.go Outdated Show resolved Hide resolved
internal/services/datashare/data_share_account_resource.go Outdated Show resolved Hide resolved
internal/services/firewall/firewall_policy_resource_test.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff mentioned this pull request Feb 9, 2022
Merged
tombuildsstuff and others added 3 commits February 9, 2022 14:09
@tombuildsstuff @jackofallops
Update internal/services/containers/kubernetes_cluster_auth_resource_…
ed2a8a2 
…test.go

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
@tombuildsstuff @jackofallops
Update internal/services/containers/kubernetes_cluster_network_resour…
cd009e9 
…ce_test.go

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
@tombuildsstuff
fixing up pr comments
89db28b
@tombuildsstuff tombuildsstuff merged commit c558f2d into main Feb 9, 2022
@tombuildsstuff tombuildsstuff deleted the f/consistent-identity-blocks-3 branch February 9, 2022 15:26
@github-actions
Copy link

This functionality has been released in v2.96.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
documentation refactor service/cosmosdb service/data-lake service/data-share service/event-grid EventGrid service/firewall size/XL
Projects
None yet
Milestone
v2.96.0
Development

Successfully merging this pull request may close these issues.

azurerm_cosmosdb_account: Problem setting identity
2 participants
@tombuildsstuff @jackofallops