Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consistent identity blocks - part 4 #15336

Merged
merged 11 commits into from
Feb 9, 2022
Merged

refactor: consistent identity blocks - part 4 #15336

merged 11 commits into from
Feb 9, 2022

Conversation

tombuildsstuff
Copy link
Contributor

This PR is part 4 of making the identity blocks consistent, being tracked in #15187 - which once #15325 is merged means that remaining is:

  • App Service
  • Data Factory
  • Machine Learning
  • Web

There's a couple of what look to be breaking changes in here, but the fields are required today (both in documentation and the expand functions) so these should be safe to update

@tombuildsstuff
vmss: refactoring to use the common identity schema types
9646805
@tombuildsstuff
r/orchestrated_virtual_machine_scale_set: refactoring to use the comm…
e08f7c0 
…on identity schema
@tombuildsstuff
virtual_machine: refactoring to use the common identity schema
5cc0605
@tombuildsstuff
r/disk_encryption_set: switching to use the common identity schema
3985af3
@tombuildsstuff
r/cognitive_account: refactoring to use the common identity schema
73eb7f5
@tombuildsstuff
r/blueprint_assignment: refactoring to use the common identity schema
c9baeed
@tombuildsstuff
r/batch_pool: refactoring to use the common identity schema
93742fa
@tombuildsstuff
r/batch_account: refactoring to use the common identity schema
d2533e9
@tombuildsstuff
r/app_configuration: refactoring to use the common identity schema
fcbd5d2
@tombuildsstuff
r/api_management: refactoring to use the common identity schema
b7a53d6
@tombuildsstuff
d/api_management: refactoring to use the common identity schema
4c316a7
@tombuildsstuff tombuildsstuff added this to the v2.96.0 milestone Feb 9, 2022
@tombuildsstuff tombuildsstuff requested a review from a team February 9, 2022 13:09
stephybun
stephybun approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@tombuildsstuff tombuildsstuff merged commit cf28610 into main Feb 9, 2022
@tombuildsstuff tombuildsstuff deleted the f/consistent-identity-blocks-4 branch February 9, 2022 15:26
@github-actions
Copy link

This functionality has been released in v2.96.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
refactor service/api-management service/app-configuration service/batch service/blueprints service/cognitive-services size/XL
Projects
None yet
Milestone
v2.96.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @stephybun