Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updating dns to use hashicorp/go-azure-sdk #17834

Closed
wants to merge 130 commits into from

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates the dns service to use hashicorp/go-azure-sdk

@tombuildsstuff tombuildsstuff added this to the v3.17.0 milestone Aug 1, 2022
@tombuildsstuff tombuildsstuff requested a review from a team August 1, 2022 17:31
@tombuildsstuff tombuildsstuff marked this pull request as draft August 1, 2022 17:31
tombuildsstuff and others added 10 commits August 1, 2022 18:35
… their new place (#17819)

* Docs: point `timeouts` and `operation-timeouts` links to their new place

Signed-off-by: Gergő Rubint <gergo@grubint.com>

* Docs: point `lifecycle` links to their new place

Signed-off-by: Gergő Rubint <gergo@grubint.com>
Scale-down Mode went GA in April 2022, and spot node pools are now fully supported.
…r. (#17836)

If we leave this parameter `nil` in creation, the API will respond `0` when we read, so I add a default value to this argument.

Co-authored-by: zjhe <hezijie@microsoft.com>
…7780)

* rebase and resolve merge conflicts

* update code

* update code

* update code
…mentation for associating to vNets (#17734)

* Updated documentation

* Update website/docs/r/app_service_virtual_network_swift_connection.html.markdown

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

* Update website/docs/r/app_service_virtual_network_swift_connection.html.markdown

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
* fix test case

* update test case
@mbfrahry
Copy link
Member

Closing in favor of #17986

@mbfrahry mbfrahry closed this Aug 12, 2022
@github-actions
Copy link

This functionality has been released in v3.19.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
@tombuildsstuff tombuildsstuff deleted the refactor/dns-to-go-azure-sdk branch March 10, 2023 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.