Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: role management policy resource #23295

Conversation

josh-barker
Copy link
Contributor

@josh-barker josh-barker commented Sep 18, 2023

This PR creates a new resource - role management policy, which allows you to manage the settings for PIM roles on Azure Resources.

Replaces #20496

@tombuildsstuff
Copy link
Contributor

hey @josh-barker

Chatting about this one internally / to give an update on this one - given that PIM spans both azuread and azurerm we're wanting to take a little time to evaluate this one more in-depth - @manicminer would be the person to look into that - but since this is waiting on design/thought I'm gonna add the thinking label to this one for the moment.

Thanks!

@josh-barker
Copy link
Contributor Author

Hey @tombuildsstuff , no worries. I added it in here as target is Azure resources and that's where the APIs are defined, but also understand from a consumer point of view PIM is a bit awkward if the resources are defined in azurerm and azuread.

Thanks for letting me know where things are up to. :)

@drdamour
Copy link
Contributor

i thinks this would fix #23458 & consequently #22766

regardless of where this goes (azurerm azuread or a 3rd PIM specific provider) the community is anxiously awaiting this functionality as the https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/pim_eligible_role_assignment is effectively dead in the water for the most common use case of just in time PIM

@srjennings
Copy link

Bump would really like eyes on this... are we still thinking on this? @tombuildsstuff

@ramonschopper
Copy link

ramonschopper commented May 2, 2024

Bump here as well - any news on the thinking process? This would enable properly make usage of PIM in an automated way. @tombuildsstuff

@haflidif
Copy link

haflidif commented May 3, 2024

+1 Another bump here any ETA or further thoughts on this feature? @tombuildsstuff , @manicminer

@manicminer
Copy link
Contributor

Hi @josh-barker, thanks for working on this and apologies for the delay in getting to this PR. I've looked through this and #25900 which duplicates this, and whilst I would normally defer to the earlier PR, #25900 is a bit more developed and also contains a matching data source. Therefore whilst I greatly appreciate your work on this, I'm going to close this for now in favor of #25900. Thank you again for your efforts on this PR.

@manicminer manicminer closed this May 9, 2024
@josh-barker
Copy link
Contributor Author

Hey @manicminer , no worries! Thanks for your explanation and it totally makes sense. Glad to see the feature get in!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
@github-actions github-actions bot added this to the v3.108.0 milestone Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants