-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: role management policy resource #23295
feat: role management policy resource #23295
Conversation
e238bc2
to
125c2ed
Compare
hey @josh-barker Chatting about this one internally / to give an update on this one - given that PIM spans both Thanks! |
Hey @tombuildsstuff , no worries. I added it in here as target is Azure resources and that's where the APIs are defined, but also understand from a consumer point of view PIM is a bit awkward if the resources are defined in Thanks for letting me know where things are up to. :) |
i thinks this would fix #23458 & consequently #22766 regardless of where this goes (azurerm azuread or a 3rd PIM specific provider) the community is anxiously awaiting this functionality as the https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/pim_eligible_role_assignment is effectively dead in the water for the most common use case of just in time PIM |
Bump would really like eyes on this... are we still thinking on this? @tombuildsstuff |
Bump here as well - any news on the thinking process? This would enable properly make usage of PIM in an automated way. @tombuildsstuff |
+1 Another bump here any ETA or further thoughts on this feature? @tombuildsstuff , @manicminer |
Hi @josh-barker, thanks for working on this and apologies for the delay in getting to this PR. I've looked through this and #25900 which duplicates this, and whilst I would normally defer to the earlier PR, #25900 is a bit more developed and also contains a matching data source. Therefore whilst I greatly appreciate your work on this, I'm going to close this for now in favor of #25900. Thank you again for your efforts on this PR. |
Hey @manicminer , no worries! Thanks for your explanation and it totally makes sense. Glad to see the feature get in! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR creates a new resource - role management policy, which allows you to manage the settings for PIM roles on Azure Resources.
Replaces #20496