-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_spring_cloud_container_deployment
- support for the application_performance_monitoring_resource_ids
property
#23862
Conversation
ms-henglu
commented
Nov 10, 2023
•
edited
Loading
edited
…ation_performance_monitoring_resource_ids` property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍
internal/services/springcloud/spring_cloud_container_deployment_resource.go
Outdated
Show resolved
Hide resolved
internal/services/springcloud/spring_cloud_container_deployment_resource.go
Outdated
Show resolved
Hide resolved
internal/services/springcloud/spring_cloud_container_deployment_resource.go
Outdated
Show resolved
Hide resolved
internal/services/springcloud/spring_cloud_container_deployment_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/springcloud/spring_cloud_container_deployment_resource_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-henglu. Overall this looks fine, but we should rename the property since by convention we don't specify resource
in property names that reference another resource's ID. We also shouldn't be ignoring malformed resource IDs returned by the API.
@@ -79,6 +81,16 @@ func resourceSpringCloudContainerDeployment() *pluginsdk.Resource { | |||
DiffSuppressFunc: pluginsdk.SuppressJsonDiff, | |||
}, | |||
|
|||
"application_performance_monitoring_resource_ids": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we're referencing the ids of other resources in the azurerm provider we don't specify resource. This should be renamed to
"application_performance_monitoring_resource_ids": { | |
"application_performance_monitoring_ids": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
log.Printf("[WARN] invalid APM ID %q: %+v", *v.ResourceID, err) | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be throwing an error here if the resource ID can't be parsed since this would indicate a problem in the API that the service team should fix.
If we silently log a warning and continue we would be allowing malformed resource ID's to creep into the state which will cause problems further down the line if user's try to use these for something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! I've updated this PR, please take another look, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-henglu and @magodo LGTM 👍
<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.81.0" to "3.82.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.82.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.82.0
FEATURES:

* New Data Source: `azurerm_monitor_workspace` ([#23928](hashicorp/terraform-provider-azurerm#23928 New Resource: `azurerm_application_load_balancer_subnet_association` ([#23628](https://github.com/hashicorp/terraform-provider-azurerm/issues/23628))

ENHANCEMENTS:

* dependencies: updating to `v0.20231117.1130141` of `github.com/hashicorp/go-azure-sdk` ([#23945](hashicorp/terraform-provider-azurerm#23945 `azurestackhci`: updating to API Version `2023-08-01` ([#23939](hashicorp/terraform-provider-azurerm#23939 `dashboard`: updating to API Version `2023-09-01` ([#23929](hashicorp/terraform-provider-azurerm#23929 `hpccache`: updating to API version `2023-05-01` ([#24005](hashicorp/terraform-provider-azurerm#24005 `mssql`: updating resources using `hashicorp/go-azure-sdk` to API Version `2023-02-01-preview` ([#23721](hashicorp/terraform-provider-azurerm#23721 `templatespecversions`: updating to API Version `2022-02-01` ([#24007](hashicorp/terraform-provider-azurerm#24007 Data Source: `azurerm_template_spec_version` - refactoring to use `hashicorp/go-azure-sdk` ([#24007](hashicorp/terraform-provider-azurerm#24007 `azurerm_cosmosdb_postgresql_cluster` - `coordinator_storage_quota_in_mb` and `coordinator_vcore_count` are no longer required for read replicas ([#23928](hashicorp/terraform-provider-azurerm#23928 `azurerm_dashboard_grafana` - `sku` can now be set to `Essential` ([#23934](hashicorp/terraform-provider-azurerm#23934 `azurerm_gallery_application_version` - add support for the `config_file`, `package_file` and `target_region.exclude_from_latest` properties ([#23816](hashicorp/terraform-provider-azurerm#23816 `azurerm_hdinsight_hadoop_cluster` - `script_actions` is no longer Force New ([#23888](hashicorp/terraform-provider-azurerm#23888 `azurerm_hdinsight_hbase_cluster` - `script_actions` is no longer Force New ([#23888](hashicorp/terraform-provider-azurerm#23888 `azurerm_hdinsight_interactive_query_cluster` - `script_actions` is no longer Force New ([#23888](hashicorp/terraform-provider-azurerm#23888 `azurerm_hdinsight_kafka_cluster` - `script_actions` is no longer Force New ([#23888](hashicorp/terraform-provider-azurerm#23888 `azurerm_hdinsight_spark_cluster` - `script_actions` is no longer Force New ([#23888](hashicorp/terraform-provider-azurerm#23888 `azurerm_kubernetes_cluster` - add support for the `gpu_instance` property ([#23887](hashicorp/terraform-provider-azurerm#23887 `azurerm_kubernetes_cluster_node_pool` - add support for the `gpu_instance` property ([#23887](hashicorp/terraform-provider-azurerm#23887 `azurerm_log_analytics_workspace` - add support for the `identity` property ([#23864](hashicorp/terraform-provider-azurerm#23864 `azurerm_linux_function_app` - add support for dotnet 8 ([#23638](hashicorp/terraform-provider-azurerm#23638 `azurerm_linux_function_app_slot` - add support for dotnet 8 ([#23638](hashicorp/terraform-provider-azurerm#23638 `azurerm_managed_lustre_file_system` - export attribute `mgs_address` ([#23942](hashicorp/terraform-provider-azurerm#23942 `azurerm_mssql_database` - support for Hyperscale SKUs ([#23974](hashicorp/terraform-provider-azurerm#23974 `azurerm_mssql_database` - refactoring to use `hashicorp/go-azure-sdk` ([#23721](hashicorp/terraform-provider-azurerm#23721 `azurerm_mssql_server` - refactoring to use `hashicorp/go-azure-sdk` ([#23721](hashicorp/terraform-provider-azurerm#23721 `azurerm_shared_image` - add support for `trusted_launch_supported` ([#23781](hashicorp/terraform-provider-azurerm#23781 `azurerm_spring_cloud_container_deployment` - add support for the `application_performance_monitoring_ids` property ([#23862](hashicorp/terraform-provider-azurerm#23862 `azurerm_spring_cloud_customized_accelerator` - add support for the `accelerator_type` and `path` properties ([#23797](hashicorp/terraform-provider-azurerm#23797 `azurerm_point_to_site_vpn_gateway` - allow multiple `connection_configurations` blocks ([#23936](hashicorp/terraform-provider-azurerm#23936 `azurerm_private_dns_cname_record` - `ttl` can now be set to 0 ([#23918](hashicorp/terraform-provider-azurerm#23918 `azurerm_windows_function_app` - add support for dotnet 8 ([#23638](hashicorp/terraform-provider-azurerm#23638 `azurerm_windows_function_app_slot` - add support for dotnet 8 ([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))

BUG FIXES:
* `azurerm_api_management` - correct a bug with additional location zones within the `additional_location` block ([#23943](hashicorp/terraform-provider-azurerm#23943 `azurerm_dev_test_linux_virtual_machine` - `storage_type` is now ForceNew to match the updated API behaviour ([#23973](hashicorp/terraform-provider-azurerm#23973 `azurerm_dev_test_windows_virtual_machine` - `storage_type` is now ForceNew to match the updated API behaviour ([#23973](hashicorp/terraform-provider-azurerm#23973 `azurerm_disk_encryption_set` - resource will recreate if `identity` changes from `SystemAssigned` to `UserAssigned` ([#23904](hashicorp/terraform-provider-azurerm#23904 `azurerm_eventhub_cluster`: `sku_name` is no longer ForceNew ([#24009](hashicorp/terraform-provider-azurerm#24009 `azurerm_firewall` - recasing the value for `firewall_policy_id` to workaround the API returning the incorrect casing ([#23993](hashicorp/terraform-provider-azurerm#23993 `azurerm_security_center_subscription_pricing` - fix a bug preventing removal of `extensions` and downgrading `tier` to `Free` ([#23821](hashicorp/terraform-provider-azurerm#23821 `azurerm_windows_web_app` - fix an issue of incorrect application stack settings during update ([#23372](https://github.com/hashicorp/terraform-provider-azurerm/issues/23372))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/896/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |