Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage and storage_cache - update tests for 4.0 #26909

Closed
wants to merge 2 commits into from

Conversation

catriona-m
Copy link
Member

No description provided.

@catriona-m catriona-m marked this pull request as draft August 1, 2024 16:30
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but one comment on one of the tests

storage_account_name = azurerm_storage_table_entity.test.storage_account_name
partition_key = azurerm_storage_table_entity.test.partition_key
row_key = azurerm_storage_table_entity.test.row_key
storage_table_name = azurerm_storage_table_entity.test.id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be storage_table_id

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! thank you!

@stephybun
Copy link
Member

Superseded by #26947 and #26949

@stephybun stephybun closed this Aug 9, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants