Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage - fix tests for 4.0 #26949

Merged
merged 3 commits into from
Aug 9, 2024
Merged

storage - fix tests for 4.0 #26949

merged 3 commits into from
Aug 9, 2024

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Aug 6, 2024

This test fixes up some more tests for storage and adds storage_table_id to the azurerm_storage_table_entity data source

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry. I think there are some tests that still need to be updated:

------- Stdout: -------
=== RUN   TestAccDataSourceStorageTableEntities_basic
=== PAUSE TestAccDataSourceStorageTableEntities_basic
=== CONT  TestAccDataSourceStorageTableEntities_basic
    testcase.go:121: Step 1/1 error: Error running pre-apply plan: exit status 1
        Error: Unsupported attribute
          on terraform_plugin_test.tf line 92, in data "azurerm_storage_table_entities" "test":
          92:   table_name           = azurerm_storage_table_entity.test.table_name
        This object has no argument, nested block, or exported attribute named
        "table_name".
        Error: Unsupported attribute
          on terraform_plugin_test.tf line 93, in data "azurerm_storage_table_entities" "test":
          93:   storage_account_name = azurerm_storage_table_entity.test.storage_account_name
        This object has no argument, nested block, or exported attribute named
        "storage_account_name".
--- FAIL: TestAccDataSourceStorageTableEntities_basic (3.80s)
FAIL
------- Stdout: -------
=== RUN   TestAccDataSourceStorageTableEntities_withSelector
=== PAUSE TestAccDataSourceStorageTableEntities_withSelector
=== CONT  TestAccDataSourceStorageTableEntities_withSelector
    testcase.go:121: Step 1/1 error: Error running pre-apply plan: exit status 1
        Error: Unsupported attribute
          on terraform_plugin_test.tf line 92, in data "azurerm_storage_table_entities" "test":
          92:   table_name           = azurerm_storage_table_entity.test.table_name
        This object has no argument, nested block, or exported attribute named
        "table_name".
        Error: Unsupported attribute
          on terraform_plugin_test.tf line 93, in data "azurerm_storage_table_entities" "test":
          93:   storage_account_name = azurerm_storage_table_entity.test.storage_account_name
        This object has no argument, nested block, or exported attribute named
        "storage_account_name".
--- FAIL: TestAccDataSourceStorageTableEntities_withSelector (3.84s)
FAIL

@mbfrahry
Copy link
Member Author

mbfrahry commented Aug 8, 2024

Good shout. I went ahead and added storage_table_id and all the FourPointOhBeta stuff to that data source

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry LGTM 👍

@stephybun stephybun merged commit d54b72a into main Aug 9, 2024
33 checks passed
@stephybun stephybun deleted the t-storage-4-1 branch August 9, 2024 09:44
@github-actions github-actions bot added this to the v3.116.0 milestone Aug 9, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants