-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage
- fix tests for 4.0
#26949
storage
- fix tests for 4.0
#26949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mbfrahry. I think there are some tests that still need to be updated:
------- Stdout: -------
=== RUN TestAccDataSourceStorageTableEntities_basic
=== PAUSE TestAccDataSourceStorageTableEntities_basic
=== CONT TestAccDataSourceStorageTableEntities_basic
testcase.go:121: Step 1/1 error: Error running pre-apply plan: exit status 1
Error: Unsupported attribute
on terraform_plugin_test.tf line 92, in data "azurerm_storage_table_entities" "test":
92: table_name = azurerm_storage_table_entity.test.table_name
This object has no argument, nested block, or exported attribute named
"table_name".
Error: Unsupported attribute
on terraform_plugin_test.tf line 93, in data "azurerm_storage_table_entities" "test":
93: storage_account_name = azurerm_storage_table_entity.test.storage_account_name
This object has no argument, nested block, or exported attribute named
"storage_account_name".
--- FAIL: TestAccDataSourceStorageTableEntities_basic (3.80s)
FAIL
------- Stdout: -------
=== RUN TestAccDataSourceStorageTableEntities_withSelector
=== PAUSE TestAccDataSourceStorageTableEntities_withSelector
=== CONT TestAccDataSourceStorageTableEntities_withSelector
testcase.go:121: Step 1/1 error: Error running pre-apply plan: exit status 1
Error: Unsupported attribute
on terraform_plugin_test.tf line 92, in data "azurerm_storage_table_entities" "test":
92: table_name = azurerm_storage_table_entity.test.table_name
This object has no argument, nested block, or exported attribute named
"table_name".
Error: Unsupported attribute
on terraform_plugin_test.tf line 93, in data "azurerm_storage_table_entities" "test":
93: storage_account_name = azurerm_storage_table_entity.test.storage_account_name
This object has no argument, nested block, or exported attribute named
"storage_account_name".
--- FAIL: TestAccDataSourceStorageTableEntities_withSelector (3.84s)
FAIL
Good shout. I went ahead and added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mbfrahry LGTM 👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This test fixes up some more tests for storage and adds
storage_table_id
to theazurerm_storage_table_entity
data source