Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_if_empty to google_compute_router_nat defaults #1617

Conversation

modular-magician
Copy link
Collaborator

More defaults I picked up during the same run as GoogleCloudPlatform/magic-modules#2943

Release Note Template for Downstream PRs (will be copied)

compute: fixed `google_compute_router_nat` timeout fields causing a diff when using a long-lived resource

Derived from GoogleCloudPlatform/magic-modules#2946

chrisst and others added 17 commits January 6, 2020 15:51
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Dana Hoffman <danahoffman@google.com>
…icorp#1586)

Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Dana Hoffman <danahoffman@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Riley Karson <rileykarson@google.com>
…p#1588)

Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: emily <emilyye@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Martin Nowak <code@dawg.eu>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: emily <emilyye@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: emily <emilyye@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Riley Karson <rileykarson@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
…#1613)

Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Riley Karson <rileykarson@google.com>
…#1615)

Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: emily <emilyye@google.com>
@modular-magician modular-magician merged commit fd6bf47 into hashicorp:downstream-master Jan 9, 2020
@modular-magician modular-magician deleted the downstream-pr-0b6ac1b6319e99c8a4d8f83ca8b53d02bc095e1d branch November 16, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants