Add monitoring service resource, datasource for app engine #1944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on API errors, only custom monitoring Service resources can be created manually.
This adds:
google_monitoring_custom_service
: the initial monitoring Service resource for custom services (which does very little other than register a service - the custom identifier block in the JSON resource is currently a "placeholder").datasource
google_monitoring_app_engine_service
for the automatically-created monitoring Service resources and a datasource constructor for use with the other types of services (seehttps://cloud.google.com/monitoring/api/ref_v3/rest/v3/services for identifier blocks, [WIP] Add more monitoring service data sources GoogleCloudPlatform/magic-modules#3344 for WIP other datasources that I can't test yet)
This is first in set of PRs. Next PRs will:
google_monitoring_cloud_endpoints_service
,google_monitoring_mesh_istio_service
, etc: This needs extra resources outside of GCP/monitoring to test, so I'm excluding them until I figure out how to get testing resources for them.Things to consider:
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3341