Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify max_instances to take API's result as default value #5134

Conversation

modular-magician
Copy link
Collaborator

hashicorp/terraform-provider-google#13543
GCF: modify max_instances field to take API's result as default value

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

GCF: modify max_instances field to take API's result as default value

Derived from GoogleCloudPlatform/magic-modules#7153

…#7153)

* Modify max_instances to take API's result as default value

* Update max_instances describtion for cloud function gen1

* Update mmv1/third_party/terraform/website/docs/d/cloudfunctions_function.html.markdown

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a4042d8 into hashicorp:main Jan 25, 2023
@modular-magician modular-magician deleted the downstream-pr-dfc9421eca9d1ea5d7209b1c3f0eb611511b5bef branch November 16, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant