Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Cloud Run (2nd gen)" is not an approved name, should be simply "Cloud Run" #13414

Closed
steren opened this issue Jan 7, 2023 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#7098, #13427, hashicorp/terraform-provider-google-beta#5063, GoogleCloudPlatform/terraform-validator#1263 or GoogleCloudPlatform/magic-modules#7104
Closed

"Cloud Run (2nd gen)" is not an approved name, should be simply "Cloud Run" #13414

steren opened this issue Jan 7, 2023 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#7098, #13427, hashicorp/terraform-provider-google-beta#5063, GoogleCloudPlatform/terraform-validator#1263 or GoogleCloudPlatform/magic-modules#7104
Assignees
@steren
Labels
bug

Comments

@steren
Copy link

steren commented Jan 7, 2023

In the left nav of the official terraform docs, I can see two categories:

  • Cloud Run
  • Cloud Run (2nd gen)

image

I am not sure where "Cloud Run (2nd gen)" comes from, but it is not a name that is used anywhere else or even approved by Google Cloud branding.

The v2 of Cloud Run Terraform resources (google_cloud_run_v2_service and google_cloud_run_v2_job should go under the Cloud Run category.
@steren steren added the bug label Jan 7, 2023
steren added a commit to steren/terraform-provider-google that referenced this issue Jan 7, 2023
@steren
Use "Cloud Run" instead of "Cloud Run (2nd gen)"
798374a 
Fix hashicorp#13414
@steren steren mentioned this issue Jan 7, 2023
Closed
steren added a commit to steren/magic-modules that referenced this issue Jan 9, 2023
@steren
Use "Cloud Run" instead of "Cloud Run (2nd gen)"
dae435e 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415
@steren steren mentioned this issue Jan 9, 2023
Merged
slevenick pushed a commit to GoogleCloudPlatform/magic-modules that referenced this issue Jan 10, 2023
@steren
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098)
994f50f 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (hashicorp#7098)
efb74c5 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (hashicorp#7098)
33f1ff1 
Fix hashicorp#13414

Same PR as hashicorp#13415

Signed-off-by: Modular Magician <magic-modules@google.com>
This was referenced Jan 10, 2023
Merged
Merged
modular-magician added a commit that referenced this issue Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098) (#13427)
5d96319 
Fix #13414

Same PR as #13415

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098) (#5063)
5b86d14 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-validator that referenced this issue Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098)
c7999e0 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician mentioned this issue Jan 10, 2023
Merged
modular-magician added a commit to GoogleCloudPlatform/terraform-validator that referenced this issue Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098) (#1263)
b31e1d1 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@rileykarson rileykarson mentioned this issue Jan 10, 2023
Merged
5 tasks
This was referenced Jan 10, 2023
Merged
Merged
Merged
i-laird pushed a commit to i-laird/magic-modules that referenced this issue Jan 10, 2023
@steren @i-laird
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (GoogleCloudPlatform…
f3fbb1b 
…#7098)

Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@steren steren

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use "Cloud Run" instead of "Cloud Run (2nd gen)" steren/magic-modules
Use "Cloud Run" instead of "Cloud Run (2nd gen)" modular-magician/terraform-provider-google
Use "Cloud Run" instead of "Cloud Run (2nd gen)" modular-magician/terraform-provider-google-beta
Use "Cloud Run" instead of "Cloud Run (2nd gen)" modular-magician/terraform-validator
Relabel Cloud Run v2 as "v2 API" over "2nd gen" GoogleCloudPlatform/magic-modules
Relabel Cloud Run v2 as "v2 API" over "2nd gen" modular-magician/terraform-provider-google-beta
Relabel Cloud Run v2 as "v2 API" over "2nd gen" modular-magician/terraform-provider-google
Relabel Cloud Run v2 as "v2 API" over "2nd gen" modular-magician/terraform-validator
Use "Cloud Run" instead of "Cloud Run (2nd gen)" steren/terraform-provider-google
1 participant
@steren