Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "Cloud Run" instead of "Cloud Run (2nd gen)" #13415

Closed
wants to merge 1 commit into from
Closed

Use "Cloud Run" instead of "Cloud Run (2nd gen)" #13415

wants to merge 1 commit into from

Conversation

steren
Copy link

@steren steren commented Jan 7, 2023

Fix #13414

@github-actions
Copy link

github-actions bot commented Jan 7, 2023

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@github-actions github-actions bot requested a review from melinath January 7, 2023 18:26
steren added a commit to steren/magic-modules that referenced this pull request Jan 9, 2023
@steren
Use "Cloud Run" instead of "Cloud Run (2nd gen)"
dae435e 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415
@steren steren mentioned this pull request Jan 9, 2023
Merged
melinath
melinath requested changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subcategory needs to include the fact that this resource uses the v2 API, but it doesn't need to use the phrasing "2nd gen" since this is not in fact a completely different product in this case.

slevenick pushed a commit to GoogleCloudPlatform/magic-modules that referenced this pull request Jan 10, 2023
@steren
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098)
994f50f 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (hashicorp#7098)
efb74c5 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (hashicorp#7098)
33f1ff1 
Fix hashicorp#13414

Same PR as hashicorp#13415

Signed-off-by: Modular Magician <magic-modules@google.com>
This was referenced Jan 10, 2023
Merged
Merged
modular-magician added a commit that referenced this pull request Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098) (#13427)
5d96319 
Fix #13414

Same PR as #13415

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this pull request Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098) (#5063)
5b86d14 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-validator that referenced this pull request Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098)
c7999e0 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician mentioned this pull request Jan 10, 2023
Merged
modular-magician added a commit to GoogleCloudPlatform/terraform-validator that referenced this pull request Jan 10, 2023
@modular-magician
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (#7098) (#1263)
b31e1d1 
Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@steren
Copy link
Author

steren commented Jan 10, 2023

GoogleCloudPlatform/magic-modules#7098 went in.

If further changes are required, please follow up.

@steren steren closed this Jan 10, 2023
i-laird pushed a commit to i-laird/magic-modules that referenced this pull request Jan 10, 2023
@steren @i-laird
Use "Cloud Run" instead of "Cloud Run (2nd gen)" (GoogleCloudPlatform…
f3fbb1b 
…#7098)

Fix hashicorp/terraform-provider-google#13414

Same PR as hashicorp/terraform-provider-google#13415
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@melinath melinath melinath requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Cloud Run (2nd gen)" is not an approved name, should be simply "Cloud Run"
2 participants
@steren @melinath