Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the name field to google_storage_transfer_job #15220

Comments

@lorenzofelletti
Copy link

lorenzofelletti commented Jul 19, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

On the Cloud Console, when creating a Storage Transfer Job, it is possible to set a job name of choice, instead of the randomly generated one. It would be nice to have the same possibility on Terraform too, so to be able to create Jobs with a meaningful name. Otherwise, all the storage transfer jobs created by Terraform will have meaningless name.

I know it is already possible to set a custom description of the job, but by having the possibility to choose a short meaning ful name it would make it easier to quickly recognize a job among the others, which may not always be easy (especially in case one have a lot of jobs).

New or Affected Resource(s)

  • google_storage_transfer_job

Potential Terraform Configuration

resource "google_storage_transfer_job" "job_to_patch" {
  name = "beautiful-short-name" # name or job_name would be good names imho
  description = "A really informative description"
  project     = var.project_id

  transfer_spec {
    # ...
  }
}

References

b/302672796

@rileykarson rileykarson added this to the Goals milestone Jul 24, 2023
@github-actions github-actions bot added service/storage forward/review In review; remove label to forward labels Sep 11, 2023
@trodge trodge removed the forward/review In review; remove label to forward label Sep 12, 2023
@SarahFrench
Copy link
Member

Adding some extra context to this request:

Because this resource is handwritten this work would require:

mohsenmottaghi added a commit to mohsenmottaghi/google-cloud-magic-modules that referenced this issue Dec 14, 2023
Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
mohsenmottaghi added a commit to mohsenmottaghi/google-cloud-magic-modules that referenced this issue Dec 17, 2023
Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
mohsenmottaghi added a commit to mohsenmottaghi/google-cloud-magic-modules that referenced this issue Dec 17, 2023
Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

UPDATE make transferJobs name field optional

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
mohsenmottaghi added a commit to mohsenmottaghi/google-cloud-magic-modules that referenced this issue Dec 17, 2023
Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
mohsenmottaghi added a commit to mohsenmottaghi/google-cloud-magic-modules that referenced this issue Dec 17, 2023
This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
mohsenmottaghi added a commit to mohsenmottaghi/google-cloud-magic-modules that referenced this issue Dec 19, 2023
This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
zli82016 pushed a commit to GoogleCloudPlatform/magic-modules that referenced this issue Dec 19, 2023
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

* Update transferJobs document of name field

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

---------

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Dec 19, 2023
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

* Update transferJobs document of name field

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

---------

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
[upstream:f86454beb4ace8575ab532a3e59597ddd4758936]
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Dec 19, 2023
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

* Update transferJobs document of name field

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

---------

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
[upstream:f86454beb4ace8575ab532a3e59597ddd4758936]
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Dec 19, 2023
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220



* Update transferJobs document of name field



---------


[upstream:f86454beb4ace8575ab532a3e59597ddd4758936]

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Dec 19, 2023
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes #15220



* Update transferJobs document of name field



---------


[upstream:f86454beb4ace8575ab532a3e59597ddd4758936]

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-google-conversion that referenced this issue Dec 19, 2023
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

* Update transferJobs document of name field

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

---------

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
[upstream:f86454beb4ace8575ab532a3e59597ddd4758936]
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to GoogleCloudPlatform/terraform-google-conversion that referenced this issue Dec 19, 2023
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220



* Update transferJobs document of name field



---------


[upstream:f86454beb4ace8575ab532a3e59597ddd4758936]

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
kapreus pushed a commit to kapreus/magic-modules that referenced this issue Jan 2, 2024
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

* Update transferJobs document of name field

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

---------

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this issue May 2, 2024
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

* Update transferJobs document of name field

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

---------

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
pengq-google pushed a commit to pengq-google/magic-modules that referenced this issue May 21, 2024
* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp/terraform-provider-google#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

* Update transferJobs document of name field

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

---------

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.