Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make transferJobs name field optional #16838

Conversation

modular-magician
Copy link
Collaborator

Fix #15220

This PR tries to make the name field of transferJobs service optional to be able to have customized names for storage transfer jobs.

Release Note Template for Downstream PRs (will be copied)

storagetransfer: made `name` field to be optional in resource `google_storage_transfer_job` so it can be provided by the users

Derived from GoogleCloudPlatform/magic-modules#9641

* Update make transferJobs name field optional

This commit makes transferJobs name optional + new test `TestAccStorageTransferJob_transferJobName` to testing changes.

Fixes hashicorp#15220

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

* Update transferJobs document of name field

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>

---------

Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
[upstream:f86454beb4ace8575ab532a3e59597ddd4758936]
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 49660fb into hashicorp:main Dec 19, 2023
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the name field to google_storage_transfer_job
1 participant