Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move billing tests that require permissions beyond Billing User to master billing account #13692

Conversation

modular-magician
Copy link
Collaborator

This is being done as a result of the upcoming changes to our billing setup. We intend to have the primary, chargeable billing account only give limited permissions to our test runner, so to perform tests that require a higher level of permission (like making changes), we will need to use a separate billing account that does not get charged.

The best option would be to repurpose the master billing account for these tests, so we are attempting that with this change, and the tests will verify if they can succeed with this configuration.

Related tests that we hope will succeed with the master billing account:

  • TestAccBillingBudget_billingBudgetBasicExample
  • TestAccBillingBudget_billingBudgetLastperiodExample
  • TestAccBillingBudget_billingBudgetFilterExample
  • TestAccBillingBudget_billingBudgetNotifyExample
  • TestAccBillingBudget_billingBudgetCustomperiodExample
  • TestAccBillingBudget_billingBudgetCurrencycode
  • TestAccBillingBudget_billingBudgetOptionalExample
  • TestAccBillingBudget_billingBudgetUpdate
  • TestAccBillingBudget_budgetFilterProjectsOrdering
  • TestAccBillingAccountIam
  • TestAccLoggingBillingAccountSink_updateBigquerySink (not included here because it currently has an unrelated error)

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7263

…ster billing account (hashicorp#7263)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a688e85 into hashicorp:main Feb 9, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
@modular-magician modular-magician deleted the downstream-pr-9c20589deef87a876509d0839bd5639fbdd7bfde branch November 16, 2024 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant