-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move billing tests that require permissions beyond Billing User to master billing account #7263
Conversation
…ster billing account
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 10 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeRouterNat_update|TestAccBillingBudget_billingBudgetOptionalExample|TestAccBillingBudget_billingBudgetCustomperiodExample|TestAccBillingBudget_budgetFilterProjectsOrdering|TestAccBillingBudget_billingBudgetNotifyExample|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingBudgetUpdate|TestAccBillingBudget_billingBudgetLastperiodExample|TestAccBillingBudget_billingBudgetBasicExample|TestAccBillingBudget_billingBudgetCurrencycode|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDnsRecordSet_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
…ster billing account (GoogleCloudPlatform#7263)
…ster billing account (GoogleCloudPlatform#7263)
This is being done as a result of the upcoming changes to our billing setup. We intend to have the primary, chargeable billing account only give limited permissions to our test runner, so to perform tests that require a higher level of permission (like making changes), we will need to use a separate billing account that does not get charged.
The best option would be to repurpose the master billing account for these tests, so we are attempting that with this change, and the tests will verify if they can succeed with this configuration.
Related tests that we hope will succeed with the master billing account:
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)