Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move billing tests that require permissions beyond Billing User to master billing account #7263

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Feb 9, 2023

This is being done as a result of the upcoming changes to our billing setup. We intend to have the primary, chargeable billing account only give limited permissions to our test runner, so to perform tests that require a higher level of permission (like making changes), we will need to use a separate billing account that does not get charged.

The best option would be to repurpose the master billing account for these tests, so we are attempting that with this change, and the tests will verify if they can succeed with this configuration.

Related tests that we hope will succeed with the master billing account:

  • TestAccBillingBudget_billingBudgetBasicExample
  • TestAccBillingBudget_billingBudgetLastperiodExample
  • TestAccBillingBudget_billingBudgetFilterExample
  • TestAccBillingBudget_billingBudgetNotifyExample
  • TestAccBillingBudget_billingBudgetCustomperiodExample
  • TestAccBillingBudget_billingBudgetCurrencycode
  • TestAccBillingBudget_billingBudgetOptionalExample
  • TestAccBillingBudget_billingBudgetUpdate
  • TestAccBillingBudget_budgetFilterProjectsOrdering
  • TestAccBillingAccountIam
  • TestAccLoggingBillingAccountSink_updateBigquerySink (not included here because it currently has an unrelated error)

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 10 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2466
Passed tests 2196
Skipped tests: 256
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRouterNat_update|TestAccBillingBudget_billingBudgetOptionalExample|TestAccBillingBudget_billingBudgetCustomperiodExample|TestAccBillingBudget_budgetFilterProjectsOrdering|TestAccBillingBudget_billingBudgetNotifyExample|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingBudgetUpdate|TestAccBillingBudget_billingBudgetLastperiodExample|TestAccBillingBudget_billingBudgetBasicExample|TestAccBillingBudget_billingBudgetCurrencycode|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDnsRecordSet_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRouterNat_update[Debug log]
TestAccBillingBudget_billingBudgetOptionalExample[Debug log]
TestAccBillingBudget_billingBudgetCustomperiodExample[Debug log]
TestAccBillingBudget_budgetFilterProjectsOrdering[Debug log]
TestAccBillingBudget_billingBudgetNotifyExample[Debug log]
TestAccBillingBudget_billingBudgetFilterExample[Debug log]
TestAccBillingBudget_billingBudgetUpdate[Debug log]
TestAccBillingBudget_billingBudgetLastperiodExample[Debug log]
TestAccBillingBudget_billingBudgetBasicExample[Debug log]
TestAccBillingBudget_billingBudgetCurrencycode[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@roaks3 roaks3 requested review from a team and c2thorn and removed request for a team February 9, 2023 18:53
@roaks3 roaks3 merged commit 9c20589 into main Feb 9, 2023
@roaks3 roaks3 deleted the move-billing-tests-to-master branch February 9, 2023 19:52
kubalaguna pushed a commit to kubalaguna/magic-modules that referenced this pull request Feb 27, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants