Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more billing tests that require permissions beyond Billing User to master billing account #13834

Conversation

modular-magician
Copy link
Collaborator

These were missed in GoogleCloudPlatform/magic-modules#7263 and GoogleCloudPlatform/magic-modules#7337. In short, the tests fail with a billing account that only has Billing User permissions, so we need to move them to using the "master" account. Hopefully this is the last set of these changes.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7344

…to master billing account (hashicorp#7344)

* Move more billing tests that require permissions beyond Billing User to master billing account

* Add comments to clarify billing account usage

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b1e5b52 into hashicorp:main Feb 24, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
@modular-magician modular-magician deleted the downstream-pr-aa8f976d370e9697c9b06d4086afeb0bd1fa6a0f branch November 17, 2024 01:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant