Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logging-related billing tests to master billing account #7337

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Feb 22, 2023

Follow-up to #7263

For these logging-related billing tests, the user needs to have permissions beyond Billing User, so we will attempt to use the master billing account instead.

logging.sinks.create:

  • TestAccLoggingBillingAccountSink_basic
  • TestAccLoggingBillingAccountSink_update
  • TestAccLoggingBillingAccountSink_described
  • TestAccLoggingBillingAccountSink_disabled
  • TestAccLoggingBillingAccountSink_updateBigquerySink
  • TestAccLoggingBillingAccountSink_heredoc

logging.exclusions.create:

  • TestAccLoggingBillingAccountExclusion

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@roaks3 roaks3 requested a review from a team as a code owner February 22, 2023 15:53
@roaks3 roaks3 requested review from ScottSuarez, a team and shuyama1 and removed request for a team and ScottSuarez February 22, 2023 15:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2462
Passed tests 2198
Skipped tests: 255
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_heredoc|TestAccLoggingBillingAccountSink_updateBigquerySink|TestAccLoggingBillingAccountSink_disabled|TestAccLoggingBillingAccountSink_described|TestAccLoggingBillingAccountSink_basic|TestAccLoggingBillingAccountExclusion

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccLoggingBillingAccountSink_update[Error message] [Debug log]
TestAccLoggingBillingAccountSink_heredoc[Error message] [Debug log]
TestAccLoggingBillingAccountSink_updateBigquerySink[Error message] [Debug log]
TestAccLoggingBillingAccountSink_disabled[Error message] [Debug log]
TestAccLoggingBillingAccountSink_described[Error message] [Debug log]
TestAccLoggingBillingAccountSink_basic[Error message] [Debug log]
TestAccLoggingBillingAccountExclusion[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@roaks3
Copy link
Contributor Author

roaks3 commented Feb 22, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2462
Passed tests 2200
Skipped tests: 255
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBillingAccountSink_heredoc|TestAccLoggingBillingAccountSink_updateBigquerySink|TestAccLoggingBillingAccountSink_disabled|TestAccLoggingBillingAccountSink_described|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_basic|TestAccLoggingBillingAccountExclusion

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBillingAccountSink_heredoc[Debug log]
TestAccLoggingBillingAccountSink_updateBigquerySink[Debug log]
TestAccLoggingBillingAccountSink_disabled[Debug log]
TestAccLoggingBillingAccountSink_described[Debug log]
TestAccLoggingBillingAccountSink_update[Debug log]
TestAccLoggingBillingAccountSink_basic[Debug log]
TestAccLoggingBillingAccountExclusion[Debug log]

All tests passed
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants