-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move logging-related billing tests to master billing account #7337
Conversation
…lling User to master billing account
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_heredoc|TestAccLoggingBillingAccountSink_updateBigquerySink|TestAccLoggingBillingAccountSink_disabled|TestAccLoggingBillingAccountSink_described|TestAccLoggingBillingAccountSink_basic|TestAccLoggingBillingAccountExclusion |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBillingAccountSink_heredoc|TestAccLoggingBillingAccountSink_updateBigquerySink|TestAccLoggingBillingAccountSink_disabled|TestAccLoggingBillingAccountSink_described|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_basic|TestAccLoggingBillingAccountExclusion |
Tests passed during RECORDING mode: All tests passed |
…lling User to master billing account (GoogleCloudPlatform#7337)
…lling User to master billing account (GoogleCloudPlatform#7337)
Follow-up to #7263
For these logging-related billing tests, the user needs to have permissions beyond Billing User, so we will attempt to use the master billing account instead.
logging.sinks.create
:logging.exclusions.create
:If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)