Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more billing tests that require permissions beyond Billing User to master billing account #7344

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Feb 23, 2023

These were missed in #7263 and #7337. In short, the tests fail with a billing account that only has Billing User permissions, so we need to move them to using the "master" account. Hopefully this is the last set of these changes.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@roaks3 roaks3 requested a review from a team as a code owner February 23, 2023 21:00
@roaks3 roaks3 requested review from zli82016 and removed request for a team February 23, 2023 21:00
@zli82016
Copy link
Member

/gcbrun

@zli82016
Copy link
Member

Hello, @roaks3 , can you please rebase the main branch to include the fix #7346? Thanks.

@roaks3
Copy link
Contributor Author

roaks3 commented Feb 24, 2023

Ah, thanks for that, will do!

@roaks3 roaks3 force-pushed the move-more-billing-tests-to-master branch from 4a71ac9 to 0f92e94 Compare February 24, 2023 00:12
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 14 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 14 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2463
Passed tests 2203
Skipped tests: 255
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleBillingAccount_byFullNameClosed|TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigBillingAccount_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataSourceGoogleBillingAccount_byFullName[Debug log]
TestAccDataSourceGoogleBillingAccount_byShortName[Debug log]
TestAccDataSourceGoogleBillingAccount_byFullNameClosed[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccLoggingBucketConfigBillingAccount_basic[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit aa8f976 into main Feb 24, 2023
kubalaguna pushed a commit to kubalaguna/magic-modules that referenced this pull request Feb 27, 2023
…to master billing account (GoogleCloudPlatform#7344)

* Move more billing tests that require permissions beyond Billing User to master billing account

* Add comments to clarify billing account usage
mdtro pushed a commit to mdtro/magic-modules that referenced this pull request Mar 2, 2023
…to master billing account (GoogleCloudPlatform#7344)

* Move more billing tests that require permissions beyond Billing User to master billing account

* Add comments to clarify billing account usage
anuhyapolisetti pushed a commit to anuhyapolisetti/magic-modules that referenced this pull request Mar 16, 2023
* main: (41 commits)
  update the test cases to resolve resourcename not found error
  Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987)
  Upgrade DCL to v1.34 (GoogleCloudPlatform#7276)
  Add max_distance field to group placement policy (GoogleCloudPlatform#7354)
  Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316)
  Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310)
  datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989)
  Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127)
  Split resources in "B" products (GoogleCloudPlatform#7350)
  force recreate on master_config.num_instances (GoogleCloudPlatform#7349)
  Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343)
  remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347)
  Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344)
  Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345)
  Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017)
  Add missing `type` argument to data source docs (GoogleCloudPlatform#7341)
  Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346)
  Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339)
  feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283)
  fixed virtual field update issues (GoogleCloudPlatform#7318)
  ...
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…to master billing account (GoogleCloudPlatform#7344)

* Move more billing tests that require permissions beyond Billing User to master billing account

* Add comments to clarify billing account usage
@roaks3 roaks3 deleted the move-more-billing-tests-to-master branch July 24, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants