Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed virtual field update issues #7318

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Feb 17, 2023

Fixes hashicorp/terraform-provider-google#13749

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

spanner: fixed the error when updating `deletion_protection` on `google_spanner_database` 
spanner: fixed the error when updating `force_destroy` on `google_spanner_instance`

@edwardmedia edwardmedia requested a review from a team as a code owner February 17, 2023 18:39
@edwardmedia edwardmedia requested review from melinath and removed request for a team February 17, 2023 18:39
@edwardmedia edwardmedia changed the title fixed virtual field upadte issues fixed virtual field update issues Feb 17, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 47 insertions(+))
Terraform Beta: Diff ( 2 files changed, 47 insertions(+))
TF Validator: Diff ( 4 files changed, 33 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2467
Passed tests 2211
Skipped tests: 256
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

@melinath melinath self-assigned this Feb 21, 2023
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes requested below. Also, I was wondering: why is this necessary for these resources but not for other resources with virtual fields? (Or is it necessary for all similar resources?)

mmv1/products/spanner/terraform.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 49 insertions(+))
Terraform Beta: Diff ( 2 files changed, 49 insertions(+))
TF Validator: Diff ( 4 files changed, 35 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2462
Passed tests 2206
Skipped tests: 255
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@edwardmedia
Copy link
Contributor Author

edwardmedia commented Feb 21, 2023

@melinath to answer your general question above, potentially this could be an issue for all virtual fields. I have already seen another reported issue that is the same reason. Some APIs may not return error like this.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - alternately this could be implemented in a way that fixes it for all virtual fields; I think moving forward with this fix for now is reasonable but could you open a ticket for the larger fix?

@edwardmedia edwardmedia merged commit f06bd24 into GoogleCloudPlatform:main Feb 23, 2023
kubalaguna pushed a commit to kubalaguna/magic-modules that referenced this pull request Feb 27, 2023
* fixed virtual field upadte issues

* update funcs

---------

Co-authored-by: Edward Sun <sunedward@google.com>
@edwardmedia edwardmedia mentioned this pull request Mar 8, 2023
5 tasks
anuhyapolisetti pushed a commit to anuhyapolisetti/magic-modules that referenced this pull request Mar 16, 2023
* main: (41 commits)
  update the test cases to resolve resourcename not found error
  Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987)
  Upgrade DCL to v1.34 (GoogleCloudPlatform#7276)
  Add max_distance field to group placement policy (GoogleCloudPlatform#7354)
  Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316)
  Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310)
  datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989)
  Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127)
  Split resources in "B" products (GoogleCloudPlatform#7350)
  force recreate on master_config.num_instances (GoogleCloudPlatform#7349)
  Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343)
  remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347)
  Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344)
  Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345)
  Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017)
  Add missing `type` argument to data source docs (GoogleCloudPlatform#7341)
  Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346)
  Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339)
  feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283)
  fixed virtual field update issues (GoogleCloudPlatform#7318)
  ...
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* fixed virtual field upadte issues

* update funcs

---------

Co-authored-by: Edward Sun <sunedward@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanner instance not updated properly when changing only the force destroy
3 participants