Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force recreate on master_config.num_instances #7349

Merged
merged 1 commit into from
Feb 24, 2023
Merged

force recreate on master_config.num_instances #7349

merged 1 commit into from
Feb 24, 2023

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Feb 24, 2023 •
edited
Loading

closes hashicorp/terraform-provider-google#11948 (comment)

According to https://cloud.google.com/dataproc/docs/reference/rest/v1/projects.regions.clusters/patch
master_config.num_instances is not updatable, but worker_config.num_instances is. added logic to differentiate the two and force recreation on master_config

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataproc: fixed an issue where `master_config.num_instances` would not force recreation when changed in `google_dataproc_cluster`

@c2thorn c2thorn requested a review from a team as a code owner February 24, 2023 18:45
@c2thorn c2thorn requested review from hao-nan-li and removed request for a team February 24, 2023 18:45
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 3 insertions(+))
Terraform Beta: Diff ( 1 file changed, 3 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2473
Passed tests 2217
Skipped tests: 255
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Debug log]

All tests passed
View the build log or the debug log for each test

hao-nan-li
hao-nan-li approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c2thorn c2thorn merged commit 7d40ac5 into GoogleCloudPlatform:main Feb 24, 2023
This was referenced Feb 24, 2023
Merged
Merged
kubalaguna pushed a commit to kubalaguna/magic-modules that referenced this pull request Feb 27, 2023
@c2thorn @kubalaguna
force recreate on master_config.num_instances (GoogleCloudPlatform#7349)
b0e3135
mdtro pushed a commit to mdtro/magic-modules that referenced this pull request Mar 2, 2023
@c2thorn @mdtro
force recreate on master_config.num_instances (GoogleCloudPlatform#7349)
2b6bece
anuhyapolisetti pushed a commit to anuhyapolisetti/magic-modules that referenced this pull request Mar 16, 2023
Merge branch 'main' into new-resource/apigee-aliases
7ea5ce5 
* main: (41 commits)
  update the test cases to resolve resourcename not found error
  Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987)
  Upgrade DCL to v1.34 (GoogleCloudPlatform#7276)
  Add max_distance field to group placement policy (GoogleCloudPlatform#7354)
  Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316)
  Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310)
  datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989)
  Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127)
  Split resources in "B" products (GoogleCloudPlatform#7350)
  force recreate on master_config.num_instances (GoogleCloudPlatform#7349)
  Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343)
  remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347)
  Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344)
  Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345)
  Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017)
  Add missing `type` argument to data source docs (GoogleCloudPlatform#7341)
  Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346)
  Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339)
  feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283)
  fixed virtual field update issues (GoogleCloudPlatform#7318)
  ...
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
@c2thorn @ericayyliu
force recreate on master_config.num_instances (GoogleCloudPlatform#7349)
b8818cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hao-nan-li hao-nan-li hao-nan-li approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataproc HA to Non HA change doesnt rebuild cluster
3 participants
@c2thorn @modular-magician @hao-nan-li