Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove artifact repository beta URL, fixup handwritten tests #7345

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Feb 23, 2023

Fixes b/270298939

Seems like this service declined to update its beta API, meaning the invariant that beta APIs are a superset of GAs is broken. The test configuration here succeeds on the GA provider but fails on the beta one:

│ Error: Error creating Repository: googleapi: Error 400: Invalid value at 'repository.format' (type.googleapis.com/google.devtools.artifactregistry.v1beta2.Repository.Format), "KFP"
│ Details:
│ [
│   {
│     "@type": "type.googleapis.com/google.rpc.BadRequest",
│     "fieldViolations": [
│       {
│         "description": "Invalid value at 'repository.format' (type.googleapis.com/google.devtools.artifactregistry.v1beta2.Repository.Format), \"KFP\"",
│         "field": "repository.format"
│       }
│     ]
│   }
│ ]
│
│   on main.tf line 1, in resource "google_artifact_registry_repository" "my-repo":
│    1: resource "google_artifact_registry_repository" "my-repo" {

Also rename some tests to match standard format, un-guard the handwritten test file.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

artifactregistry: fixed an issue where `google-beta` used an outdated beta API rather than the GA service API. New format values like "KFP" will now be accepted by both providers.

@rileykarson rileykarson requested a review from a team as a code owner February 23, 2023 22:14
@rileykarson rileykarson requested review from slevenick and removed request for a team February 23, 2023 22:14
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing TFV build, may need a rebase?

@rileykarson
Copy link
Member Author

Yeah, had to pull in #7346

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 160 insertions(+))
Terraform Beta: Diff ( 3 files changed, 44 insertions(+), 17 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2464
Passed tests 2194
Skipped tests: 255
Failed tests: 15

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccCloudFunctionsFunction_cmek|TestAccCloudFunctionsFunction_dockerRepository|TestAccComputeForwardingRule_update|TestAccCloudFunctionsFunction_update|TestAccArtifactRegistryRepository_artifactRegistryRepositoryBasicExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryCmekExample|TestAccArtifactRegistryRepositoryIamPolicyGenerated|TestAccArtifactRegistryRepositoryIamMemberGenerated|TestAccArtifactRegistryRepositoryIamBindingGenerated|TestAccArtifactRegistryRepository_createMvnSnapshot|TestAccArtifactRegistryRepository_createMvnRelease|TestAccArtifactRegistryRepository_kfp|TestAccArtifactRegistryRepository_update|TestAccDataSourceGoogleArtifactRegistryRepositoryConfig

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudFunctionsFunction_dockerRepository[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccCloudFunctionsFunction_update[Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryBasicExample[Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCmekExample[Debug log]
TestAccArtifactRegistryRepositoryIamPolicyGenerated[Debug log]
TestAccArtifactRegistryRepositoryIamMemberGenerated[Debug log]
TestAccArtifactRegistryRepositoryIamBindingGenerated[Debug log]
TestAccArtifactRegistryRepository_createMvnSnapshot[Debug log]
TestAccArtifactRegistryRepository_createMvnRelease[Debug log]
TestAccArtifactRegistryRepository_update[Debug log]
TestAccDataSourceGoogleArtifactRegistryRepositoryConfig[Debug log]

Tests failed during RECORDING mode:
TestAccCloudFunctionsFunction_cmek[Error message] [Debug log]
TestAccArtifactRegistryRepository_kfp[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 160 insertions(+))
Terraform Beta: Diff ( 3 files changed, 44 insertions(+), 17 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2464
Passed tests 2207
Skipped tests: 255
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccCloudFunctionsFunction_cmek|TestAccArtifactRegistryRepository_kfp

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccCloudFunctionsFunction_cmek[Debug log]
TestAccArtifactRegistryRepository_kfp[Debug log]

All tests passed
View the build log or the debug log for each test

@slevenick slevenick self-requested a review February 24, 2023 17:08
@rileykarson rileykarson merged commit c81fb45 into GoogleCloudPlatform:main Feb 24, 2023
kubalaguna pushed a commit to kubalaguna/magic-modules that referenced this pull request Feb 27, 2023
mdtro pushed a commit to mdtro/magic-modules that referenced this pull request Mar 2, 2023
anuhyapolisetti pushed a commit to anuhyapolisetti/magic-modules that referenced this pull request Mar 16, 2023
* main: (41 commits)
  update the test cases to resolve resourcename not found error
  Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987)
  Upgrade DCL to v1.34 (GoogleCloudPlatform#7276)
  Add max_distance field to group placement policy (GoogleCloudPlatform#7354)
  Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316)
  Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310)
  datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989)
  Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127)
  Split resources in "B" products (GoogleCloudPlatform#7350)
  force recreate on master_config.num_instances (GoogleCloudPlatform#7349)
  Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343)
  remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347)
  Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344)
  Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345)
  Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017)
  Add missing `type` argument to data source docs (GoogleCloudPlatform#7341)
  Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346)
  Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339)
  feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283)
  fixed virtual field update issues (GoogleCloudPlatform#7318)
  ...
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants