Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for auto and deprecated automatic field in google_secret_manager_secret resource #15793

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Added support for auto and deprecated automatic field in google_secret_manager_secret resource #15793

merged 1 commit into from
Sep 11, 2023

Conversation

modular-magician
Copy link
Collaborator

Added support for the auto field and deprecated automatic field in the google_secret_manager_secret resource
fixes #10679
fixes #9272
fixes #14282

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

secretmanager: added `auto` field to `google_secret_manager_secret` resource

secretmanager: deprecated `automatic` field on `google_secret_manager_secret`. Use `auto` instead.

Derived from GoogleCloudPlatform/magic-modules#8838

@modular-magician
Added support for auto and deprecated automatic field in `google_…
1516341 
…secret_manager_secret` resource (hashicorp#8838)

* Added support for automatic_replication field in google_secret_manager_secret resource

* Replaced deprecated field automatic with automatic_replication in terraform configs

* Improved the deprecation_message

* Changed the name of field from automatic_replication to auto

* Adjusted white spaces

* Added test case to cover the automatic field

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 7762094 into hashicorp:main Sep 11, 2023
4 checks passed
@philip-harvey philip-harvey mentioned this pull request Sep 18, 2023
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@modular-magician