Unblock EXTERNAL/EXTERNAL_VPC Cloud KMS key creation. #17704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:a1e15b7437a5b41602e434668bf07434c2873336] Signed-off-by: Modular Magician <magic-modules@google.com>
jac
added a commit
to sourcegraph/managed-services-platform-cdktf
that referenced
this pull request
Apr 24, 2024
Upgrade to pull in the improvement to cloud run creation > Fix Cloud Run v2 resources creation failure state inconsistency hashicorp/terraform-provider-google#17711 I had a look through the changelog and is a breaking change and a deprecation none of which should affect us > BREAKING CHANGES: > > networksecurity: added required field billing_project_id to google_network_security_firewall_endpoint resource. Any configuration without billing_project_id specified will cause resource creation fail (beta) (hashicorp/terraform-provider-google#17630) > DEPRECATIONS: > > kms: deprecated attestation.external_protection_level_options in favor of external_protection_level_options in google_kms_crypto_key_version (hashicorp/terraform-provider-google#17704)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
external_protection_level_optionsfield had been nested within the attestation field by accident. See #15004 for more information about this change..NOTE: this is the initial deprecation notice, and we are just adding a duplicate set of fields outside of
attestation. When the old field is eventually removed, it should not break any CUJs because the current state of things does not allow for successful key creation (malformed requests would be rejected by the server). The old, deprecated field will be removed in the next release.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9931