Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update d/datasource_compute_network documentation #5686

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

jeet-parekh
Copy link
Contributor

Changed the network attribute to id inside the d/datasource_compute_network documentation.
https://www.terraform.io/docs/providers/google/d/datasource_compute_network.html

Fixes #5623.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change - it seems to me that the parent network info isn't in the resource at all, so I'll delete this line instead.

@nat-henderson nat-henderson merged commit c88f547 into hashicorp:master Feb 28, 2020
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs for data.google_compute_network are incorrect for attribute id
2 participants