rm deprecated parameter from forwarding_rule example #5758
Conversation
ghost
requested review from
|
added a reversion of 713012c, which broke ci - that commit is documenting a resource which doesn't exist yet (seems like @modular-magician automagically added this because the terraform-provider-google-beta has this resource). |
rremer
force-pushed
the
doc-allow_global_access
branch
from
713012c to
f8d9708
Compare
|
removed my second commit, which was done later by modular-magician in 1f9e0cb |
There was a problem hiding this comment.
Thank you for your contribution! Let me know if you're having issues running the example and we can try and troubleshoot what the issue might be. I noticed that it is now available in the v1 API, so I think we could even propagate it to google rather than only google-beta if that is what you are looking for.
Thanks!
| @@ -50,7 +50,6 @@ resource "google_compute_forwarding_rule" "default" { | |||
| load_balancing_scheme = "INTERNAL" | |||
| backend_service = "${google_compute_region_backend_service.backend.self_link}" | |||
| all_ports = true | |||
| allow_global_access = true | |||
There was a problem hiding this comment.
allow_global_access is an option on the google-beta provider as you can see here: https://github.com/terraform-providers/terraform-provider-google-beta/blob/master/google-beta/resource_compute_forwarding_rule.go#L112
And it looks like it is available in the API as well, so I think it should be fine. https://cloud.google.com/compute/docs/reference/rest/beta/forwardingRules
There was a problem hiding this comment.
just beta, but if we're now documenting beta-only features on that page without specifying them as beta-only, that's fine I guess; just confusing.
There was a problem hiding this comment.
HI @rremer, I'm sorry for the confusion! We try to label beta-only fields as (Optional, Beta), and it appears this field was labeled that way. However, if that didn't read as beta-only to you, I would love some feedback on what kind of documentation you would like for that. Thanks!
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Documentation update.
This field 'allow_global_access' does not exist in any version of the provider I can find. Additionally, not addressed by this commit, is that there is some out-of-date (or generated?) description of this field here: https://www.terraform.io/docs/providers/google/r/compute_forwarding_rule.html#allow_global_access