Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm deprecated parameter from forwarding_rule example #5758

Closed
wants to merge 1 commit into from
Closed

rm deprecated parameter from forwarding_rule example #5758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion website/docs/r/compute_forwarding_rule.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ resource "google_compute_forwarding_rule" "default" {
load_balancing_scheme = "INTERNAL"
backend_service = "${google_compute_region_backend_service.backend.self_link}"
all_ports = true
allow_global_access = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow_global_access is an option on the google-beta provider as you can see here: https://github.com/terraform-providers/terraform-provider-google-beta/blob/master/google-beta/resource_compute_forwarding_rule.go#L112

And it looks like it is available in the API as well, so I think it should be fine. https://cloud.google.com/compute/docs/reference/rest/beta/forwardingRules

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just beta, but if we're now documenting beta-only features on that page without specifying them as beta-only, that's fine I guess; just confusing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @rremer, I'm sorry for the confusion! We try to label beta-only fields as (Optional, Beta), and it appears this field was labeled that way. However, if that didn't read as beta-only to you, I would love some feedback on what kind of documentation you would like for that. Thanks!

network = "${google_compute_network.default.name}"
subnetwork = "${google_compute_subnetwork.default.name}"
}
Expand Down